From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yliu@fridaylinux.org> Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 469D52BC9 for <dev@dpdk.org>; Fri, 4 Aug 2017 06:07:36 +0200 (CEST) Received: by mail-pf0-f172.google.com with SMTP id t86so2955657pfe.2 for <dev@dpdk.org>; Thu, 03 Aug 2017 21:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V33x+TF6Oen3FvMXNa4c9Vt2UsbSPc0Cyun37OmQDho=; b=vIQVLMpeQEMwSYlP/KdS0E6X2XcZOsrmKiR8y/LERWHm1X9WVKV1j83YvzQ/CZT6lz Yc8eZiAqCaYpwjVHNwNmCycXk2YhM01L/4ddAdXWpe1h/ktGkLbFMtiVEsgoE/F5dunK e9XeFA4vyDNdsR52vZ9hSC09cQBwal9MzocwgucD7JGWtAF3a5m7nPzpIBt02txTZnLp ZWuJ35vXGsOiV73X+UcVE2vOmpWsaEJOTPvl7tnTyQeU64A35DHjQJ5U1v2wGBdlNN12 TZQmuNLvr5SuLYox+/EzDSMTBMOiyX+xursFRPTOzNrahrh0f1hxR8P8aHT6S5jtGDn4 FxnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V33x+TF6Oen3FvMXNa4c9Vt2UsbSPc0Cyun37OmQDho=; b=J6RsYxynmPJcyCTGuspkG0ERGox0irkJ1hVY2w0P0QjddYBUNKuvglG4FpY3M+xwWZ yDJxAhZEw0rd1aLHHpsss2xaNt5W+rgnf1qqJcYWBdgW8hZHYOt+IyB5raKTqac9BAMt vDw2e/rpU/x3mJY9yKn/26WIDADJSfZgUdzY6HmIOu5gb91EIXIfc5x0HtXw9DGcEf/o 0S8USlWckXGWgbksADmjI1IKZJtsHawYptXQdhIVQSf1DonpQkdW5ZC27zIxSTaQo8w9 T87xu9QYFJdUWJed+p2W/zVMBj+rq5oHfVHzIhA/YV9TIZRpoImOIZ5MsK/wfM23GS78 jiBA== X-Gm-Message-State: AIVw113KvGS1XraCwmL4+1h3j6poBPHS/Nn6p7yxW8MWvPEOTMrhlisN 3swXA/CqNc3kPg+i X-Received: by 10.84.178.37 with SMTP id y34mr1161163plb.125.1501819655470; Thu, 03 Aug 2017 21:07:35 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id z16sm688397pff.178.2017.08.03.21.07.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Aug 2017 21:07:33 -0700 (PDT) Date: Fri, 4 Aug 2017 12:07:28 +0800 From: Yuanhan Liu <yliu@fridaylinux.org> To: Zhiyong Yang <zhiyong.yang@intel.com> Cc: dev@dpdk.org, zhihong.wang@intel.com, john.mcnamara@intel.com, oilvier.matz@6wind.com, thomas@monjalon.net Message-ID: <20170804040728.GE9612@yliu-home> References: <20170712075846.14834-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170712075846.14834-1-zhiyong.yang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 04 Aug 2017 04:07:36 -0000 On Wed, Jul 12, 2017 at 03:58:46PM +0800, Zhiyong Yang wrote: > This is an API/ABI change notice for DPDK 17.11 on redefinition of Don't put 2 whitespace char indentation here. > port_id. port_id is defined as uint8_t by now, which is just ranged > from 0 to 255. For more and more scenerioes, more than 256 devices are > needed to support for vdev scalability. > > It is necessary for redefinition of port_id to extend from 1 bytes > to 2 bytes. All ethdev APIs and use cases related to port_id will be > changed at the same time. > > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 257dcba..f265980 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -54,6 +54,10 @@ Deprecation Notices > Target release for removal of the legacy API will be defined once most > PMDs have switched to rte_flow. > > +* ABI/API changes are planned for 17.11 in the "rte_eth_dev_data" structure. That's for ABI only and you missed the API part. Meaning, you need also mention that all APIs have port_id parameter will be changed too. Also, rte_eth_dev_data is not the only structure has ABI changes. There are few more (for instance, rte_port_ethdev.h). As said before, you don't have to list all of them, but at least you should not list one example only as it seems that's the only structure has ABI change. > + Change the definition of port_id from 8bits to 16bits in order to support > + more than 256 devices in DPDK. 8bits -> 8 bits. You might want to reword it further. Besides that, this change is indeed needed. Thus, Acked-by: Yuanhan Liu <yliu@fridaylinux.org> --yliu > + > * librte_table: The ``key_mask`` parameter will be added to all the hash tables > that currently do not have it, as well as to the hash compute function prototype. > The non-"do-sig" versions of the hash tables will be removed > -- > 2.9.3