From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F38EC2C55 for ; Fri, 4 Aug 2017 11:36:00 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2017 02:35:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="133515189" Received: from dpdk15.sh.intel.com ([10.67.111.77]) by orsmga005.jf.intel.com with ESMTP; 04 Aug 2017 02:35:59 -0700 Date: Fri, 4 Aug 2017 17:37:43 +0800 From: Jiayu Hu To: "Mcnamara, John" Cc: "dev@dpdk.org" , "thomas@monjalon.net" Message-ID: <20170804093743.GA28026@dpdk15.sh.intel.com> References: <1499743655-86736-1-git-send-email-jiayu.hu@intel.com> <1501834844-25765-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v2] doc: add prog_guide for the GRO library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 09:36:01 -0000 Hi John, On Fri, Aug 04, 2017 at 05:11:18PM +0800, Mcnamara, John wrote: > > -----Original Message----- > > From: Hu, Jiayu > > Sent: Friday, August 4, 2017 9:21 AM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; Mcnamara, John ; Hu, > > Jiayu > > Subject: [PATCH v2] doc: add prog_guide for the GRO library > > > > Add prog_guide doc to explain the design of the GRO library. > > > ... > > > +Generic Receive Offload Library > > +=============================== > > + > > ... > > + > > +The GRO library assumes all inputted packets are with correct checksums. > > +In addition, the GRO library doesn't re-calculate checksums for merged > > +packets. If inputted packets are IP fragmented, the GRO library assumes > > +they are complete packets (i.e. with L4 headers). > > It is more correct/common to use input instead of inputted. You should > make this change throughout the doc. Thanks a lot and I will change them. BRs, Jiayu > > Also this bout be better as: > > The GRO library assumes all input packets have correct checksums. In addition, the GRO library doesn't re-calculate checksums for merged packets. > > Apart from that: > > Acked-by: John McNamara