From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 183892C19 for ; Fri, 4 Aug 2017 12:20:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B718E20966; Fri, 4 Aug 2017 06:20:48 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 04 Aug 2017 06:20:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=3rjprsj91tbo8NuMcV9SLi03SfNu+bg5ep0145 z9eas=; b=pLmm/dxnWwWyigS9Q6NERBFKXoCRS210ro6+IS3vkxk/RjLuGUNNcD 7nnGVcRT3tfUw7siYs8aJSphm8XuEz9H0COtlTwZvl7aGh7AbeQV1C4S5Xc70QZu ghZ44K8LHZsTN1QOxrWulZ5VJ31QL1bf8ESgbV7FyZMyoiwzZ75k8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=3rjprsj91tbo8NuMcV 9SLi03SfNu+bg5ep0145z9eas=; b=QthmveOKDKBmMvU7Rxd3WA1+oWDf8ruisv QVwYevpmPEz4BKzuOqtsrDCoaY0ip8+5RM2UfukFNclvs50k/zWzZi2q/RKs4s95 ZObJO3eyGDwE0UQJbiRc9K9CUWdiEgf9ztRr3eHunKpQX/cIdCQOWc0HtLu3XcrR fKR1iMi0b9/uj3Cwrj+IxUn5YfsZxWfpjuGGgQqfFrPbThL7nraZCm5b37kpksFN awDe79xkhtwYxzHtrTwIb4Z1mWVKeY8ngroDqlPkclBGsmI1l28aMblO/MpRTsiF 3aOKQYliwjx0onVYaGd4h0lF6KgmSqV1ryGJ8Ef8z1M/0hru7n1g== X-ME-Sender: X-Sasl-enc: YAA0BVzm9imPrDLHvQdIwixxH70bwZ6euShgxntdjyDr 1501842047 Received: from xps.monjalon.net (159.16.90.92.rev.sfr.net [92.90.16.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 139EB248DD; Fri, 4 Aug 2017 06:20:46 -0400 (EDT) From: Thomas Monjalon To: jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Date: Fri, 4 Aug 2017 12:20:35 +0200 Message-Id: <20170804102035.4051-1-thomas@monjalon.net> X-Mailer: git-send-email 2.13.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] eventdev: fix missing includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 10:20:49 -0000 The PCI helper file depends on some EAL definitions. Spotted with devtools/check-includes.sh: error: implicit declaration of function ‘rte_eal_process_type’ error: ‘RTE_PROC_PRIMARY’ undeclared error: implicit declaration of function ‘rte_socket_id’ There was also this error because the inline keyword was missing: error: ‘rte_event_pmd_pci_probe’ defined but not used Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional") Signed-off-by: Thomas Monjalon --- lib/Makefile | 2 +- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index 86caba17b..22962910d 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether DEPDIRS-librte_ip_frag += librte_hash DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net +DEPDIRS-librte_gro := librte_eal librte_mbuf DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += librte_jobstats DEPDIRS-librte_jobstats := librte_eal DIRS-$(CONFIG_RTE_LIBRTE_METRICS) += librte_metrics diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h index 1dbba373c..b6bd7319e 100644 --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h @@ -47,6 +47,8 @@ extern "C" { #include +#include +#include #include #include "rte_eventdev_pmd.h" @@ -58,7 +60,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev); * Wrapper for use by pci drivers as a .probe function to attach to a event * interface. */ -static int +static inline int rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev, size_t private_data_size, -- 2.13.2