* [dpdk-dev] [PATCH] eventdev: fix missing includes
@ 2017-08-04 10:20 Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Thomas Monjalon @ 2017-08-04 10:20 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev
The PCI helper file depends on some EAL definitions.
Spotted with devtools/check-includes.sh:
error: implicit declaration of function ‘rte_eal_process_type’
error: ‘RTE_PROC_PRIMARY’ undeclared
error: implicit declaration of function ‘rte_socket_id’
There was also this error because the inline keyword was missing:
error: ‘rte_event_pmd_pci_probe’ defined but not used
Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/Makefile | 2 +-
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/Makefile b/lib/Makefile
index 86caba17b..22962910d 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
DEPDIRS-librte_ip_frag += librte_hash
DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
-DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
+DEPDIRS-librte_gro := librte_eal librte_mbuf
DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += librte_jobstats
DEPDIRS-librte_jobstats := librte_eal
DIRS-$(CONFIG_RTE_LIBRTE_METRICS) += librte_metrics
diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
index 1dbba373c..b6bd7319e 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -47,6 +47,8 @@ extern "C" {
#include <string.h>
+#include <rte_eal.h>
+#include <rte_lcore.h>
#include <rte_pci.h>
#include "rte_eventdev_pmd.h"
@@ -58,7 +60,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev);
* Wrapper for use by pci drivers as a .probe function to attach to a event
* interface.
*/
-static int
+static inline int
rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
struct rte_pci_device *pci_dev,
size_t private_data_size,
--
2.13.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: fix missing includes
2017-08-04 10:20 [dpdk-dev] [PATCH] eventdev: fix missing includes Thomas Monjalon
@ 2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:44 ` Thomas Monjalon
2017-08-04 10:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2017-08-04 12:32 ` [dpdk-dev] [PATCH] " Mcnamara, John
2 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2017-08-04 10:35 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
-----Original Message-----
> Date: Fri, 4 Aug 2017 12:20:35 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: [PATCH] eventdev: fix missing includes
> X-Mailer: git-send-email 2.13.2
>
> The PCI helper file depends on some EAL definitions.
> Spotted with devtools/check-includes.sh:
> error: implicit declaration of function ‘rte_eal_process_type’
> error: ‘RTE_PROC_PRIMARY’ undeclared
> error: implicit declaration of function ‘rte_socket_id’
>
> There was also this error because the inline keyword was missing:
> error: ‘rte_event_pmd_pci_probe’ defined but not used
>
> Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/Makefile | 2 +-
> lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 86caba17b..22962910d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
> DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
> DEPDIRS-librte_ip_frag += librte_hash
> DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
> -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
> +DEPDIRS-librte_gro := librte_eal librte_mbuf
Looks like unrelated change. Right?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: fix missing includes
2017-08-04 10:35 ` Jerin Jacob
@ 2017-08-04 10:44 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2017-08-04 10:44 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev
04/08/2017 12:35, Jerin Jacob:
> -----Original Message-----
> > Date: Fri, 4 Aug 2017 12:20:35 +0200
> > From: Thomas Monjalon <thomas@monjalon.net>
> > To: jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org
> > Subject: [PATCH] eventdev: fix missing includes
> > X-Mailer: git-send-email 2.13.2
> >
> > The PCI helper file depends on some EAL definitions.
> > Spotted with devtools/check-includes.sh:
> > error: implicit declaration of function ‘rte_eal_process_type’
> > error: ‘RTE_PROC_PRIMARY’ undeclared
> > error: implicit declaration of function ‘rte_socket_id’
> >
> > There was also this error because the inline keyword was missing:
> > error: ‘rte_event_pmd_pci_probe’ defined but not used
> >
> > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > lib/Makefile | 2 +-
> > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 86caba17b..22962910d 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
> > DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
> > DEPDIRS-librte_ip_frag += librte_hash
> > DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
> > -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
> > +DEPDIRS-librte_gro := librte_eal librte_mbuf
>
> Looks like unrelated change. Right?
Yes you're right.
I wanted to remove this wrong part of the patch and forgot.
Will send a v2, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] eventdev: fix missing includes
2017-08-04 10:20 [dpdk-dev] [PATCH] eventdev: fix missing includes Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
@ 2017-08-04 10:47 ` Thomas Monjalon
2017-08-04 12:32 ` [dpdk-dev] [PATCH] " Mcnamara, John
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2017-08-04 10:47 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev
The PCI helper file depends on some EAL definitions.
Spotted with devtools/check-includes.sh:
error: implicit declaration of function ‘rte_eal_process_type’
error: ‘RTE_PROC_PRIMARY’ undeclared
error: implicit declaration of function ‘rte_socket_id’
There was also this error because the inline keyword was missing:
error: ‘rte_event_pmd_pci_probe’ defined but not used
Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: remove bad change in Makefile (thanks Jerin)
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
index 1dbba373c..b6bd7319e 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -47,6 +47,8 @@ extern "C" {
#include <string.h>
+#include <rte_eal.h>
+#include <rte_lcore.h>
#include <rte_pci.h>
#include "rte_eventdev_pmd.h"
@@ -58,7 +60,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev);
* Wrapper for use by pci drivers as a .probe function to attach to a event
* interface.
*/
-static int
+static inline int
rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
struct rte_pci_device *pci_dev,
size_t private_data_size,
--
2.13.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: fix missing includes
2017-08-04 10:20 [dpdk-dev] [PATCH] eventdev: fix missing includes Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
@ 2017-08-04 12:32 ` Mcnamara, John
2017-08-04 23:18 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Mcnamara, John @ 2017-08-04 12:32 UTC (permalink / raw)
To: Thomas Monjalon, jerin.jacob; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, August 4, 2017 11:21 AM
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: fix missing includes
>
> The PCI helper file depends on some EAL definitions.
> Spotted with devtools/check-includes.sh:
> error: implicit declaration of function ‘rte_eal_process_type’
> error: ‘RTE_PROC_PRIMARY’ undeclared
> error: implicit declaration of function ‘rte_socket_id’
>
> There was also this error because the inline keyword was missing:
> error: ‘rte_event_pmd_pci_probe’ defined but not used
>
> Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions
> optional")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Spotted with devtools/check-includes.sh:
That is a good reminder for people to add this to their patch workflow or to some automated tests.
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: fix missing includes
2017-08-04 12:32 ` [dpdk-dev] [PATCH] " Mcnamara, John
@ 2017-08-04 23:18 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2017-08-04 23:18 UTC (permalink / raw)
To: dev; +Cc: Mcnamara, John, jerin.jacob
> > The PCI helper file depends on some EAL definitions.
> > Spotted with devtools/check-includes.sh:
> > error: implicit declaration of function ‘rte_eal_process_type’
> > error: ‘RTE_PROC_PRIMARY’ undeclared
> > error: implicit declaration of function ‘rte_socket_id’
> >
> > There was also this error because the inline keyword was missing:
> > error: ‘rte_event_pmd_pci_probe’ defined but not used
> >
> > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions
> > optional")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
>
> > Spotted with devtools/check-includes.sh:
>
> That is a good reminder for people to add this to their patch workflow or to some automated tests.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-04 23:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 10:20 [dpdk-dev] [PATCH] eventdev: fix missing includes Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:44 ` Thomas Monjalon
2017-08-04 10:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2017-08-04 12:32 ` [dpdk-dev] [PATCH] " Mcnamara, John
2017-08-04 23:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).