DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: fix MAC VLAN filter fail problem
@ 2017-08-08  6:18 wei zhao
  0 siblings, 0 replies; 3+ messages in thread
From: wei zhao @ 2017-08-08  6:18 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, Wei Zhao, root

Add a mode type check for MAC VLAN mode, if fdir is
in this mode, it do not need to do Sanity check for x550.

Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Signed-off-by: root <root@dpdk2.bj.intel.com>
---
 drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index eb2d558..7c10cab 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1276,7 +1276,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 	     rule->ixgbe_fdir.formatted.flow_type ==
 	     IXGBE_ATR_FLOW_TYPE_IPV6) &&
 	    (info->mask.src_port_mask != 0 ||
-	     info->mask.dst_port_mask != 0)) {
+	     info->mask.dst_port_mask != 0) &&
+	     rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
 		PMD_DRV_LOG(ERR, "By this device,"
 			    " IPv4 is not supported without"
 			    " L4 protocol and ports masked!");
-- 
2.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix MAC VLAN filter fail problem
  2017-08-08  6:19 wei zhao
@ 2017-08-18 14:20 ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-08-18 14:20 UTC (permalink / raw)
  To: wei zhao, dev; +Cc: qi.z.zhang

On 8/8/2017 7:19 AM, wei zhao wrote:
> Add a mode type check for MAC VLAN mode, if fdir is
> in this mode, it do not need to do Sanity check for x550.
> 
Fixes: dc0c16105d2d ("ixgbe: fix X550 flow director check")
Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH] net/ixgbe: fix MAC VLAN filter fail problem
@ 2017-08-08  6:19 wei zhao
  2017-08-18 14:20 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: wei zhao @ 2017-08-08  6:19 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, Wei Zhao

Add a mode type check for MAC VLAN mode, if fdir is
in this mode, it do not need to do Sanity check for x550.

Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---
 drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index eb2d558..7c10cab 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1276,7 +1276,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 	     rule->ixgbe_fdir.formatted.flow_type ==
 	     IXGBE_ATR_FLOW_TYPE_IPV6) &&
 	    (info->mask.src_port_mask != 0 ||
-	     info->mask.dst_port_mask != 0)) {
+	     info->mask.dst_port_mask != 0) &&
+	     rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
 		PMD_DRV_LOG(ERR, "By this device,"
 			    " IPv4 is not supported without"
 			    " L4 protocol and ports masked!");
-- 
2.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-18 14:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08  6:18 [dpdk-dev] [PATCH] net/ixgbe: fix MAC VLAN filter fail problem wei zhao
2017-08-08  6:19 wei zhao
2017-08-18 14:20 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).