From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5FF5B376C for ; Thu, 10 Aug 2017 10:34:22 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2017 01:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,352,1498546800"; d="scan'208";a="888485776" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by FMSMGA003.fm.intel.com with SMTP; 10 Aug 2017 01:34:19 -0700 Received: by (sSMTP sendmail emulation); Thu, 10 Aug 2017 09:34:19 +0100 Date: Thu, 10 Aug 2017 09:34:18 +0100 From: Bruce Richardson To: Neil Horman Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20170810083418.GA53940@bricha3-MOBL3.ger.corp.intel.com> References: <20170809202425.1356-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809202425.1356-1-nhorman@tuxdriver.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] atm: Remove machine definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 08:34:23 -0000 On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote: > With the new updated requirement for SSE4.2, dpdk no longer supports > building on atom machines, as they only support up to SSE3. Remove > the machine definition. > > Signed-off-by: Neil Horman CC: Thomas Monjalon > --- mk/machine/atm/rte.vars.mk | 58 > ---------------------------------------------- 1 file changed, 58 > deletions(-) delete mode 100644 mk/machine/atm/rte.vars.mk > Yes, good catch, that should have been removed. However, I think the commit log should be updated to mention that it no longer supports "early" atom machines, or some similar phrase. Atom cores for the last number of years do support SSE4, see: https://en.wikipedia.org/wiki/Silvermont for example. With that change, Acked-by: Bruce Richardson