From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 5FCC12BA1 for ; Thu, 10 Aug 2017 13:34:12 +0200 (CEST) Received: from [2606:a000:111b:4246:ce17:ba0d:7461:5cd1] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1dfliv-00012A-P3; Thu, 10 Aug 2017 07:34:10 -0400 Date: Thu, 10 Aug 2017 07:33:57 -0400 From: Neil Horman To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20170810113356.GA14414@hmswarspite.think-freely.org> References: <20170809202425.1356-1-nhorman@tuxdriver.com> <20170810083418.GA53940@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810083418.GA53940@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH] atm: Remove machine definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 11:34:12 -0000 On Thu, Aug 10, 2017 at 09:34:18AM +0100, Bruce Richardson wrote: > On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote: > > With the new updated requirement for SSE4.2, dpdk no longer supports > > building on atom machines, as they only support up to SSE3. Remove > > the machine definition. > > > > Signed-off-by: Neil Horman CC: Thomas Monjalon > > --- mk/machine/atm/rte.vars.mk | 58 > > ---------------------------------------------- 1 file changed, 58 > > deletions(-) delete mode 100644 mk/machine/atm/rte.vars.mk > > > Yes, good catch, that should have been removed. However, I think the > commit log should be updated to mention that it no longer supports > "early" atom machines, or some similar phrase. Atom cores for the last > number of years do support SSE4, see: > https://en.wikipedia.org/wiki/Silvermont for example. > I don't really agree with that. If you want to make the claim that only early atom machines aren't supported, the implication then is that later atom machines are, and we should keep the machine type, and fix it to build for those targeted machines (as it stands currently, the compiler errors out on building atom because it only emits SSE3 instructions and can't inline an SSE4 builtin). I'd be totally fine with fixing the atom build (which I imageine amounts to passing -machine=atom -msse4 or something simmilar to the build options. Once we do that however, we likely need a runtime check for sse4 support as well, so we don't just get random SIGILL errors at run time. Neil > With that change, > Acked-by: Bruce Richardson > >