From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0080.outbound.protection.outlook.com [104.47.41.80]) by dpdk.org (Postfix) with ESMTP id 92672912D for ; Mon, 14 Aug 2017 13:12:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DOA4EN6hr0bPPEijZEVoQyZyMIbp8LMJhm0q/erMv5I=; b=GEb9QcRw9chrvlsFUUcOUe1fU/pFqz8111cogU6H6OHzU+Hmt723kqZ47LozWTN9gdeQ/H6tVISUFXE64Qc8xfZVK5NMtHLkRIWxMfNibMeJPjxQWnCNZmarvd2roxJv29wyFHMkPKawnfIN6A+eM+5BBcUBc6aYsNivpW01gzo= Received: from jerin (111.93.218.67) by CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21; Mon, 14 Aug 2017 11:12:03 +0000 Date: Mon, 14 Aug 2017 16:41:46 +0530 From: Jerin Jacob To: "Rao, Nikhil" Cc: "Eads, Gage" , "dev@dpdk.org" , "thomas@monjalon.net" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Gujjar, Abhinandan S" Message-ID: <20170814111001.GA12530@jerin> References: <20170729151252.GA25166@jerin> <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com> <20170801164242.GA6467@jerin> <9184057F7FC11744A2107296B6B8EB1E01F00701@FMSMSX108.amr.corp.intel.com> <20170803062315.GA14704@jerin> <9184057F7FC11744A2107296B6B8EB1E01F030FC@FMSMSX108.amr.corp.intel.com> <20170809161946.GA6650@jerin> <9184057F7FC11744A2107296B6B8EB1E01F0EEF4@FMSMSX108.amr.corp.intel.com> <20170810165319.GA6051@jerin> <3fe6768a-7422-8006-5d37-961b0b31afa3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fe6768a-7422-8006-5d37-961b0b31afa3@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0036.INDPRD01.PROD.OUTLOOK.COM (10.174.214.22) To CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4156c811-f799-456e-c3d7-08d4e3054ca0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:rY+rrfSPMzmpVou2fXCycgEw3orHObca/N/2OVNPPRLmiJ1E1fsGU1KRG0msu7IzbEUqSN2zB7HfV6qi1/bny1h5N3KLyu2/T7y2UorXNfrq8SAZqeBHY5X6ofzht671xqs+C0F/CMcHyRFr0IK2OOw8Uf3z239AvjxIe+TFdEwg5U9dfKRNM1BuK21cgKmziuggcsxrLFTLL5JHXBM+fTIA33CWBbAI1ZXfKFDhmgRAa6u9e/TdWZ6cI6879j0a; 25:RDT76ubEF/bXGwnJK21VbTt9adC/3u1cVzVlEF8re22a0ANN/QdK9s0yj/EtkiNKwPVbPiVnsKQQO6CA7rEL8sCpuStcZY+QGdyMBsubj/yk1xSMu8hnzThYNLYDe9fSR1S+aihIQfswku/hKH1LcvPAWa7s/LrTH0y8tPzuA/tpnURX0Fw82y4BalkyD06qpnv+ESmua0q0kMsvYfXipVOOJTqA444CiIlc7BC/+6TQJxR4SxQe/6uu+9SL6qse76ygY+KjF+QykkdTBv4cN13gmyOMX2ojPE9YqS34L2YLc4Z3VVhrqFxrF+C/knF93kYUi7t+OqyUuImVGFFbkg==; 31:f+jqU8tsG8gO1U7YQZoEHCP6MRQLUuBpY3J3+s+rjbrJyAX7Xo3A1BFJ1H6elxlx7xEqPy0P3L08K3NfVTzvF1v7Q6gjuW33q21HAXZAfWBb81LmRNoc6ixT4d4uPozqW5QFETW/dSn9Uqp4uX5jr1P0unLglHbdWCKogUToSxaXi5o/h5XP1XlwjP6C2SbVdtuXUjVgwJrpV/rn4DXXMiANEhw6BxhOmvaGDr8sfGw= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:wzRj1MAgIAbFRLbAIYHRzGS5BbPBbUqgxxLzga+pQlp2RRV5hqxZJLKgOTS9XzxS0zo5bWCXKV5A6NEmTpKG5faRs7Rr7zAzqyjkRdKPqDqThn+jVc4KrbWiHidzTP7YTE8/ZGjncndUA7UnSaFf8ESR8Be69+FHmsx+cqxo7GV376Vw2oXDASYCN43slWUE7dUCDct9vbjQkii9H5T9QvfjOL1AsQtUA2tgeXiK6rTDMHbYqP1eTnnNLcfePmVpubQqUZLam+xsceCkyZviZIBTTkYyeK28otyrJhZRY8DU+KPLCMdq7gfP1fvqx4mOsHaTCpAE1mWsQznOp0ruaWK55BoKuQJ2mWPY3EQxzCuDfh0NA8AyE6Pph+Vm3m66tPSrNWG+nv8FiIyi2BxvJ4QCIYQA9N5vx6CwypwtoQ0kEtP6DVi2sapjKoJtX0jKsigbHqO8ldqo8by82Tup9vHs5r26B6+5xU5k7yAGMcgJ/jUUa93QuGniCN5IzH2Sjt+eWdqE8K5SZ1j+Ga8ORsdvPzMRM2Ipe/p8IptBFKqUv+L7+SXHmuYSI8suhIqDVbvPUP8nFQFUjsUHaa5JHQSoRhultDY1kxmEIWVnl6Y= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 4:t9Qxircc65xuXl60ZM/CQm3w39o1kMPJQdng8G99LOZ3Jml4So5ytx+mAhGaleV92WOzOqBpMYpGDFaumbFac2vk+7psMqcJk02eXw/jdDNffezpQupg6lgHJ/m2ujGnvsz3OBHjU6YubXbUt99YWi9sImjCbtk5947v2mJTRChlXBQCjYOBjH4DZYx729XKFVJzzTrfj3Vl+vCheFNXWgpQAZtbFjcB+k5QMgCs62aahqFIvvElcVAd+YkEEv+u5v2oglIj8LKUzXIWq2f2nm7dx9jI5p+KgeWnz4b+f31BDnzVXBBNjk4mXkDcFgLp2ycL5TevqxJO5mUf/XoCsw== X-Forefront-PRVS: 039975700A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(199003)(189002)(24454002)(377454003)(13464003)(2950100002)(25786009)(189998001)(6666003)(4326008)(4001350100001)(105586002)(229853002)(7416002)(50466002)(106356001)(83506001)(478600001)(97736004)(55016002)(53546010)(54906002)(6916009)(42882006)(5660300001)(9686003)(33716001)(110136004)(50986999)(54356999)(76176999)(33656002)(68736007)(1076002)(6246003)(6496005)(53936002)(72206003)(101416001)(93886004)(305945005)(2906002)(7736002)(81166006)(42186005)(81156014)(47776003)(66066001)(7350300001)(5009440100003)(3846002)(6116002)(23726003)(8656003)(8676002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2518; 23:cTqtyfM86jcDHaudXviqXKyb27h9z6I522be1nhKg?= =?us-ascii?Q?ynFPAkRpKnBRNhEgh1R254cnvtu3Cdt4H+uXxDTa1sNgCgdbZl+bjYf/YbUR?= =?us-ascii?Q?3Ujbqs8XEc7v/+Peh1+68mxVY0xq1gOAYv59gKqw6SMGL2FCbMFBsNgtQs00?= =?us-ascii?Q?3nQ6KuPXofMC6rICp4d8oQwxYjCE0UcD3EMKxJ0r3mPYIfnNyM3Q7YtjgaDb?= =?us-ascii?Q?S1WLvKmQ5yHuWU3yqFyT2y42e4RnpQtTEkMhAmOjzScLLUuULSTbJQx3Q+e9?= =?us-ascii?Q?paNTuZ9k93c5bMqZO92tEmVS1Wawfch71oGu46EUYvzWWmFFda7US35JsMGR?= =?us-ascii?Q?DbzSLBbdtnxLyZFiLpl8wD4RisHlL0rx6v3q2XoNNkojqxshoECJ/bDJTaH5?= =?us-ascii?Q?2cfZRTuW9YIcPC86KS5UwD5Bk+t1++UVm03WuGTEBGd3zdNrXd1zER8Gbu3J?= =?us-ascii?Q?xhToOaZkezXKh/cFsncJm4kNOoRAxPiECf2Maub+y4yZqm8/4+VOIZlZYZ7T?= =?us-ascii?Q?ItTDOrt+mQdsmhjNfcMy4i/YFXRFgI36Bh+TQ8vJW1gf8lWP7N627fr6W7mV?= =?us-ascii?Q?8fhGTDQ+BKIgO2wcCrBjh+zW+MwDXAi1mctXBVaQQQh+htS3y6/CnDv9pK3J?= =?us-ascii?Q?P7Ai7WbUZ3NsiKbfRwlVK5Ktoaqk38PXp31s1Co6P0G46lKHmn9UHz2h8xEV?= =?us-ascii?Q?Za1ywZJ4DMJejlHZ88WOuVe0ldaoJzAGQJnIMrK8N35ns+8c7htPpYxzpWv1?= =?us-ascii?Q?vRtbIlaFJ0/hv0V5AY5exPwSLheM9Q6txhHgAhElBLhcshhcOf2F4LrAB4DS?= =?us-ascii?Q?Z1SsWAadHSP7FGVWFWiKLh8R8Oi9NYkazcAywQRoprbfRjA0D4wCt5r/SbwP?= =?us-ascii?Q?DIT2irb52jQS7uHjS2yQCkVT5jxLeTMaylC9q85UDtgqWqLipx8JTcrnSGKP?= =?us-ascii?Q?y0RgmzuUVZR08d5mIKwR2RxuVFhVjtsZ6GMQiZ27iANXPXixdai+KguUohfQ?= =?us-ascii?Q?jy7PQfXZf4Sxs/IQWDldwQKhMCr272mjx7GYtaQxtfPjTF+fx+E7T0Y0+wk4?= =?us-ascii?Q?vU+zC4xfvlVO6Y0yvpG/HvMfsqpBVT2dPxFdx1Fx6LLXEdYiRuxIOt4I++pG?= =?us-ascii?Q?JRDwK0wt8o8iOW1z/g0PGnyTlawHecIG6xEoSciQ7WCWt0C5SSDsvg1ND2Jx?= =?us-ascii?Q?16s8LGK++8TKmbSDNPZDHS5eeUrltlvm1zPijvwKkCaWRVwlS1GQdRvWFH9r?= =?us-ascii?Q?ft/10J88xa6VbDTHSuzDgOeW0X9M+Qcl0wBj2YIsCpagnq2qJExGGTxy+i8s?= =?us-ascii?Q?ESY0kPMZbIcDp572FzcnUiKhM0MHFGsmXrr4QBejVjdW1TlfsbT9V9rGYz0d?= =?us-ascii?Q?TDXOsK12h6CTERVMMVb2G7+uDzWk/oxTc5kGGGSsASh5eFVwkSY0HE/0VjN7?= =?us-ascii?Q?UENONWoug=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:ftZ+2iMoQkG+wuLpzOBd/yxEEepGV4j2xwoMSCX5ve08luPeaXshgm7KKy1j2TWSeLHMZTEbkQsKeCLu/dFXgTxHiiZt9dlEjCdQ6UIt0FEPUGHwM0LiP/gzrjp0WIw61Q8U7egAlW6xTAiY3Ou73j+/Q8qZ2px0S3/HeR3iCL+9FYZ+6GaRQaqueQ8RJyoVk2TWNhyutxfBtKv0GPtvzTasAwE+Tq08vMxN2B7QJCAuK7muhAxKdY1VOo1nm72tWEAUR2MVFLCEdliqCBGEZSyQd2/1XFHbBz94Fv3e9uupsRcyxwAOV+/gqf0HSmBlBLHhDoO3/e3lkLHLmG6VrQ==; 5:lYpzrQVSSyxa0V53E0PRwW7mV9tYM8XRPZ+yzy//WLmyIe0PMbvCGIKBta0L6W7fsPuvVjmRrFp5S8po338zbxzTmfKcyBQVSnbB9NunCQ5826cUzQmhQow07bnpTbqqPeOknpF5thv0FnnVzJ8L3g==; 24:MfKZ/dyDfwzNFxDNrQ+dptH3PGPrzPCjRLqGlvZm4gav4PdJtNtNjTNa+y78kEsaqDY+Y0fzeTPz2NszSm5ip8e5sEiePC9SxfgsGAXqW6s=; 7:pAP1wRRJOZctH6NcjfcRZYPuMRynPX+vhmY15CA64u8NaJLZUaGF3a1CxQFAPxfCEyoLvS2qzFCGuF7gNk1VbKOD++Z3ZWqOxedV0rqkZ81ENxwWH3rcRHr47RKziX7R9JkWmXE18fhzAMurdmpeZrZVr0m+qxWZIq6F0oALN6LIvygIkjHbQ5KR2dvP3fGFOyNeXjGJIVMOz0RRCjWP/0w1NKQ7XLFqqscgB+gXx5w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 11:12:03.4465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 11:12:10 -0000 -----Original Message----- > Date: Mon, 14 Aug 2017 14:18:15 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob , "Eads, Gage" > > CC: "dev@dpdk.org" , "thomas@monjalon.net" > , "Richardson, Bruce" , > "Van Haaren, Harry" , "hemant.agrawal@nxp.com" > , "nipun.gupta@nxp.com" , > "Vangati, Narender" , "Gujjar, Abhinandan S" > > Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.2.1 > > On 8/10/2017 10:23 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Wed, 9 Aug 2017 19:24:30 +0000 > > > From: "Eads, Gage" > > > Makes sense. Are you thinking the helper function would do stop + reconfig with additional port + start + setup port, or just setup the port with an ID the app supplies (only when a port is required, of course)? The second one could be done with little additional code -- the app just needs to check if an additional port is needed when configuring the eventdev, and another helper function could take a list of pairs and return true if any don't have an inbuilt port. > > > > I am in favor adding more logic in helper function(I believe, first one ) so that it will help > > application reuse the helper functions for the normal case. > > > > Hi Jerin, Hi Nikhil, > > My understanding of the discussion above is that the simple API adapter > creation API is > > int rte_event_eth_rx_adapter_create(id, eventdev_id) > > And the raw API is > > typedef int (*rx_adapter_conf_cb) (id, eventdev_id, > struct rte_event_eth_rx_adapter_conf *conf, void *arg); > > struct rte_event_eth_rx_adapter_conf { > uint8_t rx_event_port_id; > uint32_t max_nb_rx; > }; > > int rte_event_eth_rx_adapter_create_ext(id, eventdev_id, conf_cb, > conf_arg) > > The conf_cb is invoked if the rte_event_eth_rx_adapter_conf struct needs to > be filled out. the _create_ext() API is used internally by > rte_event_eth_rx_adapter_create() > > Does that look OK to you ? Just elaborating with additional detail. Let me know my understating is correct or not? default_cb(id, eventdev_id, conf) { conf->rx_event_port_id = rte_event_port() + 1; conf->max_nb_rx = ...; .... } rte_event_eth_rx_adapter_create(id, eventdev_id) { struct rte_event_eth_rx_adapter_conf default_conf_arg; rte_event_eth_rx_adapter_create_ext(id, eventdev_id, default_cb, &default_conf_arg); } Application is free to use rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_ext(). rte_event_eth_rx_adapter_create_ext() will be used by application when "default_cb" handler is not enough for the use cases. > > Nikhil >