From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id BE9751F5 for ; Wed, 16 Aug 2017 13:16:36 +0200 (CEST) Received: from [2606:a000:111b:4246:ce17:ba0d:7461:5cd1] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1dhwJH-0007Kt-6i; Wed, 16 Aug 2017 07:16:34 -0400 Date: Wed, 16 Aug 2017 07:16:19 -0400 From: Neil Horman To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170816111619.GA9348@hmswarspite.think-freely.org> References: <1502800360-15782-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502800360-15782-1-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 0/8] service: rework for usability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 11:16:37 -0000 On Tue, Aug 15, 2017 at 01:32:32PM +0100, Harry van Haaren wrote: > This patchset reworks the service apis to be more user > friendly. In particular, the various rte_service_* functions > now take an integer id parameter instead of a service pointer. > This both reduces the API surface (no service_get_from_id()), > and allows easier debugging (gdb function calls with integer args), > and various other benefits (better encapsulation, less pointers :) > > Finally, some APIs are changed or renamed for consistency and > clarity of what they do. See commit messages for details. > Note that the service library is merged as EXPERIMENTAL in > the 17.08 release, allowing API improvements for 17.11 release. > > I hope to merge this patchset early in the 17.11 timeframe, > so please review ASAP to allow time for other DPDK components > to utilize services in this release :) > > Feedback and input welcome, -Harry > You need to add a deprecation note in the rel notes area so that people are aware of the upcomming ABI changes Neil > --- > > There is one checkpatch warning: "macro with flow control", however > this same type of macro is used extensively in Ethdev and others, > I presume it is a false-positive. > > Harry van Haaren (8): > service: rework probe and get name to use ids > service: rework lcore to service map functions > service: rework register to return service id > service: rework service start stop to runstate > service: rework service stats functions > service: rework unregister api to use integers > service: rework get by name function to use id > service: clarify documentation for register > > drivers/event/sw/sw_evdev.c | 7 +- > drivers/event/sw/sw_evdev.h | 1 + > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 11 +- > lib/librte_eal/common/include/rte_service.h | 144 +++++++----------- > .../common/include/rte_service_component.h | 13 +- > lib/librte_eal/common/rte_service.c | 167 +++++++++------------ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 11 +- > test/test/test_service_cores.c | 123 +++++++-------- > 8 files changed, 215 insertions(+), 262 deletions(-) > > -- > 2.7.4 > >