From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 5A5869109 for ; Fri, 18 Aug 2017 02:32:37 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id t80so25480103pgb.5 for ; Thu, 17 Aug 2017 17:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wMCfsJi3h6jFKMp9NfvmzGXLfpLPyaHv2WFnz8GUI3I=; b=KHS2i5enr3dgtQ+lKLxr/ismwsrUlHu2cGnMb2i8DYLnzhivAAl6w2v7P4XY5S5OQ2 pP2l+jucnd+ew4KNPkS6rhdcdQjI9gzEjCYEtlw9i7yvLmFo0fmEwPlZzmRidsxH9A0i Ugz90zePI6AKDZZh4DKfM3LE4cNRJSXIBbTeqa19b7ZUBweb79oLtG8uzynuwQwj2q7C 3FYwTvsiRcMw2W+WRnvy9gCAyIMP2O7P+5Q2F8XN3ww0j1YxC0/Bu/T36zgdFjSaQ94S 31XEbBlDpmhZrwmmH39zYtxVzcK7V16a6/qlEmbu6KDNHpt7dtsuVz+0QjFTogpXNiH6 5UdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wMCfsJi3h6jFKMp9NfvmzGXLfpLPyaHv2WFnz8GUI3I=; b=jgDvv6BLsqwHW6bpP9gIMMYfXFfUxXy0SxrNdcYaZawqkuc8FcGD+FJBs133mjdP3X HE2lOwf4g7gRJCig4DoMe2VK2DoDGmSP4CG75foMi27qxxGBtShFxX3sKN5q08+fdfiU HGPZTBxlsDrILArz0qHwomsDcmNO5z3RyNLVqZiekfxWTmUCGuFFa46GnXObTMKOKFr7 pThDXDX/74LsnwgGHHtb/20ECdJL/DVqeutcblscgJOhTAT1yT98yQTGZz56Kfx99/Vt vG2fAtS3utTieZl175rtz1qBJLOQSwhk/C3khvBzgya0uCgewyhE1+vaw88+XmbbuUJb k0kg== X-Gm-Message-State: AHYfb5h40jUXN3YDcShr4rb55S1+X9oehzLGlBKgnfGi1lqkmOU8he5B 6MDLh2W3pSFGRDPe X-Received: by 10.99.2.203 with SMTP id 194mr6641921pgc.22.1503016356430; Thu, 17 Aug 2017 17:32:36 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id d1sm8966424pgc.57.2017.08.17.17.32.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Aug 2017 17:32:36 -0700 (PDT) Date: Thu, 17 Aug 2017 17:32:27 -0700 From: Stephen Hemminger To: Wenzhuo Lu Cc: dev@dpdk.org Message-ID: <20170817173227.29bae83d@xeon-e3> In-Reply-To: <1502994823-125017-2-git-send-email-wenzhuo.lu@intel.com> References: <1500929487-72896-1-git-send-email-wenzhuo.lu@intel.com> <1502994823-125017-1-git-send-email-wenzhuo.lu@intel.com> <1502994823-125017-2-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2017 00:32:37 -0000 On Fri, 18 Aug 2017 02:33:42 +0800 Wenzhuo Lu wrote: > Currently, rte_eth_dev_mac_addr_add is used by a > testpmd CLI to add a MAC address for VF. But the > parameter 'pool' of this API means the VMDq pool, > not VF. > So, it's wrong to use it to add the VF MAC address. > This patch provides a new API that can be used to > add VF MAC address on i40e. > > Signed-off-by: Wenzhuo Lu What do other drivers do? Sorry, a driver specific API is (almost) always the wrong solution.