From: Jens Freimann <jfreimann@redhat.com>
To: "Stojaczyk, DariuszX" <dariuszx.stojaczyk@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wodkowski, PawelX" <pawelx.wodkowski@intel.com>,
"Maxime Coquelin (mcoqueli)" <maxime.coquelin@redhat.com>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close
Date: Tue, 22 Aug 2017 13:58:44 +0200 [thread overview]
Message-ID: <20170822115844.owipopdjodt4vvxf@localhost.localdomain> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A8EF735D@HASMSX105.ger.corp.intel.com>
On Tue, Aug 22, 2017 at 09:55:19AM +0000, Stojaczyk, DariuszX wrote:
>Hi Jens,
>
>> I'm a little uncertain but my gut feeling is that in this context a connection is
>> something between two sockets, not between devices.
>
>What do you mean?
>This is a unix domain socket connection. DPDK can create the socket, then the client may connect to it via connect(2).
yes, I get that.
>
>> I would probably add
>> these callbacks to struct vhost_user_socket. This is also where we keep the
>> list of connections.
>
>I get your point. However, it's vhost_device_ops struct that's being set by the user via rte_vhost_driver_callback_register(). The new_connection callback is there just to mark the device as *in use, can't be deleted*. It doesn't transport any connection data.
You're right, I overlooked that it needs to be set by the user. In
this case your patch is the smallest possible change and looks good to
me.
Do we need a documentation change for this?
regards,
Jens
next prev parent reply other threads:[~2017-08-22 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:34 Dariusz Stojaczyk
2017-08-21 15:00 ` Jens Freimann
2017-08-22 9:55 ` Stojaczyk, DariuszX
2017-08-22 11:58 ` Jens Freimann [this message]
2017-08-22 12:10 ` Jens Freimann
2017-08-22 16:24 ` [dpdk-dev] [PATCH v2] " Dariusz Stojaczyk
2017-08-25 9:22 ` Jens Freimann
2017-08-29 6:08 ` Stojaczyk, DariuszX
2017-08-30 6:33 ` Jens Freimann
2017-08-30 10:50 ` [dpdk-dev] [PATCH v3] rte_vhost: " Dariusz Stojaczyk
2017-10-10 3:14 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822115844.owipopdjodt4vvxf@localhost.localdomain \
--to=jfreimann@redhat.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=pawelx.wodkowski@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).