From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9158C7CAF for ; Tue, 22 Aug 2017 13:58:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 623F537E68; Tue, 22 Aug 2017 11:58:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 623F537E68 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jfreimann@redhat.com Received: from localhost (ovpn-116-196.ams2.redhat.com [10.36.116.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8766878AAC; Tue, 22 Aug 2017 11:58:45 +0000 (UTC) Date: Tue, 22 Aug 2017 13:58:44 +0200 From: Jens Freimann To: "Stojaczyk, DariuszX" Cc: "dev@dpdk.org" , "Wodkowski, PawelX" , "Maxime Coquelin (mcoqueli)" , "yliu@fridaylinux.org" Message-ID: <20170822115844.owipopdjodt4vvxf@localhost.localdomain> References: <1503308082-17926-1-git-send-email-dariuszx.stojaczyk@intel.com> <20170821150034.sevaefe57m3pnlpd@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170714 (1.8.3) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 22 Aug 2017 11:58:51 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 11:58:52 -0000 On Tue, Aug 22, 2017 at 09:55:19AM +0000, Stojaczyk, DariuszX wrote: >Hi Jens, > >> I'm a little uncertain but my gut feeling is that in this context a connection is >> something between two sockets, not between devices. > >What do you mean? >This is a unix domain socket connection. DPDK can create the socket, then the client may connect to it via connect(2). yes, I get that. > >> I would probably add >> these callbacks to struct vhost_user_socket. This is also where we keep the >> list of connections. > >I get your point. However, it's vhost_device_ops struct that's being set by the user via rte_vhost_driver_callback_register(). The new_connection callback is there just to mark the device as *in use, can't be deleted*. It doesn't transport any connection data. You're right, I overlooked that it needs to be set by the user. In this case your patch is the smallest possible change and looks good to me. Do we need a documentation change for this? regards, Jens