From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 6B7A07D46 for ; Wed, 23 Aug 2017 11:44:23 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id r187so11548037wma.0 for ; Wed, 23 Aug 2017 02:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4nFnJhmNUT9q2CafwfQn6F885TDNyevGQVkeJac47/4=; b=PpwIjPalKj0RWzvKM8EKFj+9W4XbAMm6A0o9XFn42CKayfsJ+8FpEpczxlAHb9+6RP kORSPwybCIX3UkbiK6v0BDFt7/f1aG3u8Uq8hcr4cELsOEbMBVi1NATnGMGl+VxiH2BZ 1h1Hn/XWOokJF36QSvQUNqF4d8BjoFSW/urcxwOUAJWt1LzYyLCeX7fQReN+VxRqPX1d ThLRhyCtW2Sh21ASVQ/rKCcN7Ey7LRtjBpmxK/VJjQ/3NMsoqR1MFqgaRATcQL9dk8P2 h8RPa+e85l/M52DcyfC+M1qjUlmEcFzSElZXcRaCVHrful6+PcAcfP96fk4/OHnGyqd3 JO2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4nFnJhmNUT9q2CafwfQn6F885TDNyevGQVkeJac47/4=; b=VPllzjaY1jeni4v4EXogDtO1Fy+0A9fsj1zlPZleEw/TuUIoawQvLC+Z9213+ngWPE s7144TM3MlEk31Hf6hMLV/J0hRwI8G0PmI60dLKEFrcR5AvxZq2GzCls2f3QaqAO279e y2+1mJ/konnZaqeG1/kWtXmHws7BFJ8ePLUmA2kEKp4VlipvSN/UXHVfAO81ORDlnrJn cJlYn8aTKR5ENHJJTODcGECxvnfGAWeMWx/pBPvAaTc51nLompPgjXm7XiUxWXB3iqGd TUb8rX/zwhvvOoNexnXm9X1xvd40f69Cdg0kr435jXSfAsCp+2lxjCXdvLFbN29n0i1f Qrvw== X-Gm-Message-State: AHYfb5gZxd+fN0B0UWs9DIAuY7wMvxXgwrnG5YU/q6eyAPFuA4kmTfAA 6fg+ZQy3hNRt22PO X-Received: by 10.28.13.140 with SMTP id 134mr193904wmn.176.1503481463115; Wed, 23 Aug 2017 02:44:23 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i80sm1817050wmh.40.2017.08.23.02.44.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Aug 2017 02:44:22 -0700 (PDT) Date: Wed, 23 Aug 2017 11:44:13 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Matan Azrad Cc: Adrien Mazarguil , dev@dpdk.org, stable@dpdk.org Message-ID: <20170823094413.GT12995@autoinstall.dev.6wind.com> References: <1502627112-53405-1-git-send-email-matan@mellanox.com> <1502627112-53405-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1502627112-53405-2-git-send-email-matan@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe failure report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 09:44:23 -0000 On Sun, Aug 13, 2017 at 03:25:12PM +0300, Matan Azrad wrote: > The corrupted code doesn't return error when probe function > fails due to error in device mac address getting. > By this way, the probe function may return success even if the > ETH dev is not allocated. > > Hence, the probe caller, for example failsafe PMD, fails when it > tries to get ETH dev after the device was plugged out while mlx5 > was probing it. > > The fix adds error report to the probe caller when priv_get_mac fails > and in all other failure options which are missing it. > > By this way, it prevents the unexpected behavior to miss ETH device > after the device was probed successfully. > > This bug was already present in the original code taken from mlx4. > > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") > Fixes: 1371f4df16bc ("mlx5: check port is configured as ethernet device") > > Signed-off-by: Matan Azrad > Cc: stable@dpdk.org Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND