From: Stephen Hemminger <stephen@networkplumber.org>
To: David Harton <dharton@cisco.com>
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com,
johndale@cisco.com, wenzhuo.lu@intel.com,
konstantin.ananyev@intel.com, jingjing.wu@intel.com,
beilei.xing@intel.com, jing.d.chen@intel.com,
adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
alejandro.lucero@netronome.com, hemant.agrawal@nxp.com,
rasesh.mody@cavium.com, harish.patil@cavium.com,
skhare@vmware.com, yliu@fridaylinux.org,
maxime.coquelin@redhat.com, allain.legacy@windriver.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int
Date: Thu, 24 Aug 2017 16:37:08 -0700 [thread overview]
Message-ID: <20170824163708.2931e83b@xeon-e3> (raw)
In-Reply-To: <20170824231851.21829-1-dharton@cisco.com>
On Thu, 24 Aug 2017 19:18:51 -0400
David Harton <dharton@cisco.com> wrote:
> @@ -2031,7 +2031,7 @@ struct avp_queue {
> mask = (ETH_VLAN_STRIP_MASK |
> ETH_VLAN_FILTER_MASK |
> ETH_VLAN_EXTEND_MASK);
> - avp_vlan_offload_set(eth_dev, mask);
> + (void)avp_vlan_offload_set(eth_dev, mask);
This is a BSDism. You don't need the void cast.
next prev parent reply other threads:[~2017-08-24 23:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 23:18 David Harton
2017-08-24 23:37 ` Stephen Hemminger [this message]
2017-08-25 0:55 ` David Harton (dharton)
2017-08-25 8:20 ` Bruce Richardson
2017-08-25 13:33 ` [dpdk-dev] [PATCH v2] " David Harton
2017-08-25 13:47 ` [dpdk-dev] [PATCH v3] " David Harton
2017-08-31 22:04 ` Thomas Monjalon
2017-08-31 22:08 ` Thomas Monjalon
2017-09-01 0:40 ` David Harton (dharton)
2017-09-01 8:01 ` Thomas Monjalon
2017-09-01 2:36 ` [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration David Harton
2017-09-01 7:41 ` Hemant Agrawal
2017-09-01 12:54 ` David Harton (dharton)
2017-09-07 9:37 ` Hemant Agrawal
2017-09-07 12:09 ` David Harton (dharton)
2017-10-10 5:34 ` Ferruh Yigit
2017-10-10 12:20 ` David Harton (dharton)
2017-10-25 3:01 ` [dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN offload ops Ferruh Yigit
2017-10-25 22:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824163708.2931e83b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alejandro.lucero@netronome.com \
--cc=allain.legacy@windriver.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=skhare@vmware.com \
--cc=stephen.hurd@broadcom.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).