DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Harton <dharton@cisco.com>
Cc: konstantin.ananyev@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets
Date: Tue, 29 Aug 2017 11:42:54 -0700	[thread overview]
Message-ID: <20170829114254.7b563118@xeon-e3> (raw)
In-Reply-To: <20170829155056.12563-1-dharton@cisco.com>

On Tue, 29 Aug 2017 11:50:56 -0400
David Harton <dharton@cisco.com> wrote:

> +	if (n < (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS))
> +		return (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS);

Please don't use BSD style.
Return does not need parenthesis.

  reply	other threads:[~2017-08-29 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 15:50 David Harton
2017-08-29 18:42 ` Stephen Hemminger [this message]
2017-08-29 19:20   ` David Harton (dharton)
2017-08-29 18:44 ` Stephen Hemminger
2017-08-29 19:29 ` Ananyev, Konstantin
2017-08-29 19:50   ` David Harton (dharton)
2017-08-30 14:27     ` Ananyev, Konstantin
2017-08-30 15:32       ` David Harton (dharton)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829114254.7b563118@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=dharton@cisco.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).