From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 6285F1B53 for ; Tue, 29 Aug 2017 14:50:56 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id n37so9809674wrf.4 for ; Tue, 29 Aug 2017 05:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TYJlLaIarobTuumkqzcOK646hW3IAdl/PLc/8Oqjqg4=; b=w2zn6uUsTK54PZOYu1FevinmKD0VfebaTOWV0Ka5pBp5prG7JV6h9pr7aY3J7hycyR widYarV+u/SveJW3zjR6KLoGBFBCxa5Ja9knjln1FoOGRE5kbuCeMvzjWv/GxarNd+cB Pp/q9kGOZMURYNbj5Oj03sFa+SfU5Gb6ba8zLIe0YxCE75GiAtX4OkOreYPzlleNMVjF HESDZamZUHn2MrnjYD+sXHm7ZbAauVJ4xqh0+ia5WctwJEW5KwGdnwfWpRdPnugq7Uqc 7z7RXAar8u+RVNOk4yeML9TxSYZaVWfXip0Jm+uLlW9Y3ZsxETev3rxTXOSl2AzIsfPT a+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TYJlLaIarobTuumkqzcOK646hW3IAdl/PLc/8Oqjqg4=; b=BD8Zgm56Lte9T0pVskqHG1f8qlN9ROaLKl2TROpJHY1nhYxlnZ0Fpf1OaBOTkhlGdY uyKmyhqN5iXOZ6M9Snzs+wicj0O3o79jzzPYf0fKAJ05mnfsyh/TWb/qobmD4a24/xpE sa/QoE/EzHnveU79hqu4FIbVdAyYegfvKLVnRluO0R7cZtGo+xy0FRhAiuXkx1YVQ0BB q43obe2clwGJoQaVhNSuL54YVG7maPC2JCNx4ukidsFl/J6KkNr/y7u5KdTGDVaMLCHn Fi8WeyHmSvJ2SMo2EcqqtGLkSkpQVBEzYiPDWzj3PkJc2KIdd7v/sBtj5hUOQs+/hezu eDBA== X-Gm-Message-State: AHYfb5iGSBJwsRytsN0TXRich+Rg1Sm84U17fk3uwUDCo3Ej7An1YVkF 52ztXqwmHN1YvHn7 X-Received: by 10.223.157.69 with SMTP id o5mr131626wre.271.1504011055756; Tue, 29 Aug 2017 05:50:55 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u30sm2534254wru.88.2017.08.29.05.50.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 05:50:54 -0700 (PDT) Date: Tue, 29 Aug 2017 14:50:45 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jianfeng Tan Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Message-ID: <20170829125045.GM8124@bidouze.vm.6wind.com> References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-3-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503654052-84730-3-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 02/12] eal: avoid calling rte_vdev_init() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 12:50:56 -0000 Hi, On Fri, Aug 25, 2017 at 09:40:42AM +0000, Jianfeng Tan wrote: > We can call bus->plug() to avoid calling rte_vdev_init() explicitly. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_eal/common/eal_common_dev.c | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c > index e251275..066dfbf 100644 > --- a/lib/librte_eal/common/eal_common_dev.c > +++ b/lib/librte_eal/common/eal_common_dev.c > @@ -67,7 +67,6 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name) > int rte_eal_dev_attach(const char *name, const char *devargs) > { > struct rte_bus *bus; > - int ret; > > if (name == NULL || devargs == NULL) { > RTE_LOG(ERR, EAL, "Invalid device or arguments provided\n"); > @@ -80,22 +79,12 @@ int rte_eal_dev_attach(const char *name, const char *devargs) > name); > return -EINVAL; > } > - if (strcmp(bus->name, "pci") == 0) > - return rte_eal_hotplug_add("pci", name, devargs); > - if (strcmp(bus->name, "vdev") != 0) { > - RTE_LOG(ERR, EAL, "Device attach is only supported for PCI and vdev devices.\n"); > - return -ENOTSUP; > - } > + if (strcmp(bus->name, "pci") == 0 || strcmp(bus->name, "vdev") != 0) It seems to be a copy / paste error, it should probably be: + if (strcmp(bus->name, "pci") == 0 || strcmp(bus->name, "vdev") == 0) Now, one could question the relevancy of keeping this API (rte_eal_dev_attach / detach), but I guess this is beyond the scope of this series. > + return rte_eal_hotplug_add(bus->name, name, devargs); > > - /* > - * If we haven't found a bus device the user meant to "hotplug" a > - * virtual device instead. > - */ > - ret = rte_vdev_init(name, devargs); > - if (ret) > - RTE_LOG(ERR, EAL, "Driver cannot attach the device (%s)\n", > - name); > - return ret; > + RTE_LOG(ERR, EAL, "Device attach is only supported for PCI and vdev devices.\n"); > + > + return -ENOTSUP; > } > > int rte_eal_dev_detach(struct rte_device *dev) > -- > 2.7.4 > -- Gaëtan Rivet 6WIND