From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id EF1E211D4 for ; Tue, 29 Aug 2017 14:54:33 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id y71so20239601wmd.0 for ; Tue, 29 Aug 2017 05:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XdRcPXzTImzMPL+euRi4aA4STO9OYLwOvqp5Z5k4MQY=; b=lUOgrIQcoDZKW8j7ZF64mzs+DW1sBY8maMhUZhulXIWOHeenBc01ZUkg7HAyRf1a7K rGnh2H16/AJE133LDDrc4rwIw5HtP5xy7GnQVOMFw+8OFYnEXbngEcFwVPYjOmgxITV6 UVirW/lLhxb4Xu/yLD4XZBsg/KJtCq4N6ZAi9aqFK4Xv3YxQSoU9eUDDRI5vgksd5FFY DpKv32XN/7CtXgnZHadKUck0iWUW/bMDwlVQEmYGf/AcnzjwkTiB8GdKdPNtp7Z/7uYx GW1ArjbnuFMq7Dnn5tNpj2/kS1d/N5WN083Ujhc4SuDvnrCf0v4OFmbT780mf/siqSy2 ZGzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XdRcPXzTImzMPL+euRi4aA4STO9OYLwOvqp5Z5k4MQY=; b=PmPmK5mnn7KrVcgx4IYQSJOB84OPrlh80UFBhqjCgDrYAE+a65uH300iHSKvSJlEbn ARhWA6mh4UsUXyGXUyPEJPtLaHdYF5CopANizBrsuuSxVyCI2mL0QxEI2+bePe9BXPAU 0GW+oEhuLS44DkrjRGOv2wl06BIdW5izjeLBTn6Isqcf0/XT4kQSYWOrbvIkfyc04khi +5EsOcF6KNCd817UB8585ql8I5atUQyktY9MDy2xwMastmqkOMl7s8/8Q0DVaEwYwfsR 0wnrZwx1KNBwxLljPB1sQjrMX7VOsdgYJJEv9AqyMbVsiK5AFrCK5y/N/IkS1hEj0E74 mhKg== X-Gm-Message-State: AHYfb5iuliHwVR7jPTkNPyA3YkbaHIjcbXLyTGIP45IWa5WHAtbm1Lud dI0uunwfUb/q3j2s X-Received: by 10.28.4.85 with SMTP id 82mr2757510wme.159.1504011273481; Tue, 29 Aug 2017 05:54:33 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j79sm2049984wmd.20.2017.08.29.05.54.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 05:54:32 -0700 (PDT) Date: Tue, 29 Aug 2017 14:54:23 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jianfeng Tan Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Message-ID: <20170829125423.GN8124@bidouze.vm.6wind.com> References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-6-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503654052-84730-6-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 12:54:34 -0000 On Fri, Aug 25, 2017 at 09:40:45AM +0000, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan > --- > drivers/bus/vdev/vdev.c | 10 ++++++---- > drivers/bus/vdev/vdev_logs.h | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 46 insertions(+), 4 deletions(-) > create mode 100644 drivers/bus/vdev/vdev_logs.h > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index f7e547a..cde2a3c 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -47,6 +47,8 @@ > #include > #include > > +#include "vdev_logs.h" > + > /* Forward declare to access virtual bus name */ > static struct rte_bus rte_vdev_bus; > > @@ -102,7 +104,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev) > > name = rte_vdev_device_name(dev); > > - RTE_LOG(DEBUG, EAL, "Search driver %s to probe device %s\n", name, > + VDEV_LOG(DEBUG, "Search driver %s to probe device %s\n", name, > rte_vdev_device_name(dev)); > > if (vdev_parse(name, &driver)) > @@ -188,7 +190,7 @@ rte_vdev_init(const char *name, const char *args) > ret = vdev_probe_all_drivers(dev); > if (ret) { > if (ret > 0) > - RTE_LOG(ERR, EAL, "no driver found for %s\n", name); > + VDEV_LOG(ERR, "no driver found for %s\n", name); > goto fail; > } > > @@ -211,7 +213,7 @@ vdev_remove_driver(struct rte_vdev_device *dev) > const struct rte_vdev_driver *driver; > > if (!dev->device.driver) { > - RTE_LOG(DEBUG, EAL, "no driver attach to device %s\n", name); > + VDEV_LOG(DEBUG, "no driver attach to device %s\n", name); > return 1; > } > > @@ -292,7 +294,7 @@ vdev_probe(void) > continue; > > if (vdev_probe_all_drivers(dev)) { > - RTE_LOG(ERR, EAL, "failed to initialize %s device\n", > + VDEV_LOG(ERR, "failed to initialize %s device\n", > rte_vdev_device_name(dev)); > return -1; > } > diff --git a/drivers/bus/vdev/vdev_logs.h b/drivers/bus/vdev/vdev_logs.h > new file mode 100644 > index 0000000..7a2d811 > --- /dev/null > +++ b/drivers/bus/vdev/vdev_logs.h > @@ -0,0 +1,40 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _VDEV_LOGS_H_ > +#define _VDEV_LOGS_H_ > + > +#define VDEV_LOG(level, fmt, args...) \ > + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args) With the multiplication of bus implementations, wouldn't it be interesting to introduce an RTE_LOGTYPE_BUS? > + > +#endif /* _VDEV_LOGS_H_ */ > -- > 2.7.4 > -- Gaëtan Rivet 6WIND