From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id BB82E2BF3 for ; Wed, 30 Aug 2017 14:39:23 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id r202so1321540wmd.0 for ; Wed, 30 Aug 2017 05:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OHRG+3auAm5QJm+n5X3Gf7HzLKBKd4r+4uhcEKdEvyo=; b=wcBpoPC3Cu5sIG35kie5Z6a0cRs60VgvbuYS3TrDh/NdjMfWuPgJ1fKs31OE1Qp9bJ CHEtWURvF0HPEWgEI3/UNDy2kyX07ezPWgjaQKmJdaZoQgECgrLQBuXMQ7eC2BxD9t0x XCEmqqOoRyIMHxqFaZ7i/8qmamGF3zswLWmH+/1O8OHc68lqgLQrkxNhpkRu9nYh+T3B jKviuomC3oPYM7Ioz6lQPMDmzgrMQ08k7d18HNQENItG0HeED/BjAbK953XPh2lTOYtA rfY/EyaA9m9qMYxK4IBTD27L5wyj8jQVfDAMaMFjS6wex7tl3a0keK0ulGHVWkVdbnNo h6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OHRG+3auAm5QJm+n5X3Gf7HzLKBKd4r+4uhcEKdEvyo=; b=hNceWgAZljc9FTsq9KzA36HT3Zn4JzqGoR6SCOrlcXBN/gNPk2BshjAHEY02o6c6/a f6++lNFY5eqDklb4gpxjQU/E/9UoBQGzhqsiP7pe7z1yJpxIgCXfq5ZRsomyWBZbaAOV nxK+R50BwXTcRfzIueUcO/i5X6n6tMNPu9QLiunru8kICKHBbl8tVHbXsZHbjV0dRrZ4 h74LNnCJCx77QFZMjCQyOEYlfbe/Z917staz0PJItgGqBJyksYzCo9VxKEUkwRpPkFMG v1/p1cVVEFTgxHV4ffN1keukLPASV4PVVUnZMIRNOajC90dFVb/KQaeZUdTasQ8LvOVF sqgA== X-Gm-Message-State: AHYfb5iBmHS+RFnF0cHiNp5T8RMrkHCnuwQ7xUfDZ3glBhfZ9C1jlK93 SrDPVSWSCoFyWSWm X-Received: by 10.28.191.134 with SMTP id o6mr1144749wmi.168.1504096763511; Wed, 30 Aug 2017 05:39:23 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f142sm415994wmf.27.2017.08.30.05.39.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 05:39:22 -0700 (PDT) Date: Wed, 30 Aug 2017 14:39:12 +0200 From: Adrien Mazarguil To: Bernard Iremonger Cc: dev@dpdk.org, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com Message-ID: <20170830123912.GJ4301@6wind.com> References: <1503496275-27492-1-git-send-email-bernard.iremonger@intel.com> <1503677438-27591-4-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503677438-27591-4-git-send-email-bernard.iremonger@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 12:39:23 -0000 Hi Bernard, On Fri, Aug 25, 2017 at 05:10:35PM +0100, Bernard Iremonger wrote: > Initialise the next_proto_id mask in the default mask for > rte_flow_item_type_ipv4. > > Signed-off-by: Bernard Iremonger > --- > lib/librte_ether/rte_flow.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h > index bba6169..59c42fa 100644 > --- a/lib/librte_ether/rte_flow.h > +++ b/lib/librte_ether/rte_flow.h > @@ -489,6 +489,7 @@ struct rte_flow_item_ipv4 { > #ifndef __cplusplus > static const struct rte_flow_item_ipv4 rte_flow_item_ipv4_mask = { > .hdr = { > + .next_proto_id = 0xff, Please don't change the default mask to cover this field as it means all rte_flow-based applications that do not provide a specific mask (.mask == NULL) have to always set this field to some valid value. This is not a convenient default behavior. > .src_addr = RTE_BE32(0xffffffff), > .dst_addr = RTE_BE32(0xffffffff), > }, > -- > 1.9.1 > I'll have to NACK this change. The example application should define its own mask if next_proto_id must be always set. -- Adrien Mazarguil 6WIND