From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F324F2BF3 for ; Thu, 31 Aug 2017 16:32:37 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 31 Aug 2017 07:32:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,453,1498546800"; d="scan'208";a="1213013976" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by fmsmga002.fm.intel.com with SMTP; 31 Aug 2017 07:32:33 -0700 Received: by (sSMTP sendmail emulation); Thu, 31 Aug 2017 15:32:32 +0100 Date: Thu, 31 Aug 2017 15:32:32 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: konstantin.ananyev@intel.com, thomas@monjalon.net, john.griffin@intel.com, fiona.trahe@intel.com, dev@dpdk.org Message-ID: <20170831143232.GA7984@bricha3-MOBL3.ger.corp.intel.com> References: <20170831134244.35215-1-bruce.richardson@intel.com> <20170831134244.35215-4-bruce.richardson@intel.com> <298d123d-2d55-c702-cc14-6dab9eff9ebd@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <298d123d-2d55-c702-cc14-6dab9eff9ebd@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 3/4] ether: rename version file to match library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 14:32:38 -0000 On Thu, Aug 31, 2017 at 03:18:47PM +0100, Ferruh Yigit wrote: > On 8/31/2017 2:42 PM, Bruce Richardson wrote: > > While almost all libraries have the library name match the directory name, > > some libraries and drivers do not. For those that don't, some have the > > version filename use the libname, e.g. null_crypto, others have it use the > > directory name, e.g. ether. Using the library name seems the better > > standard to follow, so rename rte_ether_version.map to > > rte_ethdev_version.map. > > > > Signed-off-by: Bruce Richardson > > --- > > lib/librte_ether/Makefile | 2 +- > > lib/librte_ether/{rte_ether_version.map => rte_ethdev_version.map} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename lib/librte_ether/{rte_ether_version.map => rte_ethdev_version.map} (100%) > > > > diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile > > index db692ae4d..27d9766a8 100644 > > --- a/lib/librte_ether/Makefile > > +++ b/lib/librte_ether/Makefile > > @@ -39,7 +39,7 @@ LIB = librte_ethdev.a > > CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > > > > -EXPORT_MAP := rte_ether_version.map > > +EXPORT_MAP := rte_ethdev_version.map > > Why library name and folder name is different for ethdev, will it break > anything if folder also renamed to librte_ethdev? for consistency. > Probably not, but it would be a much more visible change than just changing the map filename, so I left it as-is for now. For the drivers, there a quite a number of instances where the driver name is not going to match the directory name, e.g to include "crypto" or "event" for clarity in the resulting library name. Because of that, I'm adding support for allowing drivers to specify their name independently of the directory name, and for consistency, I'm going to allow doing so for libs too, since I want both drivers and libs to take more-or-less the same set of parameters in their build files. That said, no objection to a more comprehensive patch to rename the folder. :-) /Bruce