From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46]) by dpdk.org (Postfix) with ESMTP id CED5F330D for ; Fri, 1 Sep 2017 14:22:35 +0200 (CEST) Received: by mail-pg0-f46.google.com with SMTP id b8so103456pgn.5 for ; Fri, 01 Sep 2017 05:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k6IVdYAeVk1YmMM8d14r2aRZJA7oWM+hwlbHzD74vYo=; b=P75idlhOWkKPXhuxYXuxDkjLpvSshyc5D70BlblwiNK/MnYGODmZ3+wjjxVD8qIpg5 y/XfPEAxfBawl9rSRJrOSk5/RvKxMlZIYSyRuOH1sNIcNEHNOteg0l1ra7A776pNWi2c vhEEFr8ozU9ovEAKCLv7R3smZ017/Hf+wgEYKXVBrD2coytf6yXIXqIBfd1wJWN5hboV vnYE2aIBstWm4SCATzJbVeAMnMrlaQs8UVWlTiZwJks+rBEPgm6kC8pnbnq33PEruuSc R4D8+AMv5sU/xVj9xDko/SuX7SX1t3pQ4VX54W0NelA1InJw5uPLbGrZ3Isw39OeE+37 dDGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k6IVdYAeVk1YmMM8d14r2aRZJA7oWM+hwlbHzD74vYo=; b=SpwDtu6WbzJjhttqb2ZtLeo8PFszeaCMFTqy9J9kYYXUDmPC6DvLgcnmq5pMgETmAB gr6IUq0sUbwaNRVSjNyH7aNBo5qchFJLfFgems1AkfINookqAVtEs53GDPQb+yT57e0u CololW/D4JxjukIB/vG9388sGQ3zgYCl7DqUPcsJXQy03EdVBkyE9Vp0hcSqeZgRXSBY xbPPyUxVtq14iKI2YK6LY8E8u2gL5S8bGfF+G5AOUrgDBoR+LuhhwhRKihUlztJgk2gk D5OEKpYCxSgoRCYZytytRsaxk8i8TvksvJQYnlO896c06OUVaGARCmT2J97uc0ZQmPN/ MjnA== X-Gm-Message-State: AHPjjUiw0ghM9yhPqlJM+fAl2xYd2xUUMcuhKMcn0/IgZMt6DKilZb60 ZKIRz5rzaDtTh19YWeKFpQ== X-Google-Smtp-Source: ADKCNb4132ltm/WuBhW1uVpE59LurIQiJx02YlPN5UynKvcYW3KcFaa7LeyiFXPPgQVax7GjGP7bxg== X-Received: by 10.99.110.3 with SMTP id j3mr2194339pgc.117.1504268554738; Fri, 01 Sep 2017 05:22:34 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id t3sm71124pgf.28.2017.09.01.05.22.31 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 05:22:33 -0700 (PDT) Date: Fri, 1 Sep 2017 20:22:26 +0800 From: Yuanhan Liu To: Olivier MATZ Cc: dev@dpdk.org, maxime.coquelin@redhat.com, stephen@networkplumber.org, stable@dpdk.org Message-ID: <20170901122226.GV9736@yliu-home> References: <20170831134015.1383-1-olivier.matz@6wind.com> <20170831134015.1383-9-olivier.matz@6wind.com> <20170901092538.GU9736@yliu-home> <20170901095806.yo34c4euaqf4avoi@neon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901095806.yo34c4euaqf4avoi@neon> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 8/9] net/virtio: keep Rx handler whatever the Tx queue config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 12:22:36 -0000 On Fri, Sep 01, 2017 at 11:58:07AM +0200, Olivier MATZ wrote: > On Fri, Sep 01, 2017 at 05:25:38PM +0800, Yuanhan Liu wrote: > > On Thu, Aug 31, 2017 at 03:40:14PM +0200, Olivier Matz wrote: > > > Split use_simple_rxtx into use_simple_rx and use_simple_tx, > > > and ensure that only use_simple_tx is updated when txq flags > > > forces to use the standard Tx handler. > > > > I think it's a good idea to split it. > > > > > This change is also useful for next commit (disable simple Rx > > > path when Rx checksum is requested). > > > > > > Cc: stable@dpdk.org > > > > But again, I don't think it's a good idea to put them (including the > > next patch) to stable releases. > > Yes, you're right this one is more an enhancement than a fix: it > just selects a faster handler if it's possible. Exactly. > But next one is a fix: it must not select the simple handler if > offload is requested. > > If these commits are not pushed in stable, it's not a problem for > me, so I let you decide. In that case, I will remove the Cc: stable > from the last 3 commits. Do you confirm? Yes, I think it's better to drop the cc stable tag. > Thanks for the review. Thanks for the work! --yliu