From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id 3D2E458F6 for ; Sun, 3 Sep 2017 18:16:11 +0200 (CEST) Received: by mail-pg0-f44.google.com with SMTP id b8so12654814pgn.5 for ; Sun, 03 Sep 2017 09:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5HbiBO5sOSkfGCg+BKjKvWz8IKSd5N6/1MBKcixqdyw=; b=Mo4Bvocdu1GX8ep63liIRksjo1v9HLHVvNCpXH1blqF/jlnmkf6wbSJ8iE1e2Co7vp mkXklaCevzBKo2gAo1JGvgv2UJbro/jmQz9G76yrHGS3vRwkvGYxj3+LPDlYLmhmyVn5 DgCme1FHNIj16QzgqKR6VMQ3Izpg8RBi2KngIlmeU3jwgCuGhPXZpUtisS6A+rSC/min CCVBUG8a9M9+ZFkv5Vuv1FTjewmrk6K5NDV6bzm9UkGnK25b3hyVQg0sDP1iFRZ5f09b LkQLO/nIIagCAWgXYSi8EbhGjBT/oJqoCv76vzIUB696U713afM9gfr1vGxYwgbUeP00 mjlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5HbiBO5sOSkfGCg+BKjKvWz8IKSd5N6/1MBKcixqdyw=; b=CW6832fdWJnDZZGOat/XeVEX/pP2DU/AT7E/lSXQYqL9sO3TzZApKVv9rOvgAMCemW /oAsG30Yd5SrMQak3rRnSgfe2QxvnejpwljzatYWhtJQVNFuwYRCsU9hx7UyeMtLVo2q ewUQybLVW4KwsB1Y/7+N7Hb99o1BwudipX4c18hxSsQYXuuwA2vHyX3D8hZtbKOThQ/Z CVtg+yEMzdhlTCw/7QVX4wIa1zR5fZfQ9CbdQ9c7kMyGiGqUQp1MeLJOFxFcaRdsMlV2 dWQgOgt5lP8s4vD6z6EIpW3GkRwug5Cs10rgdNFUMtOrVAgWBkHyWrDQd6ZnXAZMtlwP 88iw== X-Gm-Message-State: AHPjjUgLHC5iIpv9Vm6iVmsFx+FPXl09b3MGbBcNgL9g5dYutOP1pIEe KGYVDuBu+VAh4FO5 X-Google-Smtp-Source: ADKCNb6Np55D4QA9Fap4VIpX/UriFEBOWATk22pNsgCMmhOrsvdM//uS2CA2oCCkU/vhLu4FF3Qrmg== X-Received: by 10.98.68.213 with SMTP id m82mr8914400pfi.171.1504455370401; Sun, 03 Sep 2017 09:16:10 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id x70sm8161957pfe.70.2017.09.03.09.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Sep 2017 09:16:10 -0700 (PDT) Date: Sun, 3 Sep 2017 09:16:08 -0700 From: Stephen Hemminger To: Jeff Guo Cc: bruce.richardson@intel.com, dev@dpdk.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, jblunck@infradead.org, helin.zhang@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net, jingjing.wu@intel.com Message-ID: <20170903091608.7e131380@xeon-e3> In-Reply-To: <1504453785-15735-2-git-send-email-jia.guo@intel.com> References: <1498712510-44217-2-git-send-email-jia.guo@intel.com> <1504453785-15735-1-git-send-email-jia.guo@intel.com> <1504453785-15735-2-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Sep 2017 16:16:11 -0000 On Sun, 3 Sep 2017 23:49:44 +0800 Jeff Guo wrote: > + /** > + * add device uevent file descriptor > + * into wait list for uevent monitoring. > + */ > + ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP; > + ev.data.fd = src->intr_handle.uevent_fd; > + if (epoll_ctl(pfd, EPOLL_CTL_ADD, > + src->intr_handle.uevent_fd, &ev) < 0){ > + rte_panic("Error adding uevent_fd %d epoll_ctl" > + ", %s\n", > + src->intr_handle.uevent_fd, > + strerror(errno)); Panicing a user application under load is not going to make people happy