From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0088.outbound.protection.outlook.com [104.47.41.88]) by dpdk.org (Postfix) with ESMTP id 92F7B37AC for ; Mon, 4 Sep 2017 08:12:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Il9m3r+AqNhKIfY7USPhgYLj9HcZYNg9xpBEbVBGzi0=; b=PBkj0j/DAXo52++RLm7nLENjT/Z8wkXxjTIP/Qw1fIad6EZ4iMCyBXpqi+2WAwYEcKuWvFZ2AQtHPQQeLUdfQiz0fInLSbgIBk65SxYPjWmc3pyWxRNa+97Vlnr5Ln+NYQBwQmjwtHZQp8YMpMDrE6ZymbZazLkqseegXIhTEoU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 4 Sep 2017 06:12:54 +0000 Date: Mon, 4 Sep 2017 11:42:32 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170904061231.GB17139@jerin> References: <20170830113007.28620-1-jerin.jacob@caviumnetworks.com> <469dafbe-eefc-bb0b-1c5b-e300431f6a41@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <469dafbe-eefc-bb0b-1c5b-e300431f6a41@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (10.174.208.19) To CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3fcd9a3-1028-4900-4eee-08d4f35bfbd2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:Rd9dgmFlHTrABAbWJILbixMMUURU7Mp9M2EEZ6zcQO52Y15sGAgI07rXp8QVpGuJt2tFJR5UdklH98u+ojp95bO+kWwsNfWn+3DxbxsJUdd9XzvkVJMGELvCUE/bIkp4iB5/lrF/RAy8tdYe9dhXtZZyctjHuHLBCtcZThUneuV6CbSKKJsbAN4rgZ76NN0iSV+RZFN6QzotUyxkYutGuzFSkO75P3WMsm+4shYDKTj7c2ZOsY27GXj51mu/6CRT; 25:Ej8KTP4vDX4aSes3f1wj/ip7BQqapf4b3HjzUrPxoCUzf3NDiZ3SOjqJh6QgTCesKHTj4HDH0Q3pc7I99JACSXFcdi1OSf9j2DrV+ISQQbseW9sYc6fmm+oQCs/9sQRVxx7/mzQscjK+q95qHBU1afjrhrl2u+y2z/Sh5AsIJ9DOsSkuf7f7Z1w3ANA1PhOsjO+slVpGXmxG9d1poaKwYS0ddJtV4efQv1ji20TIRGWFZvnN6nS821xGuYufOsNlMHS/jZ2ymPkVyt68iqtxy1VLvZnotf5r2jr9+gFSnrwcrSDKH2VMTq167DqgkkA7IRoC+GYUUJ7stT99lRkh+w==; 31:nUuM96hjxSW/QsWQaatJRDCc8OmqNCutNjjVz2k+hcEoY/iTYn2oLgIksFzH+Fc+7VDjS8o/qaqtts2EoBDSM1ryLuxRyHYMZCv2qhFrvCHsHfDUGKCTkBB0vjF6eMA6adenZRdUUUjnUcv35VQNaOEt3WBJT2yhHgEY84XC1yMmh4ACXrK/dAEx4Lo9UQnv4JIOHzJb1YNK6LlnxcAzqvpAK8p1eoYO8ftYAQTHmWM= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:iN7M3ZFVfilLcCQn4WFfyvX3M+3H4RU+6JyCx8q9U8Zqj5WA/2WL0F3Kk4jl+kGg8LlrgxauwcftAxNDv2uz+ZmAK5JhkbUz+fsDwMd5SiaG/rW0pOliLCB5mq2lsfRokqHVHeAzgoUaNDuTVOy5rt1l0y/nYrJKKxpCI3+8p61dcVs3LTM9YGNqraBFSmt8YCY8I/74v+7QIQCmkrbr8pVmJDVJpqRGgdxrzjb5fj6HWzhfFZNPNDsiaSWFotZQEZ1YfCzab8X0DUdZOc2LPTmA4NrXEEdjyfJW+Pq2agGgTEIxW8A+Md6QyzIaFwS+uJSJArVUZwTBawB100t/8B6JNj9ZSBAgQMngKqb4+dH7UsOA8Ep0lUWRmM8MWiZpScU6VAtNX3D+WNYaaSrM8iMisgj1y43kZhd1lIhC5IS2yQSwsfDZ8ZVsjYK6fEia1k9Rg/iycwUUnLW0nBOgM6I0yR0/BbpK2n3sn410KX71xsp22wvKz4Y7RsJA5IWfBss5lVxktXT5gMq/HPcm0/lA6Ro3lQ0SIDdZW3fgZq6Dz/I1GFD5kOGlPwb3GMvkQxnC/ciBw3oF9kk+/lMZPOwA8NjLpDKRk8sB/nj1G6s=; 4:8FbTzPdj6J/PdUM7lVirKq07Ew37YaaJvRGtKGVRv9mth4/nOU1r/6oN5ioNDS7BtmmtQIiPCcdsniiPiPSbkd25xNuFHfzy4BBKpTQGtkNX0xeTEhkY94FWvWdMmchAkta5JF+f1aHQQwSAUYpBsA51BvxvFDwjkH1zCYUkHMpEL2Y7bc/DONOVajvpYXhRzHywjMzApQRLGU8hYjJYXROgtyHS7Ee5HHZfTtkEzkzebX54gYkzG8peQjYvo+xPc3BDtC//sx96bb4aCZ7qfPNEbED2Rouaboggrgn42gA= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(6041248)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2520; X-Forefront-PRVS: 0420213CCD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(199003)(13464003)(24454002)(189002)(377454003)(33716001)(110136004)(33656002)(5660300001)(66066001)(4001350100001)(47776003)(6496005)(6246003)(25786009)(97736004)(478600001)(68736007)(5009440100003)(53936002)(4326008)(83506001)(229853002)(50466002)(101416001)(189998001)(76176999)(54356999)(7736002)(9686003)(2950100002)(6916009)(42882006)(6666003)(53546010)(305945005)(42186005)(8936002)(81156014)(81166006)(23726003)(106356001)(105586002)(3846002)(6116002)(72206003)(50986999)(1076002)(8676002)(55016002)(2906002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2520; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2520; 23:KR5qLi6DBtI82IzYgjx6Hri7lJZ4ydnrJPYiz7bKw?= =?us-ascii?Q?rwzfeEVTIl2ace2j8Ail5gQ1p+iV1Rai+DM3mUEX9sAnu6roOSY22Mh9FZQD?= =?us-ascii?Q?g12yX3FrZlq5qUxYwEK6p+D1aA2+/9SGkPn7AZ9Mqb2ONeLtUNJvyxPcfLhu?= =?us-ascii?Q?YcyYcmEl3G7mc+QOKkMJWBET/6pHiCiLB6WIUU0ruyjeiYBdxQT0A1HgBoei?= =?us-ascii?Q?no5T8vu7cUDvYNc7sjuswZQ9j49L6H7rB+3umiWyl9vuCZX64Q+2ozHMkAhc?= =?us-ascii?Q?ZrG1wo6hqENuHXa0p21bl+fJ2mOyZwmRxnD5H6co/RB531+M/USazC3lW3h7?= =?us-ascii?Q?SOZKoNXkanNXSby97XiBglhdZvNqkCUXt3ny5J7Edzg6/XnRfUOyqV6tMn0Y?= =?us-ascii?Q?hUMqaT6rpyrBBY55LH7AY4ShbvWSXnQu9gcDxqUmsmA+IHAfVN4J6luo7qlb?= =?us-ascii?Q?agQezkockS+rwTU307BYpQKp7713z63Ck4Dntq1oB/0b4gh746Rt3HPW9e0t?= =?us-ascii?Q?lcxqQ9jDvDkSzOqs0LvFJvKrXDTYdGZf5xQPOP9t69MWMM0pFrTWNUTjBTNL?= =?us-ascii?Q?lkQ9lEBHuw0VDDQCC0k1beB1MY0yaOsMMV6BuXb9OMcwCWT9MM5A16+b3xQg?= =?us-ascii?Q?fp7CFjQyYpb+zzPIdtDGW+O7707JZwmFYUIWnODldwK9oZo6lZJ9rCUkSC2t?= =?us-ascii?Q?QOl8ZFZXtxisiT9n7Dq74CRforVfuXXJ90gwFVcFT4X9MJCBbX6Y7Ixa/sV4?= =?us-ascii?Q?Agk5UCDxLRFDt1TBSz4Ws5LgQUBgfKlRPR6hrUnf4yQwFCdwzjJ4jkIW1v7P?= =?us-ascii?Q?2wmLQpC3N9GbDwEJ2sEGVeqc6c6GwsrgHNghRPXm0/cHaaadP2UhHFX4lSzn?= =?us-ascii?Q?1177B1QnMdYWmHNGxXdU1s9fDtR30v4ADL9WNEFpjNODjqzwxj+9h1gG5BoG?= =?us-ascii?Q?UDKa+MeZfti4Itr/ma3U5A8nzk2w58OYai/pGudSsVN6eXG8BeX8QuzOntr6?= =?us-ascii?Q?olw2rvBJP9D9kRAGzpAPAFVzo7GMrHV7NAfAh9DDITxZOVuEzgh1xDUheMUB?= =?us-ascii?Q?Tm4sL5zMsIUzDsdzZuyDL5trR1nT8PLmDy0RZ+oB9UDSvZ0yFCznfn5/VQT2?= =?us-ascii?Q?9qeOD8FQn3JZhemmGrVcTaSI3hCyAFI1mgXCAks1rEMNw8PuGPE+Exj5hE/u?= =?us-ascii?Q?4HLsSZMUkDlRs2tyK8o0wkYmEWiaI7f4BHLR6RSzJM21WoeCVNcRhMdjBFgg?= =?us-ascii?Q?AFul1F160d9eklbxa3nYaE4TWO5bePxOsC+P/mY?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:zgPC+1MAqb364iC+j/KBIPLLrQ3RXQmWnJB/efIjGtzIDecaFVL5lZPKwFxePZuQnTl05QmGps1MSXjODYcleA0CpFiZ09KymjLjODHN4w6HSwQe5aeNBblEEjxIrlqCwAAUwy00ZelcEViBGHPlkQUFtt6ammfcUlTTXnClrcP3sX3XAdfQH94YW0lZNXPo6SoTOK3kebtOU/bB7WExtun0zBEH0+lnlPXuutZTV5V07GHH1BVDRJ6Xo9TxyEcZjA1f+awBrKyM9F3ctbKRjRqF+aYCJK71TF/C3G3HstkdEjwe+9F1iAAx0wAHXaJAsGroumPCyNbfWhJdleUTRg==; 5:a9+n3bgs4WUH2AQvNrEynidUyySZ3dEAl80ZRMWko1Of8DedqUlBIgEjlIz4xD7YBm/ajduSbcK8xSBKUuNUSqnqsIm7JA0zi9qAZJvTA1g0ZbQ5spljDW/cZqXTGaft6r6rKAFebFc21jpznF8J6w==; 24:w5mDNIddIG30cALDa+TWhYwcqE136k/khiVJ86MR+rFFHCz6vSCfwExeknuV49ritn++whmxJyVIipaHbmH58BQRQ4Y5NrBfG/KRUMejyQw=; 7:znh1UIak8ytkSRflAY0DKomVBxA/Yu+Q8wpnKKdPXf4qU3t5PLyMjil5GY5g6sq2mgG3bnh5nKJzaJr0q2wbN9oXNK2GP/wRVwUbHio2N7dEO7oCWhmWXbQTfXIA/9j+gSaRWg2q3OzstTszX7JIHHt95bV2gAPNnmHJ+j9uBrRHmWXB9GJGWxIB8JTdzYcq7FUnm1MRY5R2iVnfjEzAH2cdt3FTTDk1bS6DebcaUuY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2017 06:12:54.8051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Subject: Re: [dpdk-dev] [PATCH] net/thunderx: add device speed capability info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 06:12:58 -0000 -----Original Message----- > Date: Wed, 30 Aug 2017 14:31:07 +0100 > From: Ferruh Yigit > To: Jerin Jacob , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/thunderx: add device speed capability > info > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.3.0 > > On 8/30/2017 12:30 PM, Jerin Jacob wrote: > > updated nicvf feature file to mark support. > > > > Signed-off-by: Jerin Jacob > > --- > > doc/guides/nics/features/thunderx.ini | 1 + > > drivers/net/thunderx/nicvf_ethdev.c | 9 +++++++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/doc/guides/nics/features/thunderx.ini b/doc/guides/nics/features/thunderx.ini > > index b9720be6b..626858971 100644 > > --- a/doc/guides/nics/features/thunderx.ini > > +++ b/doc/guides/nics/features/thunderx.ini > > @@ -4,6 +4,7 @@ > > ; Refer to default.ini for the full list of available PMD features. > > ; > > [Features] > > +Speed capabilities = Y > > Link status = Y > > Link status event = Y > > Queue start/stop = Y > > diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c > > index edc17f1d4..bfad07933 100644 > > --- a/drivers/net/thunderx/nicvf_ethdev.c > > +++ b/drivers/net/thunderx/nicvf_ethdev.c > > @@ -1380,6 +1380,15 @@ nicvf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > > > dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev); > > > > + /* Autonegotiation may be disabled */ > > + dev_info->speed_capa = ETH_LINK_SPEED_FIXED; > > + dev_info->speed_capa |= ETH_LINK_SPEED_10M; > > + dev_info->speed_capa |= ETH_LINK_SPEED_100M; > > + dev_info->speed_capa |= ETH_LINK_SPEED_1G; > > + dev_info->speed_capa |= ETH_LINK_SPEED_10G; > > Why not just "|" them, same result with less code ... I thought it will give better readability. No strong opinion here, I will respin v2 with your suggestion. > > > + if (nicvf_hw_version(nic) != PCI_SUB_DEVICE_ID_CN81XX_NICVF) > > + dev_info->speed_capa |= ETH_LINK_SPEED_40G; > > + > > dev_info->min_rx_bufsize = ETHER_MIN_MTU; > > dev_info->max_rx_pktlen = NIC_HW_MAX_FRS; > > dev_info->max_rx_queues = > > >