From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 1730B37A0
 for <dev@dpdk.org>; Mon,  4 Sep 2017 13:46:44 +0200 (CEST)
Received: from lfbn-1-18623-73.w90-103.abo.wanadoo.fr ([90.103.154.73]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1dopvN-00082E-9Z; Mon, 04 Sep 2017 13:52:18 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 04 Sep 2017 13:46:36 +0200
Date: Mon, 4 Sep 2017 13:46:36 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com
Message-ID: <20170904114635.tgx6m6xr353dxrzt@neon>
References: <20170720070613.18211-2-santosh.shukla@caviumnetworks.com>
 <20170815080717.9413-1-santosh.shukla@caviumnetworks.com>
 <20170815080717.9413-2-santosh.shukla@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170815080717.9413-2-santosh.shukla@caviumnetworks.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: allow user to override default
	pool handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 11:46:44 -0000

Hi Santosh,

On Tue, Aug 15, 2017 at 01:37:16PM +0530, Santosh Shukla wrote:
> --- a/lib/librte_eal/common/eal_internal_cfg.h
> +++ b/lib/librte_eal/common/eal_internal_cfg.h
> @@ -83,6 +83,7 @@ struct internal_config {
>  	const char *hugefile_prefix;      /**< the base filename of hugetlbfs files */
>  	const char *hugepage_dir;         /**< specific hugetlbfs directory to use */
>  
> +	char mbuf_pool_name[RTE_MBUF_POOL_OPS_NAMESIZE]; /**< mbuf pool name */
>  	unsigned num_hugepage_sizes;      /**< how many sizes on this system */
>  	struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES];
>  };

> --- a/lib/librte_eal/common/include/rte_eal.h
> +++ b/lib/librte_eal/common/include/rte_eal.h
> @@ -54,6 +54,8 @@ extern "C" {
>  
>  /* Maximum thread_name length. */
>  #define RTE_MAX_THREAD_NAME_LEN 16
> +/* Maximum length of mbuf pool ops name. */
> +#define RTE_MBUF_POOL_OPS_NAMESIZE 32
>  

To avoid to define a new constant, is there something preventing to use
RTE_MEMPOOL_OPS_NAMESIZE?

Or even better, is it possible to use a 'const char *', like it's done for
hugepage_dir and hugepage_prefix?


Thanks,
Olivier