From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 085757CB9 for <dev@dpdk.org>; Mon, 4 Sep 2017 16:49:21 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="131558048" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga002.jf.intel.com with SMTP; 04 Sep 2017 07:49:17 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Sep 2017 15:49:16 +0100 Date: Mon, 4 Sep 2017 15:49:16 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Jianfeng Tan <jianfeng.tan@intel.com> Cc: dev@dpdk.org, xen-devel@lists.xenproject.org, thomas@monjalon.net, john.mcnamara@intel.com, joao.m.martins@oracle.com, jerin.jacob@caviumnetworks.com, shahafs@mellanox.com Message-ID: <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com> References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <1504116634-115687-6-git-send-email-jianfeng.tan@intel.com> <20170904144302.GD11856@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170904144302.GD11856@bricha3-MOBL3.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 04 Sep 2017 14:49:22 -0000 On Mon, Sep 04, 2017 at 03:43:02PM +0100, Bruce Richardson wrote: > On Wed, Aug 30, 2017 at 06:10:33PM +0000, Jianfeng Tan wrote: > > We remove xen-specific code in EAL, including the option --xen-dom0, > > memory initialization code, compiling dependency, etc. > > > > Besides, related documents are removed or updated. > > > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> > > --- > > MAINTAINERS | 7 - > > config/common_base | 5 - > > doc/guides/index.rst | 1 - > > doc/guides/linux_gsg/build_sample_apps.rst | 5 +- > > doc/guides/linux_gsg/sys_reqs.rst | 53 -- > > doc/guides/prog_guide/source_org.rst | 1 - > > doc/guides/rel_notes/deprecation.rst | 3 - > > doc/guides/rel_notes/release_17_11.rst | 12 + > > doc/guides/testpmd_app_ug/run_app.rst | 4 - > > doc/guides/xen/img/dpdk_xen_pkt_switch.png | Bin 163842 -> 0 bytes > > doc/guides/xen/img/grant_refs.png | Bin 6405 -> 0 bytes > > doc/guides/xen/img/grant_table.png | Bin 96762 -> 0 bytes > > doc/guides/xen/index.rst | 38 - > > doc/guides/xen/pkt_switch.rst | 470 ------------- > > .../bsdapp/eal/include/exec-env/rte_dom0_common.h | 107 --- > > lib/librte_eal/common/eal_common_options.c | 3 - > > lib/librte_eal/common/eal_internal_cfg.h | 1 - > > lib/librte_eal/common/eal_options.h | 2 - > > lib/librte_eal/common/include/rte_memory.h | 66 -- > > lib/librte_eal/linuxapp/Makefile | 2 - > > lib/librte_eal/linuxapp/eal/Makefile | 5 +- > > lib/librte_eal/linuxapp/eal/eal.c | 24 - > > lib/librte_eal/linuxapp/eal/eal_memory.c | 56 -- > > lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 381 ---------- > > .../eal/include/exec-env/rte_dom0_common.h | 108 --- > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 54 -- > > lib/librte_eal/linuxapp/xen_dom0/Makefile | 53 -- > > lib/librte_eal/linuxapp/xen_dom0/compat.h | 15 - > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_dev.h | 107 --- > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 780 --------------------- > > pkg/dpdk.spec | 3 - > > The xen functions that were removed are still listed in the linux/bsd > version.map files. Not an ABI versioning expert, but I believe they > should be removed as they are no longer present. > Reading the contributors guide section on ABI, specifically http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an-entire-abi-version it seems like we should collapse down the versions to a single one following the function removal, and also increment the whole library so version. /Bruce