From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 382A67CFD for ; Mon, 4 Sep 2017 16:57:51 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f145so5115933wme.0 for ; Mon, 04 Sep 2017 07:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VrPmsA5wKnaztB3MJbJZqxIMkQ9uEQw00Tb+NBO2Tzg=; b=CrPqRi/nsykeWQhQA/7uRNKvO2QzdbfkQqpJcihe1UXlmugRFg9Fh0c3NlZ8QyCKu5 t2eSyTR22bneXBxXGdP4RXRiW5KMYIyyz/MEohK8mNU+YNaNRlN4iVzLpLBuBm9+uaFq GZRueAn8i4BTaN43mBffEiRWqHznZv2CGcOcbw82POo22oEp7l//YJXHkDrQSZGwAiMj N17yswZrTteaYRgeMgxtmR3NJA/+yjz8i13hBxQNqYfxYc+1dI7tnj9BPhm7YfiCdoc+ CxZ5xTS5DcWUitLhkarpjOJucVUgy/vwnYAHftUEjfgvye4qrX6wuwNAQR6YL05FnBIa wmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VrPmsA5wKnaztB3MJbJZqxIMkQ9uEQw00Tb+NBO2Tzg=; b=BuIgCQ6i+5ZDaQe1LuBLSuB4RrjOYc9q9iggbZgOZZRIPlOsfSNw8UbBzpjZW2pLy9 xYz/jhLgtb//lizHuSzFUluDVNLttSYF6Ifj+8E6No69wSEVHnRlRmuNSq2hePUUgxAo OXN/JQMv+ifEBgPKrUxusDB8gQhV7lxRzEHNZRBxD61CsTFRcWJJAthHdrD8kmn1RWMG nCrD8P0yDVWrgJ/6UEzentjv2MtEFkUayaVUdQ0HxEUAY3M6ipKHNZ18vlII3IohjaAT 0pfyuC1EiAXO65o62n2mh3j7vzkJyDhnpdkoCL27/hYQfoDB6W49PpbUL0tlJzoPcuwW Wa7w== X-Gm-Message-State: AHPjjUge16/QKtKn11LQCmCaiYi0TfdaSMyJFbs8UOPSfz7ctZ6Oc2T6 W2GIRvh4nW3zd3c7 X-Google-Smtp-Source: ADKCNb7bF67wEkdB5W598coU21qRe9ETFjq7+lUyZu2+zIqswqp93DhLzLsEehwX3Yybl572qkUFDQ== X-Received: by 10.28.208.75 with SMTP id h72mr318568wmg.163.1504537070798; Mon, 04 Sep 2017 07:57:50 -0700 (PDT) Received: from localhost (lan31-h07-89-80-147-20.dsl.sta.abo.bbox.fr. [89.80.147.20]) by smtp.gmail.com with ESMTPSA id u65sm13433131wrb.18.2017.09.04.07.57.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Sep 2017 07:57:50 -0700 (PDT) Date: Mon, 4 Sep 2017 16:57:48 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170904145748.fjd3mwroy2pwwdw4@localhost> References: <20170823073358.116786-1-shahafs@mellanox.com> <1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix num seg assumption on vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:57:51 -0000 On Wed, Aug 30, 2017 at 10:07:07AM +0300, Shahaf Shuler wrote: > vPMD Tx function assumes that after the scatter of the > multi-segment packets the next packet will be a single segment packet. > > This is not current as the function can return due to lack of resources > without sending all of the multi-segment mbufs sequence. > > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > This patch should be applied only after the series: > http://dpdk.org/dev/patchwork/patch/27367/ > > on v2: > - different approach to fix the issue. > --- > drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > index 37854a73b..f89762ff8 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > @@ -112,8 +112,7 @@ txq_wr_dseg_v(struct txq *txq, __m128i *dseg, > } > > /** > - * Count the number of continuous single segment packets. The first packet must > - * be a single segment packet. > + * Count the number of continuous single segment packets. > * > * @param pkts > * Pointer to array of packets. > @@ -130,9 +129,8 @@ txq_check_multiseg(struct rte_mbuf **pkts, uint16_t pkts_n) > > if (!pkts_n) > return 0; > - assert(NB_SEGS(pkts[0]) == 1); > /* Count the number of continuous single segment packets. */ > - for (pos = 1; pos < pkts_n; ++pos) > + for (pos = 0; pos < pkts_n; ++pos) > if (NB_SEGS(pkts[pos]) > 1) > break; > return pos; > -- > 2.12.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND