From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offload detection
Date: Mon, 4 Sep 2017 17:07:12 +0200 [thread overview]
Message-ID: <20170904150712.izwsar2m5pm6tdlq@localhost> (raw)
In-Reply-To: <20170904114351.104617-1-xuemingl@mellanox.com>
On Mon, Sep 04, 2017 at 07:43:51PM +0800, Xueming Li wrote:
> PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on
> compile optimization level. The variable was not initialized and
> detection logic was absent.
>
> Fixes: 578ff15e ("net/mlx5: add hardware checksum offload for tunnel
> packets")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index d7968f5..084df88 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -445,7 +445,7 @@ struct mlx5_args {
> struct ibv_device_attr device_attr;
> unsigned int sriov;
> unsigned int mps;
> - unsigned int tunnel_en;
> + unsigned int tunnel_en = 0;
> int idx;
> int i;
>
> @@ -503,6 +503,7 @@ struct mlx5_args {
> mps = MLX5_MPW_DISABLED;
> break;
> case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX:
> + tunnel_en = 1;
> mps = MLX5_MPW;
> break;
> case PCI_DEVICE_ID_MELLANOX_CONNECTX5:
> --
> 1.8.3.1
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-09-04 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 11:43 Xueming Li
2017-09-04 15:07 ` Nélio Laranjeiro [this message]
2017-09-05 15:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904150712.izwsar2m5pm6tdlq@localhost \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).