From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id E6C4058F6 for ; Mon, 4 Sep 2017 17:07:17 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id a47so635039wra.1 for ; Mon, 04 Sep 2017 08:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DSFlUeQ0Gq33dnoA/ajwdLXuzQQkPTLN0ere8qJHXmw=; b=HntgbGCZtYfNG/2BoX67vx3bHg+cXSYXVZcIyrU92zA6TFs+WLxaZLvWuv2dcZWXwW MuAY2nUMFUkVI0qqWx9WyeXYWTZkAitH90H6rtvDHwLgApgd9RkLfTGbcQYiJh/f6dlK 2+bG3MDOROXAkcneH9f2p6bUskEgG9ASUw/Y2hkR8UV7II8n9mfTJ3uKz5n+a+hkyLH9 UJ3GtJ70dURWiOxnFwwWP1GKLLPEhI1QNBk+nB1oLaPiDzYKMDiWGi8jXteTwX7D8+0r 8293BHMFdAT3AAAyM13IDQOPcih25rF0Csmae4ZFoSdS2Xlcg4UU2gnqyJ/l5gEjZzGi v+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DSFlUeQ0Gq33dnoA/ajwdLXuzQQkPTLN0ere8qJHXmw=; b=I4R9t/2KC8Qz85bQ//yJYBDpQxAhLt7AJXPj9syxdRjcSuARwdtPi0tyLdcencN0BE XwzM+nX7ixFLuLd6f5X7SNsH8Bwv6/tO39J5939Q6Zibswo9WoR6yr44FD9WexZPnIg2 m8H74W2Oov/2QEA7QW88ZoNpbB4fc9vGyDCvuMKHe3I4QUCQKWW4TekP0cNjuOVrIVmC pEIbh0PP7GXZe5I64s9UBMa0nx9iX16OdxMYSsNaDlFcKX/JyBdL99yFiB29FvyhgpBb UWpnjsdTq9H9DtUT8qQAGnaoCGXg1QZufHK+KacVCrtUfLYKLoxmdTNiHHWJ/kv/m9z2 CUPQ== X-Gm-Message-State: AHPjjUijeUS/TyRV3mvCbIMNZnBqdddK58s63Iq2+sAOknFOt3SJB0yq v6lOirZL+Nc1+0WZwNohAw== X-Google-Smtp-Source: ADKCNb6fidms3hf6pLLIC4k+ZcisOh6/vmgxKQUXJFgbhd8HqAuZqIyUpLkpVcCtR6bigc0qOvCvHg== X-Received: by 10.223.195.41 with SMTP id n38mr576560wrf.75.1504537637601; Mon, 04 Sep 2017 08:07:17 -0700 (PDT) Received: from localhost (lan31-h07-89-80-147-20.dsl.sta.abo.bbox.fr. [89.80.147.20]) by smtp.gmail.com with ESMTPSA id a6sm4850867wrh.66.2017.09.04.08.07.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Sep 2017 08:07:14 -0700 (PDT) Date: Mon, 4 Sep 2017 17:07:12 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Adrien Mazarguil , dev@dpdk.org Message-ID: <20170904150712.izwsar2m5pm6tdlq@localhost> References: <20170904114351.104617-1-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170904114351.104617-1-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offload detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 15:07:18 -0000 On Mon, Sep 04, 2017 at 07:43:51PM +0800, Xueming Li wrote: > PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on > compile optimization level. The variable was not initialized and > detection logic was absent. > > Fixes: 578ff15e ("net/mlx5: add hardware checksum offload for tunnel > packets") > > Signed-off-by: Xueming Li > Acked-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index d7968f5..084df88 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -445,7 +445,7 @@ struct mlx5_args { > struct ibv_device_attr device_attr; > unsigned int sriov; > unsigned int mps; > - unsigned int tunnel_en; > + unsigned int tunnel_en = 0; > int idx; > int i; > > @@ -503,6 +503,7 @@ struct mlx5_args { > mps = MLX5_MPW_DISABLED; > break; > case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX: > + tunnel_en = 1; > mps = MLX5_MPW; > break; > case PCI_DEVICE_ID_MELLANOX_CONNECTX5: > -- > 1.8.3.1 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND