From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 695247CCD for ; Mon, 4 Sep 2017 18:13:55 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 09:13:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="125448104" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga004.jf.intel.com with SMTP; 04 Sep 2017 09:13:52 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Sep 2017 17:13:51 +0100 Date: Mon, 4 Sep 2017 17:13:51 +0100 From: Bruce Richardson To: Olivier Matz Cc: dev@dpdk.org, nhorman@tuxdriver.com Message-ID: <20170904161350.GA29492@bricha3-MOBL3.ger.corp.intel.com> References: <20170830135154.32092-1-olivier.matz@6wind.com> <20170904160020.GA28252@bricha3-MOBL3.ger.corp.intel.com> <20170904160346.GB28252@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170904160346.GB28252@bricha3-MOBL3.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] devtools: rework abi checker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 16:13:55 -0000 On Mon, Sep 04, 2017 at 05:03:47PM +0100, Bruce Richardson wrote: > On Mon, Sep 04, 2017 at 05:00:21PM +0100, Bruce Richardson wrote: > > On Wed, Aug 30, 2017 at 03:51:54PM +0200, Olivier Matz wrote: > > > The intiatial version of the script had some limitations: > > > - cannot work on a non-clean workspace > > > - environment variables are not documented > > > - no compilation log in case of failure > > > - return success even it abi is incompatible > > > > > > This patch addresses these issues and rework the code. > > > > > > Signed-off-by: Olivier Matz > > > > Giving this a spin to test it out. First impression is good, gives nice > > output of what is happening, though perhaps a little verbose by default. > > > > The output finishes though by printing: > > INFO: HTML reports are in /home/bruce/dpdk-clean/abi-check/compat_reports directory > > > > Unfortunately: > $ ls -l /home/bruce/dpdk-clean/abi-check/compat_reports > ls: cannot access '/home/bruce/dpdk-clean/abi-check/compat_reports': No such file or directory > > > On the plus side, introducing an abi error in a library is detected and the library in question is reported as part of the output. Still no HTML reports to be found though. /Bruce