[dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value

[dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value

[Zhiyong Yang]

In order to support more than 256 virtual ports, the field "port" in
rte_mbuf has been increased to 16 bits. The initialization/reset
value of the field "port" should be changed from 0xff to 0xffff
accordingly.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 lib/librte_mbuf/rte_mbuf.c | 2 +-
 lib/librte_mbuf/rte_mbuf.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 26a62b8e1..2e80ed9b1 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
 	/* init some constant fields */
 	m->pool = mp;
 	m->nb_segs = 1;
-	m->port = 0xff;
+	m->port = 0xffff;
 	rte_mbuf_refcnt_set(m, 1);
 	m->next = NULL;
 }
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index eaed7eee0..cdc70aa83 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1095,7 +1095,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m)
 	m->vlan_tci = 0;
 	m->vlan_tci_outer = 0;
 	m->nb_segs = 1;
-	m->port = 0xff;
+	m->port = 0xffff;
 
 	m->ol_flags = 0;
 	m->packet_type = 0;
-- 
2.13.3

Re: [dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value

[Stephen Hemminger]

On Mon,  4 Sep 2017 14:55:32 +0800
Zhiyong Yang <zhiyong.yang@intel.com> wrote:

> In order to support more than 256 virtual ports, the field "port" in
> rte_mbuf has been increased to 16 bits. The initialization/reset
> value of the field "port" should be changed from 0xff to 0xffff
> accordingly.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>  lib/librte_mbuf/rte_mbuf.c | 2 +-
>  lib/librte_mbuf/rte_mbuf.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 26a62b8e1..2e80ed9b1 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
>  	/* init some constant fields */
>  	m->pool = mp;
>  	m->nb_segs = 1;
> -	m->port = 0xff;
> +	m->port = 0xffff;
>  	rte_mbuf_refcnt_set(m, 1);
>  	m->next = NULL;
>  }
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index eaed7eee0..cdc70aa83 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1095,7 +1095,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m)
>  	m->vlan_tci = 0;
>  	m->vlan_tci_outer = 0;
>  	m->nb_segs = 1;
> -	m->port = 0xff;
> +	m->port = 0xffff;
>  
>  	m->ol_flags = 0;
>  	m->packet_type = 0;

Maybe introduce MBUF_INVALID_PORT as a constant?

#define MBUF_INVALID_PORT  0xffff

Re: [dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value

[Yang, Zhiyong]

Hi, Stephen:

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, September 5, 2017 11:40 AM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value
> 
> > @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> >  	/* init some constant fields */
> >  	m->pool = mp;
> >  	m->nb_segs = 1;
> > -	m->port = 0xff;
> > +	m->port = 0xffff;
> >  	rte_mbuf_refcnt_set(m, 1);
> >  	m->next = NULL;
> >  }
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index eaed7eee0..cdc70aa83 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -1095,7 +1095,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf
> *m)
> >  	m->vlan_tci = 0;
> >  	m->vlan_tci_outer = 0;
> >  	m->nb_segs = 1;
> > -	m->port = 0xff;
> > +	m->port = 0xffff;
> >
> >  	m->ol_flags = 0;
> >  	m->packet_type = 0;
> 
> Maybe introduce MBUF_INVALID_PORT as a constant?
> 
> #define MBUF_INVALID_PORT  0xffff

Make sense.  Thanks for your suggestion.

Thanks
Zhiyong

[dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value

[Zhiyong Yang]

In order to support more than 256 virtual ports, the field "port"
in rte_mbuf has been increased to 16 bits. The initialization/reset
value of the field "port" should be changed from 0xff to 0xffff
accordingly.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---

Changes in V2:
Introduce MBUF_INVALID_PORT as a constant.

 lib/librte_mbuf/rte_mbuf.c | 2 +-
 lib/librte_mbuf/rte_mbuf.h | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 26a62b8e1..bcf4e2fcf 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
 	/* init some constant fields */
 	m->pool = mp;
 	m->nb_segs = 1;
-	m->port = 0xff;
+	m->port = MBUF_INVALID_PORT;
 	rte_mbuf_refcnt_set(m, 1);
 	m->next = NULL;
 }
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index eaed7eee0..e32038a73 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1087,6 +1087,8 @@ static inline void rte_pktmbuf_reset_headroom(struct rte_mbuf *m)
  * @param m
  *   The packet mbuf to be resetted.
  */
+#define MBUF_INVALID_PORT 0xffff
+
 static inline void rte_pktmbuf_reset(struct rte_mbuf *m)
 {
 	m->next = NULL;
@@ -1095,7 +1097,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m)
 	m->vlan_tci = 0;
 	m->vlan_tci_outer = 0;
 	m->nb_segs = 1;
-	m->port = 0xff;
+	m->port = MBUF_INVALID_PORT;
 
 	m->ol_flags = 0;
 	m->packet_type = 0;
-- 
2.13.3

Re: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> Sent: Tuesday, September 5, 2017 1:13 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Yigit, Ferruh; stephen@networkplumber.org; Yang,
> Zhiyong
> Subject: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value
> 
> In order to support more than 256 virtual ports, the field "port"
> in rte_mbuf has been increased to 16 bits. The initialization/reset value of the
> field "port" should be changed from 0xff to 0xffff accordingly.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> 
> Changes in V2:
> Introduce MBUF_INVALID_PORT as a constant.
> 
>  lib/librte_mbuf/rte_mbuf.c | 2 +-
>  lib/librte_mbuf/rte_mbuf.h | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index
> 26a62b8e1..bcf4e2fcf 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
>  	/* init some constant fields */
>  	m->pool = mp;
>  	m->nb_segs = 1;
> -	m->port = 0xff;
> +	m->port = MBUF_INVALID_PORT;
>  	rte_mbuf_refcnt_set(m, 1);
>  	m->next = NULL;
>  }
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index
> eaed7eee0..e32038a73 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1087,6 +1087,8 @@ static inline void
> rte_pktmbuf_reset_headroom(struct rte_mbuf *m)
>   * @param m
>   *   The packet mbuf to be resetted.
>   */
> +#define MBUF_INVALID_PORT 0xffff
Replaced with below, or use UINT16_MAX directly?
#define MBUF_INVALID_PORT UINT16_MAX

> +
>  static inline void rte_pktmbuf_reset(struct rte_mbuf *m)  {
>  	m->next = NULL;
> @@ -1095,7 +1097,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf
> *m)
>  	m->vlan_tci = 0;
>  	m->vlan_tci_outer = 0;
>  	m->nb_segs = 1;
> -	m->port = 0xff;
> +	m->port = MBUF_INVALID_PORT;
> 
>  	m->ol_flags = 0;
>  	m->packet_type = 0;
> --
> 2.13.3

Re: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value

[Thomas Monjalon]

05/09/2017 07:13, Zhiyong Yang:
> In order to support more than 256 virtual ports, the field "port"
> in rte_mbuf has been increased to 16 bits. The initialization/reset
> value of the field "port" should be changed from 0xff to 0xffff
> accordingly.

This patch should be merged with the range increase.

Re: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value

[Yang, Zhiyong]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, September 5, 2017 3:28 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org
> Subject: Re: [PATCH v2] librte_mbuf: modify port initialization value
> 
> 05/09/2017 07:13, Zhiyong Yang:
> > In order to support more than 256 virtual ports, the field "port"
> > in rte_mbuf has been increased to 16 bits. The initialization/reset
> > value of the field "port" should be changed from 0xff to 0xffff
> > accordingly.
> 
> This patch should be merged with the range increase.

Ok. it will be merged with range increase patchset.
thanks
Zhiyong

Re: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization value

[Yang, Zhiyong]

Hi, helin:

> > +#define MBUF_INVALID_PORT 0xffff
> Replaced with below, or use UINT16_MAX directly?
> #define MBUF_INVALID_PORT UINT16_MAX

I prefer  #define MBUF_INVALID_PORT UINT16_MAX

Thanks 
Zhiyong