From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E9549293B for ; Tue, 5 Sep 2017 06:19:15 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 21:19:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,478,1498546800"; d="scan'208";a="307955535" Received: from debian-zgviawfucg.sh.intel.com (HELO debian-ZGViaWFuCg) ([10.67.104.160]) by fmsmga004.fm.intel.com with ESMTP; 04 Sep 2017 21:19:13 -0700 Date: Tue, 5 Sep 2017 12:19:40 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: dev@dpdk.org, yliu@fridaylinux.org, jfreiman@redhat.com, mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com Message-ID: <20170905041940.GB31895@debian-ZGViaWFuCg> References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-6-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170831095023.21037-6-maxime.coquelin@redhat.com> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH 05/21] vhost: add support to slave requests channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 04:19:16 -0000 On Thu, Aug 31, 2017 at 11:50:07AM +0200, Maxime Coquelin wrote: > Currently, only QEMU sends requests, the backend sends > replies. In some cases, the backend may need to send > requests to QEMU, like IOTLB miss events when IOMMU is > supported. > > This patch introduces a new channel for such requests. > QEMU sends a file descriptor of a new socket using > VHOST_USER_SET_SLAVE_REQ_FD. > > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 2 ++ > lib/librte_vhost/vhost_user.c | 27 +++++++++++++++++++++++++++ > lib/librte_vhost/vhost_user.h | 10 +++++++++- > 3 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 18ad69c85..2340b0c2a 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -196,6 +196,8 @@ struct virtio_net { > uint32_t nr_guest_pages; > uint32_t max_guest_pages; > struct guest_page *guest_pages; > + > + int slave_req_fd; > } __rte_cache_aligned; > > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 8984dcb6a..7b3c2f32a 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -76,6 +76,7 @@ static const char *vhost_message_str[VHOST_USER_MAX] = { > [VHOST_USER_SET_VRING_ENABLE] = "VHOST_USER_SET_VRING_ENABLE", > [VHOST_USER_SEND_RARP] = "VHOST_USER_SEND_RARP", > [VHOST_USER_NET_SET_MTU] = "VHOST_USER_NET_SET_MTU", > + [VHOST_USER_SET_SLAVE_REQ_FD] = "VHOST_USER_SET_SLAVE_REQ_FD", > }; > > static uint64_t > @@ -122,6 +123,11 @@ vhost_backend_cleanup(struct virtio_net *dev) > munmap((void *)(uintptr_t)dev->log_addr, dev->log_size); > dev->log_addr = 0; > } > + > + if (dev->slave_req_fd >= 0) { > + close(dev->slave_req_fd); > + dev->slave_req_fd = -1; The slave_req_fd should also be initialized to -1 when allocating the virtio_net structure. Currently, it's missing. Best regards, Tiwei Bie