From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A81532BAF for ; Tue, 5 Sep 2017 15:27:31 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id i145so19465693wmf.1 for ; Tue, 05 Sep 2017 06:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LeRDLl1LRIZ8k+JIILb0gcnXBRJ7vmBWs/A7sQHbM7A=; b=OfmjiBMg0fdZmatajIzG0ze8Cj1LXMiz7MDVAiOtVflj3dUcepIy3O0B3NSy6ZcIIo UjU41r6j82Ef1SxO1jtPK1eFGkcgFKBemXfUy9RRaVtFE22W3pE3/H5ugqbIk/CVAkLa JzYZVG7N0AR1G1KNIOXWN+kI54DjaOO4qaB4+mIxbFIsp2HdPyjBk/FR/gNo7e0cBWQx P4HgNRJPDw7mYNkZS/hdZdExmvY3qdxqRJeLpUVWoiUebZuVruM5Gi5cQ/PMU9yV5ets WczsVmXA26eOeCmo1lodByxvdQpv7jyTUaw32y8VAQINpkz3ZvMHPg7fcHEq+CF2QdSl Vu8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LeRDLl1LRIZ8k+JIILb0gcnXBRJ7vmBWs/A7sQHbM7A=; b=djb3UnTRdsHwLo2Ed7/kyAAu6ZId/2rier7rB/7yxQpQ4Ctb9DZeEU/dSWu7DphCOR fmbFVsLCvprnLgn/zTkgPxz15BOzcO6SVHZjBQicKe50/dbVq9wfgg2lTXaVbdM1vKfa 2cNWIyQATUALhZh7RNCKkuO27yf+ii4KbajgpJ+RpUgEsLdpp3Y4x9EpYFsXs/2+easJ TdtjbFWn7UsBwuKcdxNxl6DB6NTlCv+A0L4V9JE3xJaqmll2KnU6na4+eihpGDQWjRBp 4yS83izwd7WiXThe/vsW98lcBPl4aiy89YF2IU1+apxjWjg1Fnh5Uits4tB2uGKM8+ZL S/Xw== X-Gm-Message-State: AHPjjUivJEZUKNnHYmEOR62iVaC0Ezd5AgRGp4WUXw5YlDahkDtwISgI 0dsmlhyuil2LIgoX X-Google-Smtp-Source: ADKCNb5C3EQkxj8BPBT++XjOAEdT5LKGeCaxlWRknLz6dFZu9TeUcQpcWiXowTeqTTvAPGz3PA3qSw== X-Received: by 10.28.153.85 with SMTP id b82mr2144687wme.121.1504618050913; Tue, 05 Sep 2017 06:27:30 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g132sm614889wmd.5.2017.09.05.06.27.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 06:27:29 -0700 (PDT) Date: Tue, 5 Sep 2017 15:27:20 +0200 From: Adrien Mazarguil To: Shachar Beiser Cc: dev@dpdk.org, Nelio Laranjeiro , stable@dpdk.org Message-ID: <20170905132720.GD4301@6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 13:27:31 -0000 Hi Shachar, On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote: > return value is sometimes returned uninitialized > > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions") > > Cc: adrien.mazarguil@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Shachar Beiser Looks like in both commits, ret is properly initialized so I'm wondering if the fixes line is right? Did you even get a compilation error? Otherwise, you should drop this patch from the series. > --- > drivers/net/mlx5/mlx5_rxq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 437dc02..24887fb 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1330,7 +1330,7 @@ > struct priv *priv = mlx5_get_priv(dev); > struct rxq *rxq = (*priv->rxqs)[rx_queue_id]; > struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq); > - int ret; > + int ret = 0; > > if (!rxq || !rxq_ctrl->channel) { > ret = EINVAL; > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND