From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0063.outbound.protection.outlook.com [104.47.34.63]) by dpdk.org (Postfix) with ESMTP id CBB883DC for ; Wed, 6 Sep 2017 06:33:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6Qs6WEPMYDaYfOLZj1BWx3zTCJYBFghpapaMCL3u4OE=; b=nAoFi73qiwZDzPEeJeOISn50A4jvIDF2RBmZYnawZkfQqc293BY+mrTI+OULG0SMwjz4MDqOsjJvf4Hmg4LRcNXHV1li9HZ1AnDOHDaRor0LJnnQXuu9wMWrbOy4wGhtiWrU3te7SEe8yFZvxJpMiX8o4KFMlSbb9ygibGiMtHs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (103.16.71.100) by CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 04:33:11 +0000 Date: Wed, 6 Sep 2017 10:02:45 +0530 From: Pavan Nikhilesh Bhagavatula To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20170906043244.GA27242@PBHAGAVATULA-LT> References: <1504608532-18598-1-git-send-email-pbhagavatula@caviumnetworks.com> <1504608532-18598-2-git-send-email-pbhagavatula@caviumnetworks.com> <20170905102901.0d9db417@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905102901.0d9db417@xeon-e3> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [103.16.71.100] X-ClientProxiedBy: SG2PR06CA0106.apcprd06.prod.outlook.com (10.170.138.32) To CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1cd56e3-8290-4614-638a-08d4f4e0624e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:JI9wkQfyb9Y725vdK4zfWhFC8tBhNPfjfzYlO0WlqiZrhWDPhSZld/kbZM61gUv3MKLFdlYi4TxcuIWCvuNTufVhg4DHmMlF6zL7QZkbNIvqgQJVcJTh9es1TfunwtSI/oBFJTCZ2FY++jn74KuB3ffmlmsZVml27jfSXeJSZboHK4F4/e31F3nPXlhOw/BWCwv3ygv/f+igBs8YDd8+MZZswMGfpguB9QOfcN8jC/YxvxKD1K+e/5zXN3RwdN75; 25:tVXUL1OSvTYafuyrZicALzWmjURaKTWUxWI6VqtiqiPQVysizQMtxg+YfX8nn2ceu2lm8CA+gI49jGp+rDbC5YC/2CDK4p36diikz0AN+z6YWATVOrCYDMsMVOOWwS84KHhREZ34JS9lTXTVUmS6mAYJEEtx/gSpfJ+wP3HK994rBUiQTfjo8wxZEYgTXliir1zzqvmmGuz2otOkk0EiKspDvrzAfOh3nsc3va9Wg5Vgu+/sD7ZObcbAC/5kwK2I026w7QxolpOqWfY1jGQ2CEjX1Xzkq5gjdna4uGxkApzCEnXLZ+UvcU6KrmKM/Ao1cVg1D9DZgjqR5gqc0BN3WA==; 31:p3E28h0h1YNnv1Oc9RqxoxX97nhwDvtSwUORNVSYE7lBl7o5ug6yUUDs0iOHPJXMOvTobfm+SOmEj3RTLDJtFhJ9rBjmvovTIkKge1oIFnNIAs5dnygY5ba5eiPGK+AqCbUVmUQ+bcdjVhBfgfK7hPk6O5sdMHMpU/5Q82MdPHXvej8s4qzVK5cTJTI+wEQYbZTnw6xeFPye2CRC0pqq56QaPdDakIImRYNnwVM1SDU= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:lW8hrEYJ5NLSf6ZqX4XB6sSfQzqzfAFrzYmqkIZ9yevVDjZXRhDA0mwf0b1LhSknjsOACzfAtpyTsCI4qq28gFkDKcNS/xnYkGoWUaLjM/MPDXfe7mvVoZIOcmHtFpv5l5szM90UOTRtlcOMzz8Xdqd29gkOdxKP3LAIklyLLhVx6GD7qHN/AYNuvvect/vS2/d/f9bU8fBW24kqBARWRZzEelAjwrLsBVobobo9EKgkmc+FGn4rQPSrzXRvVIMQ/dtuU8cQw4zUg5eUXRPZrgQq81ZGvd7ihaXMgrGQprHO+jy5HOeKSLf1j3Oi6sIBoDrPgq1fM9N9u/pngVn1xThkfzlwMnZDzdkXz02NGuM8QfKf63F0/iA+BbJNKdBVARYin4MFLjpdEUmp4hzcRLBQePABowvadpHHxmsTFIXJiBFkQZlmXfT316qQ3a9+Z6J7mmDVIgrBo2h3+0YW0gCrnHjyv7RpFCNT7m/TiLIka5CL8tcAiEnHRfriesizqxBVQIxqf+LwASeTxcNG6UVrbKuI0c3wWAjDZ3eyjZ9wGRB3Zort0Yc3qscFDeV2K9BZ4KI/V1WeONlzB5c7ttZbzTIgPyWpNQFsGx88u70=; 4:AD3YqgXGdR+VtipCXZD6Jacj3LL3xSCx06qGAY6Xab5ZT4yr/ecOi7eiuXce/uzV0Sj7fAprsAN+ModnBGRaQuSM2RLKDPsrZG4oq7YgfHFjvLKgo2qwxtnEE4xh7zQsAfd5TUJNn/7t3i5WTfOANK5MU8A9Kbjn0gpr7ucF8yE+ucajb3htTBxPXCHHv0I4aVwL4UYMBrabP09V5hpgWobI/fXpQKmOW86wGQrr5+S0PHHu4QZccc6so1cPRL6ejztfhogNAaOEgLpNnKvHgsYhZjUMDamYZxKvuL44DK8= X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(100000703101)(100105400095)(3002001)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3464; X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(24454002)(42882006)(68736007)(6246003)(42186005)(189998001)(50466002)(7736002)(305945005)(6496005)(66066001)(110136004)(33656002)(9686003)(81156014)(81166006)(8676002)(55016002)(105586002)(33716001)(47776003)(53936002)(6666003)(23726003)(50986999)(76176999)(8936002)(97736004)(101416001)(6116002)(83506001)(6916009)(4001350100001)(106356001)(3846002)(2950100002)(1076002)(478600001)(54356999)(2906002)(72206003)(229853002)(4326008)(5660300001)(25786009)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:XJggZ8dtfLZAwYVdFdzNklL3x1jnwjK/t0woYFBbH?= =?us-ascii?Q?3dE+3X14Pdv0Vu/FQnOZG6SULZza8DU6YFAWakKcJ5PhgF60JvaAW16BeGOD?= =?us-ascii?Q?fknolmh8liSwijgirNL2ZtzpsHx2Q+ukvirMzgEDNg8OIzBXPdCUTHh0UKNv?= =?us-ascii?Q?RiQkEJ6EzSWY1U+fj8X3itLqIFgENZyFyxZfHf4lVDy1tR2ZIjr9zG6jFZCm?= =?us-ascii?Q?732e3hpRHlF6y2AaSNd5I9yQEtYean+RPLveiuEOAAmrEx0mPLhxRwDmV3LK?= =?us-ascii?Q?ctQ0XIDiXoQs4WWyRt5LWgrGRByUYK9x+CzXVfcagjY0j33q5s5+GvRhwi46?= =?us-ascii?Q?1IspOtdFoHq+bf6CH5gnrZiDAU90j6sG0coBmBI9MJqpKkAyYsJUjNVVeVnU?= =?us-ascii?Q?CMkZUJEhwJFD1eYffCXNjXOyahQZIbCnY+UhXd0YuivNMxg3JAP1Xxi9UTpC?= =?us-ascii?Q?qbCNGFxpSaVSw7h0PkFG0vlWw+j9Ec7rKcqACW3Ax1D3TGwDkAHG45YrOx6W?= =?us-ascii?Q?PlcbuqECTqpPOeGaY2Y+sFi60sE/yoj68q708c+pA4yZ8qfSQ5jSqVcO/Hui?= =?us-ascii?Q?Leob8/pa3mhDyqJV5cNW2I0MvpaEfx52K6dvQwCI81mFeP5UciaTjlLVn42s?= =?us-ascii?Q?Itsa5/lwYP4xPAXX6zZZPgXrB9pvYy5GCYNAsxo4GyLEj3L9q6ieU0t5xjvV?= =?us-ascii?Q?vAJgpIdYRhMk6PfP64Iev+N0TzW66fLn9YMtkNTKCLWzCKGNxX6aDAJpFAX+?= =?us-ascii?Q?EMF+ZSO6BjN1jilMGfhQGMhIxTNcEa4jT3ZVoDg0HNMdTG7vatGzVQjOaMh+?= =?us-ascii?Q?zkdtkme2W9pWhziRMOifbA1BbSJQTxdmLmvsYVYpyNeWV0gudvzztAd8XgXV?= =?us-ascii?Q?+AWMrt5L1rC8VTNfd1yLTgY7wLtDJQ0ZYC6F+1xYMHNFSAdmLLmDv7QQwu7g?= =?us-ascii?Q?Z1O8j7cYg5M6onduLtycrWX5XN7YzfDcvD0vvjN5+K7iAslsf1UBqhZ7G/YI?= =?us-ascii?Q?MhG/11WFp3FLNkiCvlXesToGjKB6Hq4JPtNlfRDKJ1T3nxatMYi2gjbctpWj?= =?us-ascii?Q?14/3GaK77vUDHgLyAkWvGKscE/8ojxkF8zeFN8o4rmZXimM9SPII3i0watFz?= =?us-ascii?Q?MPRvuYvN7Ly44XwU0q+XUXGCWYt5zNCHj4IHE+PXJGDf3jB47LaP/8XUJiIS?= =?us-ascii?Q?KHvPaHP1Y+Azzs=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:uSll2A+TEoYJ0wHHqb+Lp9yFzRcrrtopKbEqg5RMfrMe3DC7e/EOiEvb29+hKrCljcs9JhbzuMtkVgFcjgxo8GTcDa4YJV0a46mdcMcK1psaEQfrfNnIhz5j00tb17kRGShDD789jZk56KKWJ0dZOIC7CewaJXYgF5fpda1MEXUprX+Xdg3QqXy5qt8OnuzIt9FFWm7YBDFCdd5sm+ElGbqYWtcAY3S8dHUAAk+CgYsVH/KRsLkBB7tKI+8IF8VRO77ptxMINKoosjDa6uqtuFsrkl0/idMfBxrvNPQwjDStoIygNGihWw3n9d+nHEgbUIH+Raj2HgR3SE+iWNZ8+Q==; 5:HFuMAmCySqoTtHPhlzyyStr6BS/lDPBmsjpB4CRqENt/cnm7nk77SIzh0IJz8+WPftpioPCi5MkFUsJzHb9lb+lnRvC1vxRHg2VYPlMshdDqagb0NGSWDq3prDNjqBTbzrMqKfLuCdPMoPoaT8qxCw==; 24:19BqksCK5igcCxxsEgoev/mGq+sHET3ijGBO/p35vQHmk9rDgFzSEVtN+072D+b/XW1LGJjUTl9UN9TzFWPgZRJN7EkSocIMOV2PLOUJLv0=; 7:lZ0hqTFyHl9o3/Uxmt5gej2/DwL7UeO8jtj33XbUewi2c+Bn6xgrN+qW3Si75tGmuu32mLdi6SkXjGJBvgnZXR+paWB9ELDW9jRcDCsK0vQtBUlpo0tjgoPyDTkoclcoegja0Z8Xp/fQ+CB3oDwtg9cpZ3emW64zDXFziWUYFiWlvkJTOK7vMSbJhASjngDXNk3cFwUsMABP+MMa0DHnhqbwkB0IQhqRoKhWFiRbUI4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 04:33:11.4926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH v4 2/3] eal: add u64 bit variant for reciprocal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 04:33:19 -0000 On Tue, Sep 05, 2017 at 10:29:01AM -0700, Stephen Hemminger wrote: > On Tue, 5 Sep 2017 16:18:51 +0530 > Pavan Nikhilesh wrote: > > > +/** > > + * Unsigned 32-bit divisor structure. > > + */ > > +struct rte_reciprocal_u32 { > > uint32_t m; > > uint8_t sh1, sh2; > > -}; > > +} __rte_cache_aligned; > > + > > +/** > > + * Unsigned 64-bit divisor structure. > > + */ > > +struct rte_reciprocal_u64 { > > + uint64_t m; > > + uint8_t sh1; > > +} __rte_cache_aligned; > > I understand you want to squeeze every cycle out but it is not > required that each of these structures always be cache aligned. > > They maybe embedded in other structures and having the structure > padded so that these elements are cache aligned would take up > more space and make cache performance worse. > > Better off to not put attributes on the structure definitions, and instead > let usages of this feature align where appropriate. > Agreed, will remove cache alignment in the next version (v6). Thanks, Pavan.