From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id D035F37AC for ; Wed, 6 Sep 2017 17:37:23 +0200 (CEST) Received: by mail-pf0-f175.google.com with SMTP id g13so13365056pfm.2 for ; Wed, 06 Sep 2017 08:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=odcN0rLXrbG48wib0TNSyMnLdjrXUIUSM4u+wRc1j0g=; b=YxOikFwru37Gy/KtbrDjPFvoGXUHf4qfzLpvhwQom755Unl3hmkR5kNenwU8dKK3Gt Kj0QCkd6UDwVgiUKFfk9xMUdogv46P8PzmPdQyWjbA7DlGoqTV/CbcVHqsWzrHTLXwex kK2hDah+i2EY5lTCFyFx93PcUUv9vmfRa8Z7DNjwR3rAABS8N5dw+VF0sR90O1BN4kWG Vbvx+m+wpsnO20WHzofsOm+pSeQTnXiRiThYFo53h1p2e2L+b4x+AquhyvklmehcilbY /pxIw6iMSOCnlVRRgBYwCCUSD0RuIgJPUUYYODUPegWbzBR6zNFmdg33ytyHLPCPZgOQ u6ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=odcN0rLXrbG48wib0TNSyMnLdjrXUIUSM4u+wRc1j0g=; b=VjA2fRekc0yvb6MM7RJ9pPpPDOWo0UZA4NIj/tsPvRx+JJ/iVGYxb0V4f1Y9wiQfq+ mCOW1LO637cLbWUaRQWk8p4tLOxHYy5/mEuf11bd324F5B5zqY/ZS8oj5ggpXR8EqQe8 mTkJ58LS5xoLPQFTj97Nnj4lz8u46k0Z6XxJedGBZJ8lkzc0obZrAC9EBPFcOyRiNjiu rG1WVM0W58s30B3u72zStAnRM1ItPnbP/KdPEqahrK7F63QHzV5mAXDjCBHwVDydjm3Y A/RjkGZJZqn2mYiXBu7648qyUTH8KbiVdb4HncZbYRLPdcOx8UKlrcnccyjnZq9cK11W 3FKg== X-Gm-Message-State: AHPjjUi32H42P1tW7jKw+RaVL5OvjlmMgHvcor8HdArW9Bzp5y/Ai117 tcC/gGVfACukbBqCGuaXVw== X-Google-Smtp-Source: ADKCNb77TAuonknCGzSkEKNAwfzccDxQXEdip/m7Ys7JxRMwhqPhEYXh6pp7dmMzKnYTgbmWnPtIog== X-Received: by 10.99.112.20 with SMTP id l20mr8387777pgc.210.1504712242877; Wed, 06 Sep 2017 08:37:22 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id c20sm193937pfh.17.2017.09.06.08.37.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Sep 2017 08:37:22 -0700 (PDT) Date: Wed, 6 Sep 2017 08:37:15 -0700 From: Stephen Hemminger To: Pavan Nikhilesh Bhagavatula Cc: Kevin Traynor , cristian.dumitrescu@intel.com, dev@dpdk.org Message-ID: <20170906083715.2084ec8d@xeon-e3> In-Reply-To: <20170906144133.GA21468@PBHAGAVATULA-LT> References: <1504693294-2100-1-git-send-email-pbhagavatula@caviumnetworks.com> <1504693294-2100-2-git-send-email-pbhagavatula@caviumnetworks.com> <11668986-444f-4238-147f-4baa82d15285@redhat.com> <20170906144133.GA21468@PBHAGAVATULA-LT> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 15:37:24 -0000 On Wed, 6 Sep 2017 20:11:34 +0530 Pavan Nikhilesh Bhagavatula wrote: > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > > From: Pavan Bhagavatula > > > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > > > commit adds support for unsigned 64bit divisors. > > > > > > Rename unsigned 32bit specific functions appropriately and update > > > librte_sched accordingly. > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 +- > > > lib/librte_eal/common/include/rte_reciprocal.h | 109 ++++++++++++++++++++-- > > > lib/librte_eal/common/rte_reciprocal.c | 116 +++++++++++++++++++++--- > > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +- > > > lib/librte_sched/Makefile | 4 +- > > > lib/librte_sched/rte_sched.c | 9 +- > > > 6 files changed, 219 insertions(+), 25 deletions(-) > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > index 90d7258..59a85bb 100644 > > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > @@ -241,6 +241,7 @@ EXPERIMENTAL { > > > DPDK_17.11 { > > > global: > > > > > > - rte_reciprocal_value; > > > + rte_reciprocal_value_u32; > > > + rte_reciprocal_value_u64; > > > > > > } DPDK_17.08; > > > diff --git a/lib/librte_eal/common/include/rte_reciprocal.h b/lib/librte_eal/common/include/rte_reciprocal.h > > > index b6d752f..85599e6 100644 > > > --- a/lib/librte_eal/common/include/rte_reciprocal.h > > > +++ b/lib/librte_eal/common/include/rte_reciprocal.h > > > > Hi Pavan, sorry for commenting late but the license in v1 of this file > > states it cannot be removed. It is not included in later versions - can > > you explain why? > > > Hi Kevin, > > I have misinterpreted this mail > http://dpdk.org/ml/archives/dev/2017-August/073781.html, > any suggestion on how to proceed on this further? > > Thanks, > Pavan License issues need legal advice (TAB could ask LF if required). Sorry, I am a cynic engineer not a lawyer. Easiest solution is to find equivalent code in FreeBSD or some other project which does not have the restrictions.