From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id 6BCC4101B for ; Wed, 6 Sep 2017 11:01:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xf99eGujRoNrtsN9OzK47ppZoFkJGtOQV/hd8UD0Y18=; b=eWCIev5en5e6sR5a5inEoQqRCGrQ/f9V1AteltsBdCpotXQtOq/F65X6YwT4cJJvbl4acM9Dx0PK/YDw2+/nF1iFMUk/VQZE1Pvp6CkecoMsEoV0H5yxdln/RfcPkKS3Dxmxt/8V9cWrgvUcYCnVQrGgeMtfnzbzTvFUrLX0A/k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Guduri.Prathyusha@cavium.com; Received: from cavium.com (111.93.218.67) by BY2PR0701MB2101.namprd07.prod.outlook.com (10.163.156.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 09:01:19 +0000 Date: Wed, 6 Sep 2017 14:31:03 +0530 From: Guduri Prathyusha To: "Van Haaren, Harry" Cc: dev@dpdk.org Message-ID: <20170906090101.GA15798@cavium.com> References: <20170906071541.1922-1-gprathyusha@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (10.174.144.144) To BY2PR0701MB2101.namprd07.prod.outlook.com (10.163.156.154) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7bd4813-2894-4159-31c1-08d4f505d7c3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR0701MB2101; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB2101; 3:IOe05MATCYzsQ29bL7u2J0b4edNx1xLkmiXRAjxzlQdQyB4E1misZQWuFHDl2T1nc8iFLiFko58Gk8Kjpwm0N/S+KYP8wWjwuQGVmwVNLsKoJac1OgtRu+XH+Ix/lroAI6Ke38WZfqxDCgwj91O6FSH5Bd+OmHPk7erFlMcU/hVtv6QGCendWAewqCoAELXdK1/z0TodWY+UL6acL3nF4W8HSdsrppjLeSVJjTsLe4/B0IyZ59FaxTIqRpMJbb+l; 25:cilZ3lyidTlmi363YscyVEmH+jeUAVoV8bFHpG019gBFeYvVmwQJpMw1JgeUb4a/3wnuR43UBlLE+p7ckMVjgS8R9AmhSKfL1lK4fR2ZtVq/2iqovqTytEVUq14GX4zgPCoQDqOgbzMowGOkdEVooPDHkTdMRVWMnscLAEoggZz2/VSJzHJiwyLujw6ofIqjNUXnPHY7qEbscSrZLGb7fzoQX+ZZ5q2Rw1WbQNUI15lPYo+vT5pDLoekMagXK8kHdAucwzLRdVfoXTPos6rG6/3wgYr2QXbzjrrwjxPEfmLNG0Cv2HXiH9Kmwr0C77fSIb17bprmRBXUgM+Jxdi5zw==; 31:lIghcqp3W4KmiBNZZZbpfwWWVz7zoTs1gJk2yg4x4rnJXZSp0OaYfNsfcoiTDgpRBa/ltPq54c5JExsPogWnqI/KiV2lMzynuPGgBMZ/nV6RP3rRK+Buzd9EhY6uNc905iru4STgatXRBvc7djx013g8tbt38eQFVRj7A2wJEqpGY6042yUAlYVKWzr8k6QZoeLMeTXg0FqeNBDSq2T9mmR4rk67PbupB3ESicrR7BQ= X-MS-TrafficTypeDiagnostic: BY2PR0701MB2101: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB2101; 20:3rW+Sxhk9DnJ/ZMR0Ib6aufn4g8S/MWzE3RFfcbEwWpc7xUY4Khfwh1rgsAiuJnM+mxx0E1NFSQInZgLa5c9QzP33r9MC4JSgwzQ52GfNLhkrUlmtnOzuDUGF7V618ukkiuvNoNBVw9zsF4SlNG9V8mBlwRbR/62QnGr1G3mMlOgtBEqMNANtkAy9qAHba4qZDHk6qF3AlO56hcQGIfb8f2OAGiCSvCMLtty01lYswBVhaZYpW/UkXiuAjLTI4ewM5q5vvWwI0TUXuss6KUD4lPJLrsxc8nmHHbCBR9EN1cnYUzkPvPWLn6y1aAc1rgrCrFuwnvbP7NrtEhrUWTDGyTr97ETKfogbJt15gUfSIZGDaqlJbtHxQiwuQOyY3R5Ij7wlqRHjldFSq2ORxJ50XasOYocW+Fzw8iDXzJRuP0oNf1ZwJpE9wNvVSM02uzP7P8bi3MWkzYy8BrEd4u1KAabwD303/UIlWjF9dKaNImpbVPu0hIbmSTjhUxdqmVP/abiGCV1QtqEghzeRwNDBtE6thpqAzB2Jn2fgCPjEEu7sH1QA7nhPGAVr1oZrye4V1cJ3GKYSMA4eVxL6ntD2L5OB8WjCdrdwkwMv20Fe0Q=; 4:QEoGZ/LPkXxl07ydqPnZ0BlRjsMRVqJyFGKdVevrDTCO1ZexDyyTuRK+rp2qB1G79q5IySFGixc11xAvzN/Gi5zXpnFYkqrv4ta01NeLPXEdmtVzxbp//fuX6U0s11pHBwcrz29NTyRxNDcCV1GLkKXtmPck9hmnaqg7WUNralNWsALVBaUBEej+jyhpJX2Hjg3/pTsF+stSo/m/a4ie2QMjLWM6o7ltRc4FkY2rCAB/B6C7GHBB9RI4ULqjcA3DcA7arM0m/DugVmExNrRtbTpjADqZAZz8MboKUA6xkG0= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0701MB2101; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0701MB2101; X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(24454002)(189002)(199003)(42186005)(1076002)(69596002)(105586002)(6666003)(5660300001)(21086003)(66066001)(53936002)(55016002)(3846002)(68736007)(50986999)(36756003)(76176999)(23726003)(54356999)(53546010)(9686003)(6306002)(2950100002)(25786009)(966005)(101416001)(106356001)(6116002)(2906002)(42882006)(72206003)(478600001)(6916009)(110136004)(6246003)(53376002)(4326008)(8676002)(6506006)(33656002)(50466002)(83506001)(229853002)(81166006)(305945005)(5009440100003)(47776003)(97736004)(81156014)(189998001)(8936002)(4001350100001)(7736002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB2101; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0701MB2101; 23:mt/gLjMzGYqKV1LTMpNQ33wZAMHR8Rsqueyx732?= =?us-ascii?Q?fJ0PqROO93ZsfCJaz8tYc/x5ZP5i2SdVPLei2sWIlXMx1amGISqT9daxj0dd?= =?us-ascii?Q?/X9oC0UgNLYnrRVs5tZno2OaeLikM8hvlMKOmMi3TK2mT/Fz+jebg11YAuFQ?= =?us-ascii?Q?DRTr786BIR2u1eLaP9B5gjh/73QOrsDjellQuy1fAplLbvFziUq4lspIcuWQ?= =?us-ascii?Q?gd7Nd5jqIyBoQ0IgV2/wT5WL7uNynKpz/ezwAGjM8DfS5waM1IsDXU3wvsW+?= =?us-ascii?Q?Qr7247BjQfo1I/JL7Rr9VLX1+Rhug193Sv1IApgxXZom15B9TaytbsIwasEr?= =?us-ascii?Q?GF+MbfNluTxyTKJV++2d+ehiPjhaxaGxI1amBm5nVt80FNjZp2FynB/ccF2X?= =?us-ascii?Q?bZp5K3tsfnVjNeG8yvIl9X2E4F534zyawg9yGrLjsPH0KPV55OJvp96/zqAX?= =?us-ascii?Q?yMZuvc7xitkDaFP+6QjRDVTqvZhI3s4D93MHqLL6WA6O20KQmWWTheojDodE?= =?us-ascii?Q?TM/oQ2jokQ5J25MANyTZhGk1zwsrZuiRVIp2vrc/gWsv9RAF7ymWdjng6TZm?= =?us-ascii?Q?zRIz2m2QrN80rci6gaqAC3Kftc6f44PT3d63D+oAmfF8aEh8GajrLaHWptFZ?= =?us-ascii?Q?oIw2hVg0O/r3+7da6vdiG4C99Fgj9x0Vasr62q8NdwtjORRTiHiwgfCY/6SX?= =?us-ascii?Q?uC5YbKgYJVKv+7zxwoxUDoz11uoxs/at2t/46Ug+5x42zcjTSOEFr8SUBFOU?= =?us-ascii?Q?wm0redSuLqItuwjsJVQIqSRZHaFCYxikzdK5z/yNc5SjEbKe3LjQe09LmKat?= =?us-ascii?Q?OFN1gQHxnDClA7v31b/cEIGyc9xfaffBTOPlUkjAgLoovtWqY543f6biLOwJ?= =?us-ascii?Q?nZlayhjA1V7Nae2qPAQLzxcHOI1/F9gUzkdJImJiOP67m2gHlUKgRYm4VBTR?= =?us-ascii?Q?zZky10T4yWO6vHyUFr+WyFvbWQZCzt6BpxhfUJ4tNY5M4WWKcjm9o5ytN6c8?= =?us-ascii?Q?k1r8wYXK6GvPb/xSCN5r+V6V6Le92SgpxUaU6HoOxCa6iZiyZmD2oOGllHBX?= =?us-ascii?Q?77RPKG9VR+IBfivqNwKVT4uIQMN/HcJ/2ccnHWUflOLzYljAIr0ZFYepk57b?= =?us-ascii?Q?+LFAxEH5NY1Gj7VM60H6cxH2TPEMYr1MSXoXxww5lJ81jH8xm4QNPtrC6tNg?= =?us-ascii?Q?90CQzo0h1cHXWbuDiLquyehXU9VLqfgvpmh3QnVv8DrcDxyAB6rsp7XfzWOa?= =?us-ascii?Q?+BfCr83sMvX3WUCz0/VlN+A2XWetBKbDHafI4NpCSKl9Xd7xwC8gMT5cxfnY?= =?us-ascii?Q?aImUfEOb2OTMaFXuT8JXsKYiur28T3MNiAL2HwuiYu78gO+l9mleu/ECxmyI?= =?us-ascii?Q?l0vV71A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB2101; 6:FB9Ef6xFKgWICWd7NKWC9ZSpxE43LMGYhOKbRkpB05iiwJ3gBvfu20f3cN1GniqC08SML+z9NIr5/OWCXA8+kSu7bF5s0vwg+KQhyZmzPNt8YEjDz3QBhBRnHWt26I1EJLvDpFts92rOkgp7GeWDthHkJ7i7nrPqBxJ4oAx5ouhEn3En67oTERsZ0/MOuXjHDsY2HyDizBwtBDYV78RSrkoc3rEG7T6knm9+5vgNndVKSFs75n8cuCOh4Hyh1mjIk0wl1pHPZ/52wvsxTwk7liXbkyd7PFO7QVss+km0xHlHo7QIA2b7ftnutMd9K1CKjGRVZvYiIZC2v2gJ3Vz1Lw==; 5:DcQY+dZZYMcsuZsNJHJ9cJl+BbTSj/zPxdcV9xDHBoKOPLllQiTRh5j52V9jNvDomZDBNsLRlzLviANNHCKEvJ6pQlCaDgywrk/nk2KoU9HRD536bkCZoQ+P1iP3mq3bRxCuUjRMBybcHypirm/hyg==; 24:FwieK04Fu5RIkZs9rf97PTs8bxLzUV3ZzBGZHBQ9YnIqwSW3M7xgz9ZX6dgCejNEed2GlFQd9l+dhxnb7DXZF3C+p3db7SqlhwdaLTkluxk=; 7:LvKm/wpANXuMkVQ5vnl27ScE6SkO43wrDQtMFddA7PsmcZtvGJibZ47B380nSl1B5Wt7kfjFFadxJQ2pxepVn5QiZu/5Dwy3YoOR7Rn15257S+rJZRZmqnThveTJ9hYQGUJLmRcamqRkSxdRxfYS4+3oWSP3xzyZNMMRsayUo3O9hJaFs7hK/9Da14FQ+UyrCgsJVLwOg8dAL4v7TFFuu85uCdMAp0XZsqefQ/W6+pE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 09:01:19.8679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB2101 Subject: Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 09:01:23 -0000 On Wed, Sep 06, 2017 at 08:53:30AM +0000, Van Haaren, Harry wrote: > > From: Guduri Prathyusha [mailto:gprathyusha@caviumnetworks.com] > > Sent: Wednesday, September 6, 2017 8:16 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Guduri Prathyusha > > Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function > > > > lcore_states store the state of the lcore. Fixing the invalid > > dereference of lcore_states with service number > > > > Unit test case service_lcore_start_stop fails with the above fix. > > Service core was stopped without stopping the service. > > > > This commit fixes the test by adding negative and positive cases of > > stopping the service lcore before and after stopping the service > > respectively > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Fixes: f038a81e1c56 ("service: add unit tests") > > > > Signed-off-by: Guduri Prathyusha > > Thanks for fixing and rebase / update to v2. Please mark the v1 of this patchset as "Superseded" in patchwork. > > Reviewed-by: Harry van Haaren > > > > This patch is based on [1] > > To be totally clear, this patch depends on the service cores (v2) patchset, > as linked at [1]. > > Thanks. Updated the patchwork status for v1 -Prathyusha > > v2 changes: > > - Combined Patch 1/2 and 2/2 of v1 > > - Rebased to the future service core patches [1] > > > > [1] http://dpdk.org/dev/patchwork/patch/27684/ >