From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id CD3677CA3 for ; Wed, 6 Sep 2017 18:23:19 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id y15so14843402wrc.2 for ; Wed, 06 Sep 2017 09:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dVEVAqgWUEGBDTKGZh8k3oTmyBEzX8w+Kem+3PemkPA=; b=rDSmczu+ZYizcC0ErBZlSTY2eIeqaHws/EOhMEKt0OjrsNvPRzf5hxhE1CQok8Iy+P nB6PKfnMH82iUaOwpJ+ufWf4cw6292YiEWEvZP29UQ57JUjn6hX/7FDwvio+o8JUuemH cYuaj2KyP40mkNHjhhaS4Cjeu6j5fl8ybcNsYJoYv2/Ii1VF00aEoBjt7C2vopQTT7LI J3oSRnnUDzVHpXv0qzJsLJ97ZFtnL6JXiN1X0kY+RlGAFJT8YGXNFOp/D3o0Rg7/Gdnr 9ATTkNWIgd6cb+qomw2r316atnN5R7IZFl8wn/lolh04nzTVRcA5/x6GTOO084D4wBct 3Vkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dVEVAqgWUEGBDTKGZh8k3oTmyBEzX8w+Kem+3PemkPA=; b=KHlQG/WegoxPvzYxEc0+DHSX7lkwGgdBi2eal09kVkNrYCWKcGa9q6z6BdHjRC4k8U dHxYZbRD57UzVnbXrVgobKZmB65Ijv75CYwIOP8nzRLQNz00+PbPJ5/DT9bdT+eiWHoS B3F78NwUTzOzOCyCPG5j9Zm/RNTJNdwOS3UA1wEoic9PRMCSGMOW4tuAvEhsCWmv1LJF wT36flaM0GNcbCkRDMyHH0hdsAZO3CjD1GPcFY4K1DohK9NBdohKUWbFF7VA9Lg1xtDq 8tauOZdyhVhtBLqpFIPAnQy3cwSb5pT9CgQ+VNnJzHiywDp9+8IQfvAfj+FJznBM3Aar Lm/w== X-Gm-Message-State: AHPjjUgS+ITIt1KwQZ1NMDUE1lizpUUM/91RWqN+l3XdZCfOGUJPDCfc UMAoofkRfeobJ9mKhKc= X-Google-Smtp-Source: ADKCNb5PVkFHZHJxsLDDmtw2BLzEAgOBJ/2GWasiTneVRlx1gXIAhGGf4vUqfC4brh4FUO15OHg6pg== X-Received: by 10.223.141.235 with SMTP id o98mr2208861wrb.242.1504714999310; Wed, 06 Sep 2017 09:23:19 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q18sm218756wre.4.2017.09.06.09.23.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Sep 2017 09:23:18 -0700 (PDT) Date: Wed, 6 Sep 2017 18:23:02 +0200 From: Adrien Mazarguil To: Cristian Dumitrescu Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com Message-ID: <20170906162302.GD4301@6wind.com> References: <1496162653-137817-3-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-1-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-4-git-send-email-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503705973-80742-4-git-send-email-cristian.dumitrescu@intel.com> Subject: Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 16:23:20 -0000 Hi Cristian, This commit should probably come first in the series since the rest relies on it, right? Subject line does not conform past commits, it should start with "ethdev:" and not mention "rte_flow" (use "flow API"). On Sat, Aug 26, 2017 at 01:06:13AM +0100, Cristian Dumitrescu wrote: > Signed-off-by: Cristian Dumitrescu A short description of what this new item does and why it's added is necessary. Context provided by the rest of the series will not always be available. More comments below. > --- > lib/librte_ether/rte_flow.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h > index bba6169..5569a87 100644 > --- a/lib/librte_ether/rte_flow.h > +++ b/lib/librte_ether/rte_flow.h > @@ -915,6 +915,14 @@ enum rte_flow_action_type { > * See struct rte_flow_action_vf. > */ > RTE_FLOW_ACTION_TYPE_VF, > + > + /** > + * Traffic metering and policing (MTR). > + * > + * See struct rte_flow_action_meter. > + * See file rte_mtr.h for MTR object configuration. > + */ > + RTE_FLOW_ACTION_TYPE_METER, > }; > > /** > @@ -1008,6 +1016,20 @@ struct rte_flow_action_vf { > }; > > /** > + * RTE_FLOW_ACTION_TYPE_METER > + * > + * Traffic metering and policing (MTR). > + * > + * Packets matched by items of this type can be either dropped or passed to the > + * next item with their color set by the MTR object. > + * > + * Non-terminating by default. > + */ > +struct rte_flow_action_meter { > + uint32_t mtr_id; /**< MTR object ID created with rte_mtr_create(). */ > +}; > + Default mask definition is missing. > +/** > * Definition of a single action. > * > * A list of actions is terminated by a END action. > -- > 2.7.4 > Even if MTR is a separate API, please add to this commit: - Documentation update: guides/prog_guide/rte_flow.rst - Testpmd update: app/test-pmd/cmdline_flow.c - Testpmd documentation update: doc/guides/testpmd_app_ug/testpmd_funcs.rst You can find examples in previous commits related to rte_flow. -- Adrien Mazarguil 6WIND