From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: cleanup strerror function
Date: Thu, 7 Sep 2017 10:51:52 -0700 [thread overview]
Message-ID: <20170907105152.4faa7110@xeon-e3> (raw)
In-Reply-To: <20170907130956.157969-1-bruce.richardson@intel.com>
On Thu, 7 Sep 2017 14:09:56 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> + /* BSD puts a colon in the "unknown error" messages, Linux doesn't */
> +#ifdef RTE_EXEC_ENV_BSDAPP
> + static const char *sep = ":";
> +#else
> + static const char *sep = "";
> +#endif
This is seems unnecessary to me just have the message be different.
next prev parent reply other threads:[~2017-09-07 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 13:09 Bruce Richardson
2017-09-07 17:51 ` Stephen Hemminger [this message]
2017-09-08 9:03 ` Bruce Richardson
2017-09-15 10:47 ` Van Haaren, Harry
2017-10-05 21:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907105152.4faa7110@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).