From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id C11122BFF
 for <dev@dpdk.org>; Thu,  7 Sep 2017 19:51:54 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id e1so624359pfk.1
 for <dev@dpdk.org>; Thu, 07 Sep 2017 10:51:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=zJNC3OfoBL6bOaVKyS7+t2kBhyx/7JXtRQoMyWwX2S0=;
 b=NyK0wKyh2gZAlXJJw5UjXKpb3RhihpE3cIGeB1gLwQjOjK774eZc3w+mVFmV4H7Zis
 i1ZT4Xpc/Gjx4rwnxWdf8jh3or8G6GLcIKHDHazkh3+852LG+kx3laz+oXHSFnrVd9CT
 w29j72evaizNbOFLMnSdshVN7l61gXVQ6gXbr4tFB6C0dKNNnyI81Uvuna7rMjtr/RpE
 P/Smig8tdRCkWuzqlouAL4j8DOpMxjqm47WULJMhlPwYHuZgQqyj1ZKiwHrfioVht86Q
 fkUZkuZ30kCc6o/0ZkqySsOoaRh3oWaOkva7EyUSBoZAgH55Uu1zlwDcuklDE0AmqbSx
 g88A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=zJNC3OfoBL6bOaVKyS7+t2kBhyx/7JXtRQoMyWwX2S0=;
 b=uWOwIgJmWxYuFz2QKQ+QGmMYiWI0J2ViuWjPOTKWTPnDUdFokN9PCHIxmYS+J2eddU
 RB8/5wv5gdx3zT05pJ7qh32vZV++3axw4nPyLwQsPGbJ67gbHM20HkVCEVqtKEF6WxQ3
 cf7GNNwlQEKo2eAnbfeBaJREQNMc+Zw5WAXCLR06Plm1vs69i+LxJDYNAPPWAnABwMX+
 23R/QB9HqAIFU2YVsKTiTIbT0/SG4LQatBdhfhAW9COYCdU6nuuZoRSTDu1BQPSTuA2r
 QiOYjroNrCwdR/eQYRT6/MGDOSho81wt8hZaNQuVFEKKqmersgA6BAA6bjCdqi/1LEz/
 XGwQ==
X-Gm-Message-State: AHPjjUiKH13E4pihNUbmDFr5uahnuYhS6DkeGbsonKgXTRnRV3g/d6W4
 A5xgJBPs2dkT/yzJ
X-Google-Smtp-Source: ADKCNb7VqTHIt56F5hRHpJDZrCCJNqP9aObGIDOwlAQ1qqdIHgLkLMaswpVsvvoVdnpc4hBki6Al/Q==
X-Received: by 10.101.78.201 with SMTP id w9mr164579pgq.24.1504806713996;
 Thu, 07 Sep 2017 10:51:53 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id j7sm335466pfb.30.2017.09.07.10.51.53
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 07 Sep 2017 10:51:53 -0700 (PDT)
Date: Thu, 7 Sep 2017 10:51:52 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Message-ID: <20170907105152.4faa7110@xeon-e3>
In-Reply-To: <20170907130956.157969-1-bruce.richardson@intel.com>
References: <20170907130956.157969-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal: cleanup strerror function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2017 17:51:55 -0000

On Thu,  7 Sep 2017 14:09:56 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> +	/* BSD puts a colon in the "unknown error" messages, Linux doesn't */
> +#ifdef RTE_EXEC_ENV_BSDAPP
> +	static const char *sep = ":";
> +#else
> +	static const char *sep = "";
> +#endif

This is seems unnecessary to me just have the message be different.