From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f54.google.com (mail-pg0-f54.google.com [74.125.83.54]) by dpdk.org (Postfix) with ESMTP id 2CE5C199AB for ; Thu, 7 Sep 2017 13:55:04 +0200 (CEST) Received: by mail-pg0-f54.google.com with SMTP id v66so20308074pgb.5 for ; Thu, 07 Sep 2017 04:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XYdcTpLT44h8kvVmPiSG1VKcLHTgzi8GiD83pLppeTg=; b=KNRYBlz7+Eck6A0kxrK3aQipee1lTz5YTSRttU3yLJ3rnyykrI+IwxX9gQYTSQemyB Y5Z0Eh3bct5LdSTqZlO+s8qELgDrMb/3cgi6i3hVBa3cjqILAAwIINVZn08p4aVb9T3m yCeO0zV+J4/yO750/bL32QDeA9XOFRqD523kM244OZBkrNdyRNOztv1fQx/2GdHoN01s sB9mrYW7ulp5c4ieCiWhwJrnCrGnG3Vk9B1N3BXlmu1ihpIM84qxeoMSEHWc1EZb5TJB 6VlmTmuWUNGInsVoiER1JA1yLSV4yQqlrOt7BAjPNcz1j9D8Pg38IU4w53HHl+ZOjfKx wgUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XYdcTpLT44h8kvVmPiSG1VKcLHTgzi8GiD83pLppeTg=; b=i/TbXUIXpIuydKhAhppzWMUhW7ZO1UiQ3SD/O4i67VV9ypZo9wrZQxjnCzval9+s0P 39YqtBpzCNHWrOvQmx87e6+XXswPIgC1/j2rGpCr91T1HByeepk+VQOHqm0rH1aCB1ME FVEDjPvFKey8jscbehEEK8YnVUNl+B2G98TqgcHspDts9Y5HBReY5EdezeGyIpet/8g6 c7KOKRd4g+/FAhdT302rVWeIYEgsCDMRO0ijNMIZcRVq6CXC7HttJojA6bz7i+tPLfGo XdfJW/6V2OUI3tMi1XwRpHhXhN/pTdHwYKluw5O6ObksSHUKveN5GvHzQXzofsZn9gz5 MhYQ== X-Gm-Message-State: AHPjjUgwISUA/oLdWEhfUboxQpRbT9+nsyFtbp/vdnHcUxpMwg/M5aGy 7WzPLrMvTPC0U+I5 X-Google-Smtp-Source: ADKCNb5tGK9N1OfgJHx/e+MLYpgOVeoYZZ7lDQB1o0iZULW+pZDXt28s9zMFWYPK/V+iteLzdEpgXA== X-Received: by 10.84.236.76 with SMTP id h12mr2742768pln.181.1504785303984; Thu, 07 Sep 2017 04:55:03 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id z30sm4187481pfg.54.2017.09.07.04.55.01 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Sep 2017 04:55:02 -0700 (PDT) Date: Thu, 7 Sep 2017 19:54:48 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: dev@dpdk.org, jfreiman@redhat.com, tiwei.bie@intel.com, mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com Message-ID: <20170907115448.GA9736@yliu-home> References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831095023.21037-2-maxime.coquelin@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 01/21] Revert "vhost: workaround MQ fails to startup" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 11:55:05 -0000 On Thu, Aug 31, 2017 at 11:50:03AM +0200, Maxime Coquelin wrote: > This reverts commit 04d81227960b5c1cf2f11f492100979ead20c526. > > As agreed when this workaround was introduced, it can be reverted > as Qemu v2.10 that fixes the issue is now out. First of all, I'm very sorry for being so late on review! I didn't quite remember we have come an agreement on that. I think my old concern still counts: how do you handle the combo like DPDK v17.11 and QEMU v2.7-2.9 (assume we take this patch in DPDK v17.11) ? Note that it's not a trivial bug, it's a fatal bug that freezes QEMU, IIRC. --yliu > The reply-ack feature is required for vhost-user IOMMU support. > > Signed-off-by: Maxime Coquelin