From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id E533926A8 for ; Fri, 8 Sep 2017 18:04:01 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id v66so5512411pgb.5 for ; Fri, 08 Sep 2017 09:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gzd++iJz0u4NzlQVshF7yM/YV1kdRCxz9wZVOEqk/ZQ=; b=ojRBwKuV6so88u9UGHf05QWl0/d5WN0NS3UvR8AmkuPPIe67Do+PN3R84zVdYSxA4q 6qqSUcyFwmf46FzC4HA2NPCqmH/D8l8vFwiFdLpNmMjdOBVtz25S7+IuDqVvigDl4rna 9DwHCa5adBKukzDwtuQpA+ybGJHL049eoXOpXbD9P6JKBtejN9/01CfrE2n47h520bVa QWBc8KM129WVfoeMBIFuWHkQgllFoXlAcRM/bbRfcP6RM/pG77nfG2MX6JsSBSCz1mMm 8pf5vnQkqr01y6Wzponv2nrEUfasX5uygYOG3QRfbrPsK+xQriPC69uoK7NrRu2X+wam ZPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gzd++iJz0u4NzlQVshF7yM/YV1kdRCxz9wZVOEqk/ZQ=; b=pUVmAoV6kfXdof6k/ScPBh7/shXKeG1k8MhaNz2XX1YRtXdk0ikv4L9uIN9sngtdSe jnumnbyV1fmJMH42JKg485q0rUM6XNespneVD7KAxfZaJetmBoBAZALRUDnm1a567K8o q/oYHd479l4/2OVf3j/W2RmvhkxOuvAzBre8EQQ0gn/ttOb58q+e7R0BRmdSBJJrQ8w2 W/AQOm47rSWxcAiUnwBMh1KPlPpX8uthVbh5ozljpGQyT0EHKpDvFErF/xOKiFdLO+pa Mf/qcOmBqqtPM3g1VG2hPPW7O+SCxkr1Ej8g7o7WomnG6hV60/ymC7VFMbPd6zD/QJ6p fcKw== X-Gm-Message-State: AHPjjUjNMGEzXDLCr4oGQbPBW5jn5AsenNJSK5iQRv4T5ugzhU+1Rd/N ZVHFZ8UavMTlL2SYRMpJnw== X-Google-Smtp-Source: ADKCNb6d/Xbg3H9wSBfGgF2KtCUAOgEYE2Iha+ah8s176arQ/dfzaqFWtuVZVPKqrMXnIu90FLZZpg== X-Received: by 10.99.140.78 with SMTP id q14mr3552809pgn.223.1504886641145; Fri, 08 Sep 2017 09:04:01 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id a75sm4563508pfe.48.2017.09.08.09.04.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Sep 2017 09:04:00 -0700 (PDT) Date: Fri, 8 Sep 2017 09:03:51 -0700 From: Stephen Hemminger To: Xueming Li Cc: Sergio Gonzalez Monroy , dev@dpdk.org Message-ID: <20170908090351.457fe42c@xeon-e3> In-Reply-To: <20170908145055.50280-1-xuemingl@mellanox.com> References: <20170823022926.169272-1-xuemingl@mellanox.com> <20170908145055.50280-1-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 16:04:02 -0000 On Fri, 8 Sep 2017 22:50:54 +0800 Xueming Li wrote: > - printf("rte_zmalloc didn't zero" > + printf("rte_zmalloc didn't zero " > "the allocated memory\n"); Please don't break error messages onto two lines. It makes it harder to use tools like grep and google searches to find where message is located. Checkpatch and other tools make an exception for long lines in quoted strings.