From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tiwei.bie@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id C6D782BB4
 for <dev@dpdk.org>; Mon, 11 Sep 2017 03:27:04 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga105.jf.intel.com with ESMTP; 10 Sep 2017 18:27:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,375,1500966000"; d="scan'208";a="1013008671"
Received: from debian-zgviawfucg.sh.intel.com (HELO debian-ZGViaWFuCg)
 ([10.67.104.160])
 by orsmga003.jf.intel.com with ESMTP; 10 Sep 2017 18:27:02 -0700
Date: Mon, 11 Sep 2017 09:27:27 +0800
From: Tiwei Bie <tiwei.bie@intel.com>
To: santosh <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com,
 Zhihong Wang <zhihong.wang@intel.com>,
 Zhiyong Yang <zhiyong.yang@intel.com>
Message-ID: <20170911012726.GA25709@debian-ZGViaWFuCg>
References: <20170824021939.21306-1-tiwei.bie@intel.com>
 <20170908125046.28739-1-tiwei.bie@intel.com>
 <8f9831eb-3673-fb6a-06c0-702c1d0e9d96@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8f9831eb-3673-fb6a-06c0-702c1d0e9d96@caviumnetworks.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Subject: Re: [dpdk-dev] [PATCH v2] vhost: adaptively batch small guest
 memory copies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 01:27:05 -0000

On Sat, Sep 09, 2017 at 08:28:57PM +0530, santosh wrote:
> On Friday 08 September 2017 06:20 PM, Tiwei Bie wrote:
> > This patch adaptively batches the small guest memory copies.
> > By batching the small copies, the efficiency of executing the
> > memory LOAD instructions can be improved greatly, because the
> > memory LOAD latency can be effectively hidden by the pipeline.
> > We saw great performance boosts for small packets PVP test.
> >
> > This patch improves the performance for small packets, and has
> > distinguished the packets by size. So although the performance
> > for big packets doesn't change, it makes it relatively easy to
> > do some special optimizations for the big packets too.
> >
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > ---
> > This optimization depends on the CPU internal pipeline design.
> > So further tests (e.g. ARM) from the community is appreciated.
> >
> > v2: s/burst_copy/batch_copy/g
> 
> In pvp setup for arm64 platform, no performance drop noticed with this patch but no significant performance gain either. Tested-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 

Thank you very much for testing this patch!

Best regards,
Tiwei Bie