From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id F0D4F6D45 for ; Mon, 11 Sep 2017 10:18:20 +0200 (CEST) Received: from [37.171.83.211] (helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1drK0X-0001C4-HY; Mon, 11 Sep 2017 10:23:57 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 11 Sep 2017 10:18:04 +0200 Date: Mon, 11 Sep 2017 10:18:04 +0200 From: Olivier MATZ To: Neil Horman Cc: dev@dpdk.org, bruce.richardson@intel.com Message-ID: <20170911081801.tnf7qtt4qq5jkofe@neon> References: <20170830135154.32092-1-olivier.matz@6wind.com> <20170906145101.11537-1-olivier.matz@6wind.com> <20170908134649.GA4086@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170908134649.GA4086@hmswarspite.think-freely.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] devtools: rework abi checker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 08:18:21 -0000 Hello Neil, On Fri, Sep 08, 2017 at 09:46:49AM -0400, Neil Horman wrote: > On Wed, Sep 06, 2017 at 04:51:01PM +0200, Olivier Matz wrote: > > The intiatial version of the script had some limitations: > > - cannot work on a non-clean workspace > > - environment variables are not documented > > - no compilation log in case of failure > > - return success even it abi is incompatible > > > > This patch addresses these issues and rework the code. > > > > Signed-off-by: Olivier Matz > > --- > > > > v1->v2: > > - use /usr/bin/env to find bash (which is required) > > - fix displayed path to html reports > > - reword help for -f option > > > This still doesn't seem to work. Running the following: > ./validate-abi.sh v17.05 v17.08 > > produces no report, and the end of the abi-check.log file contains: > > [nhorman@hmswarspite abi-check]$ tail -n 10 ./abi-check.log > CMD: abi-dumper librte_vhost.so -o /home/nhorman/git/dpdk/devtools/abi-check/222555480/librte_vhost.so.dump -lver 222555480 > Reading debug-info > WARNING: incompatible build option detected: -O0 (required -Og for better analysis) > Creating ABI dump > > The object ABI has been dumped to: > /home/nhorman/git/dpdk/devtools/abi-check/222555480/librte_vhost.so.dump > CMD: cd ../.. > CMD: git clone ./.. /home/nhorman/git/dpdk/devtools/abi-check/02657b4ad > fatal: repository './..' does not exist > > The warning I assume should be fixed to, but the second clone failing seems to > be the most salient bit here Thanks for testing. The script was not behaving well when not started from dpdk root dir. It's fixed, I'm sending a v3. I changed the -O0 into -Og, and I also had to append -Wno-error because the compilation fails with -Og (variable may be used uninitialized). I'll send another patch to fix it. Some warnings are still displayed: these are false positive from abi-dumper. The compilation flags are "[...] -O3 [...] -Og [...]". The second -O switch overrides the first one, but it is not properly detected. It could be workarounded by setting a global optimization level (which does not exist yet) instead of overring it through EXTRA_CFLAGS. Olivier