From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 15C542C05 for ; Mon, 11 Sep 2017 14:06:43 +0200 (CEST) Received: by mail-pf0-f174.google.com with SMTP id y29so12895830pff.0 for ; Mon, 11 Sep 2017 05:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+zlzyiSnYwiLSt8pHGN1ww17uBnzqiYkHDRVGAO5x6w=; b=HR999S+ceZGlZRBef0HPFgB4YHbCfWGI7Au88qkN+/r0EMtzacuOTPpapUVSpiRIWi 0UaF3gP/pIZo0EAjkRld/T+tLxPdgavP6habAw5mZ90DT8snVd9C1eupTnyKWReoJe1U NYQ6uqJVcCTnHyQxX/aRPwYEWEXSY8RJCK4IvMHuh4GeCJRirtv6M4HfEVuh3AwnFTfu GL6ubi0+FAzbYRdvrHHF7IpFtVKTE8QvPEdKvb2ZAjHT5lbU0BbcJn7zLsD6DziQNOmv Bup++rj2W8EPYw6CUdANMctaXK+UJelX6Y2HV0a1UNQL7SbNs+wiZOkNDJBDJ9tBFqkO /vzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+zlzyiSnYwiLSt8pHGN1ww17uBnzqiYkHDRVGAO5x6w=; b=QeHKC65DLTXWS0PeOXiEUz8nBt4W0YCnYPMq06QmLBHB+GHRrnn6CfPPE4ns2pRFS3 CxMKFD9Svtn33uP3jhGbbSnA6y9/GdCikT+By9fMLoJGHQJO2ek2G8kWgkwDalF4ZrRs tCUYJMJ+PUOkUxNsC9krFC+vI7zxyjRzs1mDCs3YTDfKJgx8p1PWq+WetY9zoNFnE1pa oD1hOD5NgjfQmRyTIC2ksGaV6InR0CLYN3vSwvyiA6OW7uwOnYx8Ao8L+D1a1hP641OL tsbnO+m2kkLA31uYtBjIhlj2wVwopq1f6qBcu0OB/OaFUmN0HZVaenAhXla+lgYczxBX dE6Q== X-Gm-Message-State: AHPjjUgDyTT1PyUC2Uy1Z7rPhEFUfFnNwbXICEXvrxAxQg5ZtlNMx5Lt VViIbxd9R5EzrbOH X-Google-Smtp-Source: ADKCNb4q8trHFv9JEa7QE3LU38Aq76hVlJZ0O+lLU4hIv31SIPqy2g+BpGljq0y+cOFAnGXBZJccSw== X-Received: by 10.84.216.94 with SMTP id f30mr13256291plj.278.1505131602378; Mon, 11 Sep 2017 05:06:42 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id 5sm15793556pfr.151.2017.09.11.05.06.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 Sep 2017 05:06:41 -0700 (PDT) Date: Mon, 11 Sep 2017 20:06:34 +0800 From: Yuanhan Liu To: santosh Cc: Tiwei Bie , dev@dpdk.org, maxime.coquelin@redhat.com, Zhihong Wang , Zhiyong Yang Message-ID: <20170911120634.GE9736@yliu-home> References: <20170824021939.21306-1-tiwei.bie@intel.com> <20170908125046.28739-1-tiwei.bie@intel.com> <8f9831eb-3673-fb6a-06c0-702c1d0e9d96@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f9831eb-3673-fb6a-06c0-702c1d0e9d96@caviumnetworks.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] vhost: adaptively batch small guest memory copies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 12:06:44 -0000 On Sat, Sep 09, 2017 at 08:28:57PM +0530, santosh wrote: > On Friday 08 September 2017 06:20 PM, Tiwei Bie wrote: > > This patch adaptively batches the small guest memory copies. > > By batching the small copies, the efficiency of executing the > > memory LOAD instructions can be improved greatly, because the > > memory LOAD latency can be effectively hidden by the pipeline. > > We saw great performance boosts for small packets PVP test. > > > > This patch improves the performance for small packets, and has > > distinguished the packets by size. So although the performance > > for big packets doesn't change, it makes it relatively easy to > > do some special optimizations for the big packets too. > > > > Signed-off-by: Tiwei Bie > > Signed-off-by: Zhihong Wang > > Signed-off-by: Zhiyong Yang > > Reviewed-by: Maxime Coquelin > > --- > > This optimization depends on the CPU internal pipeline design. > > So further tests (e.g. ARM) from the community is appreciated. > > > > v2: s/burst_copy/batch_copy/g > > In pvp setup for arm64 platform, no performance drop noticed with this patch but no significant performance gain either. Tested-by: Santosh Shukla Applied to dpdk-next-virtio. Thanks. --yliu