* [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value
@ 2017-09-12 9:05 Congwen Zhang
2017-09-12 10:19 ` Adrien Mazarguil
0 siblings, 1 reply; 2+ messages in thread
From: Congwen Zhang @ 2017-09-12 9:05 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Congwen Zhang
In function mlx5_pci_probe(), tunnel_en actually be used without
being initialized. Fix it by initializing it to 0.
Signe-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
drivers/net/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index b7e5046..95e62ad 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -452,7 +452,7 @@ struct mlx5_args {
struct ibv_device_attr device_attr;
unsigned int sriov;
unsigned int mps;
- unsigned int tunnel_en;
+ unsigned int tunnel_en = 0;
int idx;
int i;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value
2017-09-12 9:05 [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value Congwen Zhang
@ 2017-09-12 10:19 ` Adrien Mazarguil
0 siblings, 0 replies; 2+ messages in thread
From: Adrien Mazarguil @ 2017-09-12 10:19 UTC (permalink / raw)
To: Congwen Zhang; +Cc: nelio.laranjeiro, dev
Hi Congwen,
On Tue, Sep 12, 2017 at 05:05:50PM +0800, Congwen Zhang wrote:
> In function mlx5_pci_probe(), tunnel_en actually be used without
> being initialized. Fix it by initializing it to 0.
>
> Signe-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
Thanks, however it's already been addressed [1]. The related commit is only
part of dpdk-next-net though, it's not merged in the main tree yet.
[1] http://dpdk.org/ml/archives/dev/2017-September/074271.html
> ---
> drivers/net/mlx5/mlx5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index b7e5046..95e62ad 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -452,7 +452,7 @@ struct mlx5_args {
> struct ibv_device_attr device_attr;
> unsigned int sriov;
> unsigned int mps;
> - unsigned int tunnel_en;
> + unsigned int tunnel_en = 0;
> int idx;
> int i;
>
> --
> 1.8.3.1
>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-12 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-12 9:05 [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value Congwen Zhang
2017-09-12 10:19 ` Adrien Mazarguil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).