From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id E1DDC2BA4 for ; Tue, 12 Sep 2017 12:19:39 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id o42so20200850wrb.3 for ; Tue, 12 Sep 2017 03:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=alhUjKn9ijMfO4TmQYl0une2WFCehqcZSKe0o21eRwg=; b=mGB79kVpmibV+6kSE044EctNkOsM7/AO6C3MGCVqi6O/sY/q/3ACgcZi3fhKrtBoDu 3lPAn11X2uhJjBie0sf/B58YX/HnhKBA4i7Fybaqg5k6Ixfx8gI47uTng8ihS0Dwsv03 kL6tqBNDuYHeW/SQLgh4bQMHSVeSzgZ4ypQdHNR0uf4cizg5rWG9OGP022gXt71yfCG3 i4g20+YIvrgzxYfDkiivWrFFnKS7MLSf3dvwm0vHOynfgY9nw/9cbWrvSa6A/CyrES8Y wJEPmrUdKqnBOl/CNkG6cfdocDEft0Xwk5OLYAo8JyLxsK8x9iW/MLJxd8CkWeHoxx2K +jiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=alhUjKn9ijMfO4TmQYl0une2WFCehqcZSKe0o21eRwg=; b=kRhS31TktfVZVSsYGhd2iW7nx5UgYGN+pTB26s8T6TnZq9Zp0YyO3MeHK3rwnpf6A6 M9VvmXm47aukR3eoDQdQscH2yz3VRP2d+F0+LXAUF5WB828A4mq0BrbW+k97KgJ+6YF6 Kgnx2JKf+5odgRZmnJpa91p+W3tDFDTp4YLb8ujSkav0GghOgidsidbHqrwkYQaN7RuG 3M0Bzou50OlbDnVe7IH1cKl3g0wwm6d+fqxBv8r34crYtWb7cOScZmN3RMXYkRW36osx qwQ0Y/29i61/FzxHcIrnXq+KDXeljNDws/4LX0DUlteZGk2obu0D4iHxlJP5Cfy5VI8P JMZQ== X-Gm-Message-State: AHPjjUjOV0oAPcxnbUAMgJtLwBEvcVgJ96IiM0FRSUZO6Gb1Nzz7kojL Qikmkif9s4W8QcZ6NW4= X-Google-Smtp-Source: ADKCNb4GR/RiX0XZK312hRTUTZjUfHsl0n3cg5/7/AM5oOfy4X3nfaPXtS5etuF4cXZEPNNI0Ms/hA== X-Received: by 10.223.160.119 with SMTP id l52mr11364991wrl.53.1505211579674; Tue, 12 Sep 2017 03:19:39 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a19sm17889995wra.64.2017.09.12.03.19.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Sep 2017 03:19:38 -0700 (PDT) Date: Tue, 12 Sep 2017 12:19:29 +0200 From: Adrien Mazarguil To: Congwen Zhang Cc: nelio.laranjeiro@6wind.com, dev@dpdk.org Message-ID: <20170912101929.GM2481@6wind.com> References: <201709120914.v8C9Evq8012512@mse01.zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201709120914.v8C9Evq8012512@mse01.zte.com.cn> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 10:19:40 -0000 Hi Congwen, On Tue, Sep 12, 2017 at 05:05:50PM +0800, Congwen Zhang wrote: > In function mlx5_pci_probe(), tunnel_en actually be used without > being initialized. Fix it by initializing it to 0. > > Signe-off-by: Congwen Zhang Thanks, however it's already been addressed [1]. The related commit is only part of dpdk-next-net though, it's not merged in the main tree yet. [1] http://dpdk.org/ml/archives/dev/2017-September/074271.html > --- > drivers/net/mlx5/mlx5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index b7e5046..95e62ad 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -452,7 +452,7 @@ struct mlx5_args { > struct ibv_device_attr device_attr; > unsigned int sriov; > unsigned int mps; > - unsigned int tunnel_en; > + unsigned int tunnel_en = 0; > int idx; > int i; > > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND