From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 636C82C58 for ; Thu, 14 Sep 2017 10:11:55 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id a137so3947026wma.0 for ; Thu, 14 Sep 2017 01:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NJ3/BS2MJJeDrSi7MMtSQ1G/vp1ZDmP8HMTqfbWYmRk=; b=1+xXQxClIPaCLqRBERnoNTtA05iR/NIpC/YRn3WfXZU8dYK3xQi672MBTqffOn/CfK opwBCfKPN04dsCQpwgMOR6PEYHeOHEvMRtownsQPK/GCQXJlWpB2uTc8UbrAS+9NBo3p 1ZVxskACmdqf3+8MHU4mJKO5g7zM3yEegi7Im09W0M4E+sy96lXdrtsZim0u1+GKnctB c0Ad9ZPbelDfYu3OR+UG3NwEFY10x6/O9snFZNNw2vs1JuJRi2gbiUwHJw884Nvpv3E8 y64FwV/tPuTe9A6blzP7z/qgjOzHK8TCOBLI3Nlo/+aD8n9wDjFuZn/CdcWk/q3Zu2tE /3Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NJ3/BS2MJJeDrSi7MMtSQ1G/vp1ZDmP8HMTqfbWYmRk=; b=PeOBlCjoxxuTrUl5T0VgfQJZBbx412imsluuTshHKrbMF/vBtzlYoShG0xLkse6Aq5 tO3PBv+ww5q5R3PvJ/cIdJcwNj2uj4FmBjv8WMmo61hE5WmxTox59d3X6fUfH/4c06Av o2++D2gsW6zxa/WKTFSeoxBOsl0AkMwRIPtKyC8+rAbob2FytKIRa8R9J0pSvpCMN26G ScDtD5TqBrLYivOe2ZZtfKwA/DNA1qE9hwfPwUBhkTbs9UWCCKmYB102RBa3+ChEz4qr W3Z6WQzophwBoewwnw74e5IynXbdI2o9xuXd0Dnloqf2NA8Ei3CVxO6fdYDZqAAZVVwK 1+iA== X-Gm-Message-State: AHPjjUjWXCxz8iXt+Gt4eIgx+6yzLeZ5w0TJOUeR4HG2VXMjUXnetxjC J2sD+7v+rkRb+Ncm X-Google-Smtp-Source: AOwi7QDyppLniIr/R3L5xhGiU5s+ma5QBm8AL1wGFeNufKSFW2+EaZzkxQbhg8qzThRe2ul3B33Nlw== X-Received: by 10.28.167.8 with SMTP id q8mr1059711wme.98.1505376715101; Thu, 14 Sep 2017 01:11:55 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f10sm17731544wrg.20.2017.09.14.01.11.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 01:11:54 -0700 (PDT) Date: Thu, 14 Sep 2017 10:11:44 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: yskoh@mellanox.com, adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170914081144.GD11032@autoinstall.dev.6wind.com> References: <7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 08:11:55 -0000 On Wed, Sep 13, 2017 at 01:50:37PM +0300, Shahaf Shuler wrote: > The current Tx error counter counts, according to its description, > the total number of packets not sent when TX ring full. It is reported > to application as part of oerrors field. > > The drop due to full ring is not the statistic that should be set on > oerrors field. Such number can be counted by the application using the > return value of the Tx burst function. > The number that should be set there is the number of packets the device > could not transmit in any way, even when it has resources. > > Therefore, replace this counter to count the total number of failed > transmitted packets. > > Fixes: 87011737b715 ("mlx5: add software counters") > Cc: stable@dpdk.org > Cc: adrien.mazarguil@6wind.com > > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND