DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: shijith.thotton@cavium.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/liquidio: fix uninitialized variable
Date: Fri, 15 Sep 2017 16:57:47 +0530	[thread overview]
Message-ID: <20170915112746.GA8025@localhost.localdomain> (raw)
In-Reply-To: <1505442779-15698-1-git-send-email-wang.yong19@zte.com.cn>

On Thu, Sep 14, 2017 at 10:32:59PM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/liquidio/lio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..a5a71f8 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
>  	link.link_status = ETH_LINK_DOWN;
>  	link.link_speed = ETH_SPEED_NUM_NONE;
>  	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_autoneg = ETH_LINK_FIXED;

Thanks for noting. Proper value would be ETH_LINK_AUTONEG as we negotiate speed
in firmware.

>  	memset(&old, 0, sizeof(old));
>  
>  	/* Return what we found */
> -- 
> 1.8.3.1
> 

      reply	other threads:[~2017-09-15 11:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15  2:32 Yong Wang
2017-09-15 11:27 ` Shijith Thotton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915112746.GA8025@localhost.localdomain \
    --to=shijith.thotton@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=shijith.thotton@cavium.com \
    --cc=wang.yong19@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).