From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0050.outbound.protection.outlook.com [104.47.36.50]) by dpdk.org (Postfix) with ESMTP id 452211396 for ; Fri, 15 Sep 2017 13:28:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8MUpJWljRw4RISpf1qE3zCyrw5PaZqb8fN5EEZjhIDM=; b=X2CGlw4Y9kaNYfaXH5r1bfQLKp15wgG75Sv2JPzoPPNFT4YeMnWIJq78JosRfnwb20K9+8/Nrb3Vr8IlrUxWmL0S67pdpusZYsT3mKd6CRs6TESztfOd6aghD2wi612iP+OClfEEJiLIwgqBEnlryntfjka7JVHm2sPjIoZJMU0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from localhost.localdomain (14.140.2.178) by MWHPR07MB3071.namprd07.prod.outlook.com (10.172.97.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 11:28:04 +0000 Date: Fri, 15 Sep 2017 16:57:47 +0530 From: Shijith Thotton To: Yong Wang Cc: shijith.thotton@cavium.com, dev@dpdk.org Message-ID: <20170915112746.GA8025@localhost.localdomain> References: <1505442779-15698-1-git-send-email-wang.yong19@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505442779-15698-1-git-send-email-wang.yong19@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0083.INDPRD01.PROD.OUTLOOK.COM (10.174.208.151) To MWHPR07MB3071.namprd07.prod.outlook.com (10.172.97.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe3d1750-ed70-4527-bbd1-08d4fc2cd55c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHPR07MB3071; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 3:5qhJBMIfO12GjM05NBbDl5Q/HUEHJl6KAWKex6Gr10F1/hWkUN2p1mIiewgCean128q6hi/0AgtgHNgwm92mgdXhri7YTmNfgN4Y4Jg1nnNHsRA2cpG57zbsAiVy//GrMOvIB80KaimvojSnmzJn1OSk5QtTCLPHwvNsl50YRNQI+aO3vGjSkRzPWMWCkHWIWitXo4igqbcFR8azAyn8ZLueFQjluPkgwEnZ0IaS6OTsRH7Gjz8n4XuqkpF7Om/M; 25:ihmySBFoA4YOKt9j8ip4PW3XJk3jAObfQ30VYV5fHIIlnRS0HTwZs6aZLmekdV44PGlI6WdoDProeSSAEzfJIZ5l0LPVxeunPzoo0CExNZACI7NjKu9TfUCIUObYQrJ7uUMDjRz4XdaSKkLowhHXoFNaei06zxqtvjl/vuhV1MSYuttxbnpJlA0vbdnI0OXGEii1dwAdQ0W+F1ykfPpLjTqUMFBnm9/taRYZ/HXEOSxJQQmfOzpYRMX3W6ofVcP2kbVzpZRKoS3xSRqwjVtR16f5d9692Gf2VNvLZ9hH7SGu429OyvRIHoicitYsyBfZmgVAOrHV10+NN+eh471PgQ==; 31:MLwjQPTJ+0zEnFQIsv4ZO+/J6gBtH1enU0MlHzDTd59BQkqyhNGTENgqlOKQjqS7Ov70JWtl8nWwLUsRKK0PNAiYOhz5DlYV+xzMRSjuojSUWWiuvW301jPictUrJwsuVy46ikts49CoGpRUKQ14517uiA2Qe/UWOrTnJyQ8+hyGMDGtjqewj4lZfVC5yozhmmrreEvN6W3EKs6tsMYAlBXDx85UFu65b2LoKyqdE+Y= X-MS-TrafficTypeDiagnostic: MWHPR07MB3071: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 20:Iloo8b3gceIwL2qbgiAmHW5k0BDe+zkO0CmYr+AZ87rTJvgayo9bMWzCu8izamKXYR6POhp+fQJxkiZ48GfjvzyjzYCAgRUiqb94WbqffTpjX/aL9ftZbwAFjvLeneldGFwD9xWdN/9k/j07XXiLJFDYZOZ1zY0K4fwv6Cu3gf7U0GFt+82PODIPMDCwLw0zSURdZt4qUH2Kf7k3u+l8dW/sn+TuZyElGZUNn7Cb0AaCrDBzC1NmCSanWnyBnB3svL1RYQTH/Jg9tEsVPzqJgkTJ9+++sPl8/z9i5RgYbYrnMzZOTLjkPMWiRd0wlSHgTBdu8dlfaEAc+hvQNJLS242A5qD4cjopVSSjK///a6ZX+oU877vEH7q4BFqJE7lLnZ3usaBv3sjR52C5anbFjqn4dJJh9edJq2Gps2F/YXMZ4JwGttttAR1hPWFdL8jsgjY54yLbyUXcsP0yNh1yXcIn8gx1DhV2Od9tQLqz1Acy9xMc3V9Sg1RTkwHTCNtr33Fsz9zaV59prIDVuCnS6nPLgrELGAqmKuqAU7Y36rDhBUWjSXjuaSAQUzvanWHDDYl6B26c3EiwH8JJ/ZqKTJwZ5NP1jfM0jON2q83Gm/s=; 4:nqxSIO5usz7kEiKiZZyteUGl4dl1W7BgTfNdBI56hMTobSYjZir2PlKVh2EjlrtG9Nm0yLI2M2HzTTUZP5lG/qyEDKTNRvlP41li8tJscHN/oBPYxHhI768p4Bdr15Eu+4tPDVZPsFU72sKHf1+qUc9y90LB534XylHI6OdIAoK92+PvYeW9eNmHw11nzbSFdvWxGUxjo2dsJg8co6ByPoA+dkFVkM1AqTef8VW2ynj2/0k+f5ndjAbxVWuqOZF/ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3071; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3071; X-Forefront-PRVS: 0431F981D8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(346002)(376002)(189002)(199003)(24454002)(106356001)(229853002)(5009440100003)(8936002)(53936002)(54356999)(101416001)(6246003)(72206003)(23726003)(478600001)(9686003)(58126008)(7736002)(16586007)(16526017)(97736004)(316002)(8676002)(83506001)(81166006)(55016002)(81156014)(305945005)(6506006)(6666003)(189998001)(1076002)(25786009)(5660300001)(47776003)(66066001)(6916009)(105586002)(2950100002)(42882006)(76176999)(50986999)(3846002)(4326008)(50466002)(110136004)(33656002)(61506002)(6116002)(2906002)(68736007)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3071; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3071; 23:nRzCVqe4TcqKR5xY6I3BGMGnNecd/rxVjj/QQjU+e?= =?us-ascii?Q?oOptwDssTsqzbQ4kkymYW5d08tEPsesrG/KJHJpU0dm68OO/lNlL3tfPXvzV?= =?us-ascii?Q?uhngUa9Gc3T26lM+gURRBV3zF1zQBYCxdo1+HrzGZ/MmmN3Iv2YnX4aqIJcH?= =?us-ascii?Q?/urjuhTPP8CniZKZ1KrvC1COHoAmTpXbJM++sMB7Aq2T45oTxXWbkvi/AN14?= =?us-ascii?Q?BVawhRplPAEP32Z3dWFAAp8M2eXehETKq0StLZIRIK4X03GEUfCMwSChna6T?= =?us-ascii?Q?DYrhGXbay70lKuYTeYfwMVxNNIslF3sbgwZtP1QpwYvKbspxeRYoF9HaxuWj?= =?us-ascii?Q?NAyJwZfMyWOco21jm7mI72WHsxlfgUCXUtxloPrxhfDQFA2EQ74Eg4gSEis7?= =?us-ascii?Q?b000PQPE85mwmOprcZvNBPAl7KPE7QElMc09+Z8cYE3g3AL4P6RxdRmLJ5ph?= =?us-ascii?Q?gqHgkWUMlrLUGtv0qPNF+PgXEeBAj31a7J5aTDL/uqpoVmvw/mMgHXI0EDQI?= =?us-ascii?Q?d/RKFTyS7BmIsDNvmdrsgXnRuVXmYBiGfp/g6TPl9wsJoMO08W+fi2T2J+ye?= =?us-ascii?Q?bAyfe/UR+BWxpBXlEnDPJGR9omlpFCochV6LYRZPsj1t4a893JDp6PZWkhAL?= =?us-ascii?Q?KBaWQgb7y+YD6sPB1WdXIghVXVUu/erZQiMpJvmlThuxaXZshdvyf1LPlGCC?= =?us-ascii?Q?Mib57ActQ0Z7He8DTAmeBHqFlV8YY3vDv+obcgCtZlGf5ceCEicLPtjpnSS8?= =?us-ascii?Q?yexpvmxF1+LlHhLaYVnDn6XV7c8MXc6e1S1WGQMgKLb1JSN9Eu0pC58NO/A1?= =?us-ascii?Q?jWpQCH6kd2/lLCmZwXbmQQAjZr1MqiOVoZJp5jHM+ks5BqvuxE+m1DV08phX?= =?us-ascii?Q?2eCJY+TbTOF7KdgqS0M8LWuXIb7dcb9k9qdA1KtAe/5MOF07D2gWsOsbRJgd?= =?us-ascii?Q?SaDmGwiQuhQdjohIZMxAj863xUZw3M7Pub6xPIF80RUL7Mvr4gotQLI3Z8dl?= =?us-ascii?Q?hev6xgRwkhl40qEU3AcVOvitWoPVz6l2+VmyX3J+ZiWUeETgfoOKJugORk+8?= =?us-ascii?Q?kSohI89KQ5sxJ4xuN4UCe7ZYND/cO4ixnfK0dPzMrSv2OHSWFBdOv6mDEtaz?= =?us-ascii?Q?3+oJl2Q4QGO9AsL4F28gsEs8jKhoQdYak/U3dCo/W7pwdduFHkt/LwYHyCSQ?= =?us-ascii?Q?9wSfFABVuMoE5PoSkAKeYNO4Z25mbov1/bkUI4xO7fhKE863z5C+1aXwuM8r?= =?us-ascii?Q?ekgQJQlKmcnJMKywGWyZ0sM5nxCfMkbpKsHO4KFXjzU6BhZhhfvh54RW4rb6?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 6:LneUSJbtv9wmRg8fhqwzonkT3/I7WwnlRAre6t7mD/yofuJ8sYg821kUoGnFbjQQ/gJ6lqJjjqr3RuzlEYmXiHThX8Z+yOarPWqMoC3TkdCdMnu3BtXduh/XoMvBcgvNQUy4i7DM7iMz5/iPggRym/mdkGsdAcViHx4M8FEz0jIT5HUoAUD4e9+djQgLCHxUjEkU8pxABzV0GlyORlrTw0PUV2pwtUZeXP2lFiVXczAEUgk9UCatIbwNf9MgqegA05JqObiFpJdoqtNVlY9l8JRxkMIj4sQBow130HStn/6QcW/ISCIot+TVJE6j6XTAoLGyQMoT0HtCaPHpgj/LfQ==; 5:IDXVvh4bG3u1Qb2Vm+oKBQPg76NVMZ3kqsZN1entWey++rYNQX67FyMBhXz4GWxVSkYcYuS1U8LcNPEfNOeRxama91UnM8yOKmh89NM4KXKl50nM1Y8DyU/D46rvPYngAEJK2q5MVlevvIHIqkqs5g==; 24:NGAbuX88/zN+tOOSvIjXBXTDfbYBBBktNS8G4jrstunXhn/C3b7UvGetACaiQS1GiZfySQWdGujfQlAE6epPsRQ3xVT7PyYGP3c6nyKCU1Y=; 7:VbWXkzCpFqxOF0Xp6dImvSJX1okUgOcf5vkH4y02A0UUBaLl87hHhzyvH+b6D47SVj8zCzWm0+rkHpm7TsPqGI2dZ92GCjZFOZAI4SEmmT95hKWRYD+u7de9/zI2CYtu79Ryg1bJfoHmRiKFx8uVRtY0fAUztLXZnhb52Gw326rPrZMQTMrBU1x3V4zovJ4QJAoCm47i8DxgEgz8Cjm34Tw987KGRr746yx4n3Chktk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 11:28:04.0561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3071 Subject: Re: [dpdk-dev] [PATCH] net/liquidio: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 11:28:08 -0000 On Thu, Sep 14, 2017 at 10:32:59PM -0400, Yong Wang wrote: > In func lio_dev_link_update(), "link.link_autoneg" is used in func call > lio_dev_atomic_write_link_status(), but is uninitialized. > > Signed-off-by: Yong Wang > --- > drivers/net/liquidio/lio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 479936a..a5a71f8 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off { > link.link_status = ETH_LINK_DOWN; > link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > + link.link_autoneg = ETH_LINK_FIXED; Thanks for noting. Proper value would be ETH_LINK_AUTONEG as we negotiate speed in firmware. > memset(&old, 0, sizeof(old)); > > /* Return what we found */ > -- > 1.8.3.1 >