From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0060.outbound.protection.outlook.com [104.47.37.60]) by dpdk.org (Postfix) with ESMTP id 0ACCB2BBE for ; Fri, 15 Sep 2017 14:34:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1srXxMR32ZMc2L483VJ+DxAVJ6o1EDvwZ1oE5kMLHUw=; b=fcA+g5D5EyQf9segFj7jI70mlBDSaqCEE0IUsBuXWICLgWAtyodOEmFrrsR8O/ruR4S3hy1QvyGcCZloMT38gMNfMoEL4VQzm+oZ3IHqUIUexPKp/a5NDUZBnnwi8hSQ5TIcFisBqGqoRMKu0ZYqJew9uUuKmquzuG/QyWDJj40= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (14.140.2.178) by CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 12:34:12 +0000 Date: Fri, 15 Sep 2017 18:03:56 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170915123355.GA11197@jerin> References: <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0072.INDPRD01.PROD.OUTLOOK.COM (10.174.144.140) To CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc997a81-b387-4d9e-f3f3-08d4fc3612be X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 3:Bop6sbpsKZbq/JyHJdUA10k9TloN9c5bp7jpNYcwqKYZ+VmuwUD4xw4qQ2QqmRWMOsn/8Mq+K5hF109sIY6Z63/0k5Hd+K2UMfE8AOaWY6/RjWTgVqT7bJtkhi1UmqUuHaGwM6EGAp+vomvU63MxlZ7CzNgwO52m8xBBAC04Ks0g7CNVAMJk8y76aB5FvlDSDubC2E1vrIi+7qDwY4TbO7V9nETm0Zpi0XtKPjWjnjnDehX3V7b0KUiZfjUlQsdN; 25:cilcV5CT9N5yGwrMvzcHJucJqoqduch8nLJlxWnTmeswHnOJxgtSISnwnsesDb2jZepJaE/gdbQv8OPap/whSc1gyVn5IQlmlObj/gSvFHsQBPhS3W03nkhdR0bCd5m+yHjUHa8O0JMmbW+9jdDEJLhcUzXi9DBSA8SXFhbz3MZwcVptz7e/5RjGIpq0J6Jhl1Zh5kM1P+m4B6si+WdfCEgeU0+VhbNtzEjROKZiOymoXLCGP394nzW9KJl+P64cXZTIMW3m2MjXdeRQ1C4zWGQlsSBEdZKQwhIy20nOlqvXiqZfZVZUvnxoW+uaL/UzjQtbj129bV9REhgD/3F1uA==; 31:AsyMrfgB+cqL1Vt0Dmzs5hy4wwQrBrW4BoUbzphKcw+KBUpUeTKjK9cDR5kmm2Mffk/VCbGdDiOG2O91/bzEz045rQETfY0HqC/KHa2g+GytDa1uO16sLGIYENdkEgtVHTBlWr4WSU8YOsJ9Ep0pS+ddBeVQWAvAwB5ScjgDmcKOso5g4fPMtKlzZdadSeRq/kf/Thhj2wENmqYZtixebO/GgJeBjfr4khXI0un8r/Q= X-MS-TrafficTypeDiagnostic: CY1PR07MB2521: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 20:tT6xabt5emI7ybyu+yQ+F47kG5Y+nyDllZ67icFWT31JPGLKp3qQ2pSTJlqyp58mauHvh0eNjvktovCR/FrVNOg5AKy/HkxihZ8z7kRYgJZ2b+L7YIVIN5gOcIQPTX/3O6aTvUJilH0KCTWiq5LBQZxnAF/mzeTH2PpD04sUWsE9NKDMcTqOE/ujPtEr/0lbIjkcJtO86P7mLHSvTMOQAm/pRSGIsU6erdhFQ2IOGksGz+wQHtgZkzGAZ5qIOE/LiwjtmhVNQvNvj+KDKgfDQt+usg7FuXwwjXiXdyj3F34HFpv4qdkepEBY/gbhQObWY1uD3wtp3awmzWrlmBfPAmG2/HEaKzUmXc3E9ahdR+k4Rn6gnL/+XCuVpDsQgvnq+lvj3se64Iqmnabr9+5z7fo1S4uvhKOKQb9HBNL4oQOOQ6zF6STNryabIjoQoSNur/xZPU1NmHjvrvr+nTqMqFSRb/+U8bD//mz6mN4494Y5bed3nic7S1skW2MWTI//psGt/7WSAdURkC4ch05FwtRsRmxJ7VoscsWFJIioyD8oKq4gPxOnKN6UHQpyLCQvC52OlSXz6S0B68WfJ1ZU9nCs0yTiQwuTLXmuV+3+O84= X-Exchange-Antispam-Report-Test: UriScan:(211171220733660)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2521; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 4:DGDUJkdrURdJ4aEN9rElIw+CY5MHZKJADGVjiYy3DHjAzC7JebyzqsWdnZquEDsHby73CFGhcNPqdabwij7cdK7jgFJzH4Jp5MEZLzjx/ZB2rB5oBHPe2qIYvVsWTVH6AdT+/fHMgBxVMVJbkGnJLDSlfJk7JnbUfCOXN7vbMar6B9D843kcDhnrNLc2s9ki6rga7ZbwHKa7QvAjHY6ZNPYoO791zGQhZZVJz1xWTMrctoiJ/d5KjfbS7AKKK7S9tJ/WJc0faBwARWQsjs2xiHJ4yk0Z3A5Nh77WzmrZw4sCJOsoUz/oVmK+KdmY5MOSAjzTgKzrDc+jgC2zO7blgA== X-Forefront-PRVS: 0431F981D8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(13464003)(199003)(5660300001)(316002)(58126008)(101416001)(305945005)(16526017)(25786009)(76176999)(105586002)(54356999)(50986999)(16586007)(6666003)(7736002)(106356001)(97736004)(50466002)(81166006)(81156014)(229853002)(8676002)(68736007)(189998001)(33656002)(66066001)(47776003)(6306002)(83506001)(6246003)(2950100002)(1076002)(8936002)(9686003)(23726003)(2906002)(6496005)(72206003)(6916009)(5009440100003)(110136004)(966005)(478600001)(53376002)(55016002)(6116002)(42882006)(575784001)(4326008)(3846002)(53936002)(33716001)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2521; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2521; 23:z6NxFzwIWuyD4cylOPBRjpuWQZbaXG+GxOk96aPQV?= =?us-ascii?Q?lv3Dm0pHk2IU3hTZ2TDeXM0gKvMqfjpilNAVDloEHxxjWNGzOg1bfiEjRiT2?= =?us-ascii?Q?fAO7cpksS4qBPyJ1F6VWGIxDZQljJ3xANYu3EaudPJN47P5jrSmzp+/ymdx2?= =?us-ascii?Q?FKy8ZzRWzACc2eg9VkaA6YVbn4Nrv6Uu1uoto+Y4L2EVwR9Hp45CPYarX8Tc?= =?us-ascii?Q?x81+O4ESzZZWoXwze4ZDwUtCNrqHmems/99M0maiDHPhVaBzf79rw7WJ4DMm?= =?us-ascii?Q?8QRkH3ac0LZuouvXxir9kpbBnrYTbiaama8S+gPvIKmuyNtGP5Od7qIdgCAy?= =?us-ascii?Q?LchBn2Lu+gFoDgkROFHNajUj67tcrHMwQlAFBE3FLLPTL34zbxfimTg6BsUc?= =?us-ascii?Q?DNWtDMj+fZkU5D71iru7A3ujDlmkplSQcZ2NZcD7jXcqHcmMJ21ertmgFdKu?= =?us-ascii?Q?M26H/PHgABIB7IUaT+G4S6qr2nosjL0rvRTuVTNdeW6H6UDdg2phD4j39CZw?= =?us-ascii?Q?hSmGgjRsZmfaqKSi5a8jp/e1jPzF5OxEXcV+yV8lYrNOtd5ml/6pBWpjKP53?= =?us-ascii?Q?5u+DFDVq2/iRGxb2s5q1vJScNB5asTLJvdPo2SDkq86pUnpvZ3Gl1Q9KYsn0?= =?us-ascii?Q?93VcfNsvwYtu8J0IHqij/bRffmFGzYZt6Pc4e9bbZpm9hCa4FGC7yu0uwkzl?= =?us-ascii?Q?zMwv8bXIOMyuNH/WAATl4u7O10npu2+Y3BTM5dvMN9UPijd43jhASndGg1JL?= =?us-ascii?Q?pvNu/e8pNz9KGrsRlCnOFRxZoI725FlzHUKIPa7YO/bcMRUUnY7SzRxQ9t4l?= =?us-ascii?Q?geXmCIS3EbOr8sOjqN69NTPPg7TxvKQzCEAfUTSnnmStJSIZXIpGUGGgyNGQ?= =?us-ascii?Q?JExLeU7YoHQM7yXyoIfD/P/NIslwglT8lCh26mUDCzXAQEZR7TxxE4UkkmUo?= =?us-ascii?Q?JIpj9ikgaAQnsvDR8kwBEGikDClUwD4U+hYP48QqV3MKF3x1wSk/pNrSuvug?= =?us-ascii?Q?n7UIke/LU6ZTJfBaJeT3JWlQYGF+xpALKT7rAB+JrvCbi6v3dEK5Jn2gIDxd?= =?us-ascii?Q?b/LYZpK23YfQjQh3LzwyGy+iylEy5k5/mHaCt0G8TX1XQl6SCsH7z5sflYaO?= =?us-ascii?Q?UuQPetba0cFAirSZFGIVYFpd8OKZJOwIwx3dsfo5GVjd/jp6vDVOijeAhvTx?= =?us-ascii?Q?/5fkt5vf4/fG+0xBhk6GICyBor2uDo/NEAplh2/0vNJdbOdTK/ZfWndbTGYa?= =?us-ascii?Q?rOSSxu0GW/5PpgPoTZs8ek5uJG/jLtqvExxHSNIaX4V0wDK/bdtduqAFWxSd?= =?us-ascii?Q?i0hHfC6aL9HZdYh2E4EV8rxVx04Mx2V2yBcI0CkCwQiGgIMsbXQ0XDnyibRk?= =?us-ascii?Q?tippw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 6:S4dY8Illex4pl/t/+kjCCZYlzfuwunTbgY9LK1EIZeBTbteSR+mlwRJVjP37fKKidKWxLktX7h5Ge28QTFnBB6AZgME+mfUkFscYkJCqAqLu0C5cq2/FkLhO0Qbs+f9FtxVus4y4VVK4bGI1MkaHeCKzIHAgT35rcWqc1+qNFwurusPRDyljm2Ss4o4/ysGcEqhBI1bEerTK+UzLC57XqTHTc7CO1TZa9FGGyHSUtXE5raZE5XjCaWh+RKq1HjEr/DfFlTFhziK/nUAzFYr+Honm1chQCD/cwT62jTzdQH1Z5sKTZJ0tBx8wUoUqCcJmdeBNOptI9SUDVBQ8F6beJw==; 5:25tN9NXG3Tr0Ff006BfSHPq3C/5FGWgUMwEGwgn62Y5dCRTfViXMYktcai3v3LVRCLx2mdXrVUWQ4afgmHkEVTq0T9QEXQY56+EAccGf9vCrw5UqVcGp4u9eUG7BunCB2252rIMHCAIwhl74sqnVDB093jHHUI/HRfqsob9zpvU=; 24:E0CK5EmeOeaRBM/6d4QzZFbYCfbBf1DVrdizYFremjNsGC/L3LDiZafxzf3iEfzUAckBDKCwbSxw2Aaa27SHjaB+y+Y5S1Wlz2XfP7UpFNM=; 7:hEcaLy8Kjob19V46QAAGMkBwwpIF4/aIINIuwb4wCGqcORqTjMN2N2IHIKhN5zOqKLynf0u9QY383+krvJDAYG6rI9V0uB2RPS7m+3aBlcQKT+hwcn3G3fw77KRo9dKUqN++x85Mnlek0sXpLiWPtGqjyZ8WPUMbx8l5Gw6C29vPqNnG/1jnrFNStJUMJpnXKH5kIYO7lrg6dSUXd63OhmQXI+16BrTDtfT83uw+o5s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 12:34:12.1988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2521 Subject: Re: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 12:34:16 -0000 -----Original Message----- > Date: Thu, 14 Sep 2017 17:08:59 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v4 0/4] eventdev: add attribute based get APIs > X-Mailer: git-send-email 2.7.4 > > This patchset refactors the eventdev API to be more flexible > and capable. In particular, the API is capable of returning an > error value if an invalid device, port or attribute ID is passed > in, which was not possible with the previous APIs. > > The implementation of this patchset is based on a v1 patch[1], > and after some discussion this API was seen as the best solution. > > In terms of flexibility, the attribute id allows addition of new > common eventdev layer attributes without breaking ABI or adding > new functions. Note that these attributes are not data-path, and > that PMDs should continue to use the xstats API for reporting any > unique PMD statistics that are available. > > Regarding API/ABI compatibility, I have removed the functions from > the .map files - please review the .map file changes for ABI issues > carefully. > > The last patch of this series adds a started attribute to the device, > allowing the application to query if a device is currently running. > > -Harry > > [1] http://dpdk.org/dev/patchwork/patch/27152/ > > --- > > v4: > - Rework based on review by Jerin > - default: cases into switches > - Remove old functions from .map file > - Remove /* out */ parameters > - Rework header file definitions to match logical order > - Rework patch split > - Cleaner removal of queue_count() function The changes looks good. Since the functions are removed, we need to update .so version. Please update LIBABIVER(file: lib/librte_eventdev/Makefile) and update the release notes reference to the similar change: http://dpdk.org/browse/dpdk/commit/?id=945081a76ab0bb481f1d62125aa5b547fcc000bd