From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0042.outbound.protection.outlook.com [104.47.42.42]) by dpdk.org (Postfix) with ESMTP id CD0F23238 for ; Fri, 15 Sep 2017 19:38:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rJe9oTpPswxu3eRDAS2qc1IPvCfyVe1jQO+DeLbD+RI=; b=a0rQroO06sQzPheatpoHgAAxdOq+iiS2iwlA1zGGShBGBrbSix8sX9hKOvGdGwLGHVXPvHT0BIxH3dxqKXstmfSyakz4Ld2X0pZ+Pbtx/7DDSAyLMO3+XNK4FVQI5a7ELK70+K6XXX+DbQRFt2yyLUnEWDLv1TwEsseiy0NSyDQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (103.16.71.47) by CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.9; Fri, 15 Sep 2017 17:38:02 +0000 Date: Fri, 15 Sep 2017 23:07:41 +0530 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon Cc: harry.van.haaren@intel.com, dev@dpdk.org Message-ID: <20170915173740.GA21540@PBHAGAVATULA-LT> References: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com> <20170915145933.GA16776@PBHAGAVATULA-LT> <6875069.BRSTqJL15t@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6875069.BRSTqJL15t@xps> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR0601CA0024.apcprd06.prod.outlook.com (10.170.128.34) To CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f64f4ba-2aef-482a-c4c5-08d4fc60847d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3462; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 3:DHREAscjt2ZvT8KbqTk19EeMPc4tm9stGY0Kc3/6fePedCCFpDWxsC8XpY4H74ivDe6m3l0I1b48zdX7WBxNiClBht63jcDVnYm/pODj5/NAp7XaVn0MwTL2TfC3eCAMEhbkZkwWpR1/78XrRAREeQ8v1AW7q2qJRRGwYE0STVgp9WvGeGWqeT9+a6Dnvg8CHKWcSV4NcBUZIcI3c4WBvFGSeijI2Y+o/KUVhr68ctW39WTpOeUpJ5OEFuTnU4yp; 25:PTiwyJJCLl7ZSGZn0opqg32bLvOuli72AuFlPZtNeth5eaw01tYRHIWy6jbDzArYQve+KIU6mYjSCZHnrMrykMA9sPE6+bvBaul9ixwEEmTOVsKBSpcTmwrnHlKXeGmUPfYitM7hY1iJC8SMzlSYy+TO0R7/tJZEfRcynq7wJydd2IjJ5IcO45ZE/1ABsI4ndfzmt6QB763Zysvl3c2OIyzXTO4Qvo/yS+EJsvdpL/i1sOZB3N1i9tgkOfK2L6SFMFV19/KHBfkZSM+KitQkWf9yfiXc/BCfQ8pdVDY5FERdwOWgzBuQraOa/m8uvN6PJwTFxof9RG360gdRaJqePw==; 31:kUSTegVRnLX27vvcN8Hi+wlCR/7NpvkQRNfd1eFpPPe5ZvLy/+t2mWrx0jQ3PNCrWRcxjk3F/w807W4x6UL8c6IgPgj29GUwdjlwWUgDFIO29327WNEl4nHxgkHUK3qIrA0770WWfxTEuv0ehEQDpR5zIzqt6PqMdhJoa11E+MHT0Uc1vPnIbuPwpK76Fpxz7vY8JlR0lj576WAz/ylhlF4oEU58Qly58exlUr7RpOc= X-MS-TrafficTypeDiagnostic: CY4PR07MB3462: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 20:mtGPCbiE58dvSWh+NrhdJnxSt+aEMmjx6ZSuPnUHKtoUqnVE1T3JlVzoE/S/oymqKq7GqeK7nX/bdp+iKETSaTZ8KvIJ8aqc9abTuMPh/QyQYc6K/Ppp9fRhBuEIv4+yo+Lkfb6bKemBVlSeRnVYwmqfCWxbWEO0KOGBq1YYTnS8tE09TbrZclFeMybx6be6EiOfoGJfMtUfT/PjFrLyXDROCKO0/izvF/RKoGqZWYeQcJUyTtXUUUeqclE95YVoaPnS9gGK4lwC7nqXsjPQwFHyG1THcjynHqURg5QlkxghfU1If/hK43lXP8+hST3usdU8X4rL2EybG9xONQizExT+TvGk4APeFqn1bUQaujqiM7rcjgsuuKSK5LJuxmVV/HYh0y7yfKzFgtrur2puonmER4+uw5j2VA/575+ci6WxMsc6KwogAoE3I49pSVus1vdEOcN+JjOxfI294Qp2d2lhLtNNuN3hWo2wECTyN4Fpe+Ebv10jqTSjAgxbnuKZgMit9uBJ4dQnF97msc2E/QcabitnL2YY1O+CPN9p8tR82MzPG1umBweA8un5jy02edH3lYOVHUS0I6qvoNbigXmDDE4v/oo6gg38wBfckH8=; 4:Ch/lHgb9X9GZj2XSkPYVB4QWvo/tGhT+LpQT/JOjdTzxTWF2u8WevRjWiiWe+qO+myNgUE+Qc17NZDkbv/x9XHzVPJUfvrOkIxPOz+xC5jyQ9AB4JMUYlAFp64FR7c07Ex1DnP38DRS2w+Po4O6iIUyVZlL28p4TbJUegSMg+ljI/++QXo2JevUUbCV6MxAJ5y73Ull96NT2vOEYs6m/sYiGukvXcoprJz6QTp3HlpMsqcjSeQsJQYRCOHJ9Gdmq X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(100000703101)(100105400095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3462; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3462; X-Forefront-PRVS: 0431F981D8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(24454002)(76104003)(199003)(189002)(9686003)(305945005)(55016002)(7736002)(50986999)(2950100002)(105586002)(4326008)(6246003)(110136004)(6496005)(106356001)(53936002)(76176999)(81166006)(6666003)(42882006)(81156014)(8676002)(93886005)(8936002)(189998001)(229853002)(33656002)(54356999)(2906002)(25786009)(47776003)(72206003)(478600001)(66066001)(33716001)(101416001)(6916009)(316002)(5660300001)(58126008)(97736004)(16586007)(16526017)(68736007)(83506001)(50466002)(3846002)(6116002)(23726003)(1076002)(18370500001)(107986001)(81973001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3462; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3462; 23:fyFJ7bgOFCs/iHJXbmehnYyQ4TYmTkNSFf/mO3GF2?= =?us-ascii?Q?CZ9VUQ2dsvIAXi9nLb7tt+zUjG9c1OTkjP39R4BnV5i4BHTAgyaSMKvi+rDP?= =?us-ascii?Q?VZMmO2FI3TYRD2AhhEWsx/zF71X+YOtDm1dbZxh8XqWT/cXH0u0pEph5n2Iz?= =?us-ascii?Q?DK1bnp86Rh81uEUlSgOlY4Rg5J+I88o814sIlX4IcY5Aw+GJVJW6lVCVYcPK?= =?us-ascii?Q?VgLDMzx95UfyST+1WzqS9hXeSzru4r/uqH6TqGCkskM4pYi+RGJekf7ha/ml?= =?us-ascii?Q?QkVPEXDqih34RT9luHNkXQUim+7Qynr2cUeTAsHuRa5AXyS2zjs5zJlOAQ17?= =?us-ascii?Q?HwbLQFXUPOgukRT5x1c/r2vGncFpYeL2gFZrnDbqqGz1rr67rvW6kWZ4g6ik?= =?us-ascii?Q?ozK7WDXWp317l9TXeYFi6A+1bPdkhwVVppWs44OxzMHUGRebvxOPUYiRlQhm?= =?us-ascii?Q?VdfchmWtPLiwpjZ3CwYc+A+44mAwGtaqTvx7wpePN1gLCmzSsTNNx8hoon76?= =?us-ascii?Q?kUGFhCGGp4dXHYGTcwz1B9pV+usml6Zci/Kl2VYbNLzARR+ngVM6WBaAeCii?= =?us-ascii?Q?FBzFYTrn/ob3qZRaIhfuDZJRVByHdgqMJJTSmoPgpmq91M/va/KeWy5sc2Zt?= =?us-ascii?Q?/rOYsqK86jgUaQRfx2XbUU29MmMUJRmoou2JmHOFk3q9N0FzGaWBLpT4tM66?= =?us-ascii?Q?9iVsNI0+eqjG8gzWgDiQEKHytr2crCIsJftooShcvlm8wb7YKwy20fSShn06?= =?us-ascii?Q?3+RQZZyfV9sHsTSCa0WsJuEvahvUks3vK8Ne1uwkvE61nsPhkB9SqeNGYNXc?= =?us-ascii?Q?FclRLlMabH97nKhGXuTwtIA1dfY0sUjOa29cA3YaSq9tfhKvrXVESOvkPWie?= =?us-ascii?Q?NYDvdTfkpcBab2eMv2YOVnwBKsKSmZYTfp/Ji75z/obBWJ1tw/UYh33p8tFn?= =?us-ascii?Q?POQjvUPg3RwqkyQRoYjabgH6ml5k11IY6vaGGP0AGgIs5dRnNrDsC1qIq3va?= =?us-ascii?Q?Seq1CxMHdJyRnujrjbpN/LI+ak/5Sfa8NeVdS7UPYEKl33/aq68WBu5RoZYy?= =?us-ascii?Q?Xt8nXXc7bBJaGAF61bF9A9ociepXTaCijBg6DJ993WcLPvr3rC6LsNlSsdkg?= =?us-ascii?Q?aQkcanvFb9781js4h1Octu8sBqxHrG4uJi26NAcTdokG+Bf2fNY8CRYWpqYc?= =?us-ascii?Q?AwWDd8OErgxEiOY4e0w1PRFeJ5d7jNVNkuCKZt+ZFnI0V76STs+bF3pATfeR?= =?us-ascii?Q?dkCK4FfMfaa+VSStYHz06u1dRdMUHDkz+1fAPXBRkwwJ4zlM/ledvx6310aN?= =?us-ascii?Q?nPvU6G6Xqt0ElJAHw+XagM=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462; 6:/X0WGOKgYA1D261OnEPyfIFuKZ++h2uyHql4gP6n3lWe/ucTfxruRS0AsQYCVfyeaYkEOuyITYIuRgDafXG9NbDFReruII/sag0TDGSOw47ehlr1pSzqDTvw+rbu/Cyla/wPFkephtjGi+S3cLDp2uBJ7KwxmoYDqQG2kQZ+mBsb24Ee1K9cwS5FyMRG2ZT4baogCefjEO/3QUpStZ487hBs7emnTwc0acnYxgrmy1vvIVpvHUq1miUazUmOSf9fI9gz/etku/Mb3AlXfAHYkHUFDKenbJ8d3fXCDd/C23H/FY0ot7Q2tbpcLU2yeRvDs+d49RaPliY1+l1Mes6Xkg==; 5:/VZ8BvU/XiMeLwaaq2NBgXmIOYac7aqiigAxEJgn3pf6ZTxuGWYRkLR6CazQ5JhzIpCGNbz3dQQV1J1aWPCmWNjdDJPRvrHLsLq6fuAvLNH8HWp7plyhlOQWQYvwRzLwIwO+Mc9dnLcrg6zOOwWVnA==; 24:3N5kxqHj7ACqYidZJWy2MD20bzQPl2e+QkbfrZfTHzMiuuST7pQ2ftDmth7juaXqUdEMPi1VcKQmJwHvxTcbB1P/ala5LmsWTmjuFY+SwL0=; 7:4yNp7FjpGcKlTFyhBy8uqpJm6xicCAJ6tFDugZj2+YsWvu8pOBZs6zb5xhcEbEB91OgwAU4pRLssKoZLA/vLrDymAyvdM7W459VXBuKLa+m8FRECYZokkQNUTpAJdW0fx8c8LstCy8KwHff03HTLJK4mGTDtm5LHtSVuNGVbFq2uXWHx72TyZqBXp3DMWdOC27HfQThesJ6KxqPRtmuPcrjdnz6JJKbAryXFXsDqfTY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 17:38:02.3989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3462 Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 17:38:06 -0000 On Fri, Sep 15, 2017 at 05:51:36PM +0200, Thomas Monjalon wrote: > 15/09/2017 16:59, Pavan Nikhilesh Bhagavatula: > > On Fri, Sep 15, 2017 at 02:44:57PM +0000, Van Haaren, Harry wrote: > > > > > > > We could also choose to add this function to rte_service.h ? > > > > > > > > > > Yes that is an option, and OK with me. > > > > > > > > > > @Pavan what do you think of adding it to service.h, implement in .c and add > > > > to .map? > > > > > > > > > > > > > The ROLE_SERVICE/ROLE_RTE defines the role of a lcore so it made sense to put > > > > it in rte_lcore.h as lcore properties are accessed mostly through this header. > > > > I'm fine with adding it to service.h as suggested by Harry. > > > > > > > > -Pavan > > > > > > *as suggested by Thomas ;) > > > > > > Initially I thought it made more sense in lcore.h too, however the application > > > should only require knowing if core X is a service core if it cares about > > > services / service-cores, hence I'm fine with rte_service.h too. > > > > > > -Harry > > > > > Agreed, will spin up a v2. > > The most difficult is to find a good name for this function :) If not rte_lcore_is_service_core then how about rte_lcore_is_role_service? But this would need a sibling api rte_lcore_is_role_rte (or a better one) which is satisfied by rte_lcore_is_enabled :( IMO when role was limited to RTE & OFF rte_lcore_is_enabled fits now with new role SERVICE it looks out of place cause even service lcores are "enabled". Modifying rte_lcore_is_enabled would be a huge task (API change) as it is used widely in many places. -Pavan