From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8742123B for ; Mon, 18 Sep 2017 18:18:05 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 09:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="150477177" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga005.jf.intel.com with SMTP; 18 Sep 2017 09:18:01 -0700 Received: by (sSMTP sendmail emulation); Mon, 18 Sep 2017 17:18:01 +0100 Date: Mon, 18 Sep 2017 17:18:00 +0100 From: Bruce Richardson To: Vladimir Kuramshin Cc: tomasz.kantecki@intel.com, dev@dpdk.org Message-ID: <20170918161800.GA15712@bricha3-MOBL3.ger.corp.intel.com> References: <20170829095153.12627-1-v.kuramshin@samsung.com> <20170907114527.26649-1-v.kuramshin@samsung.com> <20170918144918.GA16860@bricha3-MOBL3.ger.corp.intel.com> <30bb4049-6336-5a61-b0bd-75924398f9be@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30bb4049-6336-5a61-b0bd-75924398f9be@samsung.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 16:18:05 -0000 On Mon, Sep 18, 2017 at 07:07:18PM +0300, Vladimir Kuramshin wrote: > I agree with you but the problem is that in this case I should also change > Makefile in order to add version checking there also but I don't know how to > write correct condition in Makefile that checks if it's higher or lower > version, e.g. if PQOS_VERSION > 1.3 then ... else ... > > If there was some spec file I'd add such checking there but I have Makefile > only. > > > Regards, > Vladimir Kuramshin > Yes, good point. However, if at least the check was in the C file, if the build fails, the user can be given a clear message as to why it fails. That can be another patch for another day, however. /Bruce > On 18.09.2017 17:49, Bruce Richardson wrote: > > On Thu, Sep 07, 2017 at 02:45:27PM +0300, Vladimir Kuramshin wrote: > > > Current version is compatible with PQOS version 1.3 > > > but not compatible with higher versions. This change > > > makes l2fwd-cat example compatible with versions since 1.4 > > > > > > Signed-off-by: Vladimir Kuramshin > > > --- > > > Version 2 changes: fixed checkpatch warnings > > > "Prefer 'unsigned int *' to bare use of 'unsigned *'" > > > > > I can confirm this at least allows the code to compile with the latest > > versions of the pqos library, which is currently broken. > > > > One enhancement might be to put into our code a check for PQOS_VERSION > > from pqos.h (which is, interestingly enough, currently at 1.1), to flag > > when we have an unsupported version - right now one that is too old. > > > > Otherwise, this is a good fix to have. > > > > Acked-by: Bruce Richardson > > > > > > >